New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFCORE-1487 Include indexed properties in the suggestion list if no c… #1512
Conversation
@@ -0,0 +1,60 @@ | |||
package org.jboss.as.cli.completion.operation.test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the copyright header:
/*
Copyright ${YEAR} Red Hat, Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
Other than my deeply meaningful copyright comment, I'll defer to @aloubyansky for review. :) |
Nice. Approved. Thanks a lot! |
Linux Build 3977 outcome was FAILURE using a merge of b536d33 |
The timeout may be related as it's a hang in CLIEmbedServerTestCase. |
That would be strange though as the changes affect only the Tab-completion. |
retest this please |
Full integration - Windows Build 1185 outcome was FAILURE using a merge of b536d33 Failed tests
|
Full integration - Windows Build 1186 outcome was FAILURE using a merge of b536d33 Failed tests
|
Rebased from latest master. Removed the trailing '=' from suggestions where value is required following change in #1519 |
retest this please |
Linux Build 3738 outcome was FAILURE using a merge of 273b121 Failed tests
|
Windows Build 3135 outcome was FAILURE using a merge of 273b121 Failed tests
|
retest this please |
Windows Build 3137 outcome was FAILURE using a merge of 5ff703b |
…ompleter exists
JIRA: https://issues.jboss.org/browse/WFCORE-1487