Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-3892 #196

Merged
merged 3 commits into from Oct 6, 2014

Conversation

@panossot
Copy link
Contributor

commented Sep 24, 2014

DomainLifecycleUtil.start() does not work if DomainLifecycleUtil.stop() is used to stop the host.

Addition of parameter closeConnectionBeforeStop that the user can reset during the tests in order not to close the Connection when stopping the host.

panossot
WFLY-3892 : DomainLifecycleUtil.start() does not work if DomainLifecy…
…cleUtil.stop() is used to stop the host.
@@ -113,6 +115,10 @@ public WildFlyManagedConfiguration getConfiguration() {
return configuration;
}

public void setCloseConnectionBeforeStop(boolean closeConnectionBeforeStop) {
this.closeConnectionBeforeStop = closeConnectionBeforeStop;
}

This comment has been minimized.

Copy link
@bstansberry

bstansberry Sep 24, 2014

Contributor

Why not use the configuration object?

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 24, 2014

Can one of the admins verify this patch?

@bstansberry

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2014

this is ok to test

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 24, 2014

Windows Build 213 is now running using a merge of 2c04e19

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 24, 2014

Linux Build 466 is now running using a merge of 2c04e19

@bstansberry

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2014

Could you comment showing what the failure is? The JIRA shows how to reproduce, but I just want to see the failure.

@@ -282,7 +288,8 @@ public synchronized void stop() {
} catch (Exception e) {
toThrow = new RuntimeException("Could not stop container", e);
} finally {
closeConnection();
if (closeConnectionBeforeStop)

This comment has been minimized.

Copy link
@emuckenhuber

emuckenhuber Sep 24, 2014

Contributor

start() always creates a new connection, so probably closeConnection() should just cleanup the domainClient, which will probably solve your issue as well?

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 24, 2014

Windows Build 213 outcome was SUCCESS using a merge of 2c04e19
Summary: Tests passed: 2598, ignored: 56 Build time: 0:14:11

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 24, 2014

Linux Build 466 outcome was SUCCESS using a merge of 2c04e19
Summary: Tests passed: 2598, ignored: 56 Build time: 0:16:16

@panossot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2014

This is the error is get if I use DomainLifecycleUtil.start() after DomainLifecycleUtil.stop():

java.lang.RuntimeException: Could not start container
at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:449)
at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:244)

@panossot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2014

Cleaning the domainClient solves the the issue. Thx Emmanuel.

panossot
WFLY-3892 : DomainLifecycleUtil.start() does not work if DomainLifecy…
…cleUtil.stop() is used to stop the host.
@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 25, 2014

Windows Build 219 is now running using a merge of 9d211d5

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 25, 2014

Linux Build 473 is now running using a merge of 9d211d5

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 25, 2014

Windows Build 219 outcome was SUCCESS using a merge of 9d211d5
Summary: Tests passed: 2598, ignored: 56 Build time: 0:13:58

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 25, 2014

Linux Build 473 outcome was SUCCESS using a merge of 9d211d5
Summary: Tests passed: 2598, ignored: 56 Build time: 0:16:20

@panossot

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2014

Retest this please.

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 29, 2014

Linux Build 486 is now running using a merge of 9d211d5

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 29, 2014

Windows Build 231 is now running using a merge of 9d211d5

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 29, 2014

Windows Build 231 outcome was SUCCESS using a merge of 9d211d5
Summary: Tests passed: 2598, ignored: 56 Build time: 0:13:18

@wildfly-ci

This comment has been minimized.

Copy link

commented Sep 29, 2014

Linux Build 486 outcome was SUCCESS using a merge of 9d211d5
Summary: Tests passed: 2598, ignored: 56 Build time: 0:16:17

@@ -297,6 +297,7 @@ public synchronized void stop() {
}
}
}
domainClient = null;

This comment has been minimized.

Copy link
@bstansberry

bstansberry Sep 30, 2014

Contributor

This should be in closeConnection(). If the connection is closed, the domainClient is no longer usable and the ref needs to be nulled.

panossot
WFLY-3892 : DomainLifecycleUtil.start() does not work if DomainLifecy…
…cleUtil.stop() is used to stop the host.
@wildfly-ci

This comment has been minimized.

Copy link

commented Oct 1, 2014

Windows Build 248 is now running using a merge of 4583a9c

@wildfly-ci

This comment has been minimized.

Copy link

commented Oct 1, 2014

Linux Build 505 is now running using a merge of 4583a9c

@wildfly-ci

This comment has been minimized.

Copy link

commented Oct 1, 2014

Windows Build 248 outcome was SUCCESS using a merge of 4583a9c
Summary: Tests passed: 2599, ignored: 56 Build time: 0:13:09

@wildfly-ci

This comment has been minimized.

Copy link

commented Oct 1, 2014

Linux Build 505 outcome was SUCCESS using a merge of 4583a9c
Summary: Tests passed: 2599, ignored: 56 Build time: 0:16:21

bstansberry added a commit that referenced this pull request Oct 6, 2014

@bstansberry bstansberry merged commit 661a634 into wildfly:master Oct 6, 2014

1 check passed

default TeamCity Build WildFly Core :: Pull Request :: Pull request aggregator finished: Running
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.