Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-127] Speed up embedded LDAP - use InMemory partitions for ApacheDS #201

Merged

Conversation

@kwart
Copy link
Contributor

kwart commented Sep 25, 2014

No description provided.

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Sep 25, 2014

Windows Build 222 is now running using a merge of 05f3fc0

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Sep 25, 2014

Linux Build 476 is now running using a merge of 05f3fc0

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Sep 25, 2014

Windows Build 222 outcome was SUCCESS using a merge of 05f3fc0
Summary: Tests passed: 2598, ignored: 56 Build time: 0:15:06

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Sep 25, 2014

Linux Build 476 outcome was SUCCESS using a merge of 05f3fc0
Summary: Tests passed: 2598, ignored: 56 Build time: 0:16:36

@kwart

This comment has been minimized.

Copy link
Contributor Author

kwart commented Sep 25, 2014

Comparison of domain-management component build with and without the patch on my PC.

time mvn clean install

Results from the original version (on-disk storage):

real    2m38.859s
user    1m16.617s
sys     0m2.887s

Results from the patched (in-memory LDAP):

real    0m39.791s
user    1m7.388s
sys     0m1.829s
@dmlloyd

This comment has been minimized.

Copy link
Member

dmlloyd commented Sep 25, 2014

I can't reproduce this dramatic result, here's what I get for the whole project:

No patch:

real    4m11.200s
user    6m21.438s
sys 0m15.824s

With patch:

real    3m54.248s
user    6m22.987s
sys 0m15.382s
@dmlloyd

This comment has been minimized.

Copy link
Member

dmlloyd commented Sep 25, 2014

Here are my times for just domain-management (granted I have an SSD):

No patch:

real    0m37.405s
user    0m41.217s
sys 0m1.116s

With patch:

real    0m20.309s
user    0m39.831s
sys 0m0.723s
@dmlloyd

This comment has been minimized.

Copy link
Member

dmlloyd commented Sep 25, 2014

The change does seem reasonable though, just want to point out the above, and that it doesn't seem to impact the time that CI takes to run the tests.

@ctomc

This comment has been minimized.

Copy link
Contributor

ctomc commented Sep 25, 2014

in my book any change that does less IO operations is a good one, so we can scale CI better :)

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Oct 1, 2014

I'm ok with it since we can easily revert it if it introduces trouble or it becomes a maintenance burden. I'm not a fan because it's a bunch of complex stuff that I doubt anyone who regularly works on WildFly other than Josef understands.

AIUI @darranl wanted to hold off on merging this until he had some domain-management changes done. Or was that just for the full wildfly variant?

@dmlloyd

This comment has been minimized.

Copy link
Member

dmlloyd commented Oct 1, 2014

@dmlloyd dmlloyd added the hold label Oct 3, 2014
@dmlloyd

This comment has been minimized.

Copy link
Member

dmlloyd commented Oct 3, 2014

Darran indicates that this PR in fact is the one that needs to be held, not wildfly/wildfly#6758.

@bstansberry bstansberry added ready-for-merge and removed hold labels Oct 7, 2014
@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Oct 7, 2014

retest this please

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Oct 7, 2014

I added the ready-for-merge label assuming the retest I just kicked off passes. I figure the retest is worthwhile given some fairly substantial changes in the code being tested went in yesterday.

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Oct 7, 2014

Linux Build 544 is now running using a merge of 05f3fc0

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Oct 7, 2014

Windows Build 284 is now running using a merge of 05f3fc0

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Oct 7, 2014

Windows Build 284 outcome was SUCCESS using a merge of 05f3fc0
Summary: Tests passed: 2601, ignored: 56 Build time: 0:13:24

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Oct 7, 2014

Linux Build 544 outcome was SUCCESS using a merge of 05f3fc0
Summary: Tests passed: 2601, ignored: 56 Build time: 0:16:32

bstansberry added a commit that referenced this pull request Oct 10, 2014
[WFCORE-127] Speed up embedded LDAP - use InMemory partitions for ApacheDS
@bstansberry bstansberry merged commit 2ce26f0 into wildfly:master Oct 10, 2014
1 check passed
1 check passed
default TeamCity Build WildFly Core :: Pull Request :: Pull request aggregator finished: Running
Details
iweiss pushed a commit to iweiss/wildfly-core that referenced this pull request Jun 6, 2016
[JBEAP-3788][WFCORE-1437] Allow disabling dynamic trustmanager via system property
@kwart kwart deleted the kwart:jbqa-10729-sec-realm-ldap-cache-wfly branch Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.