Skip to content

/ wildfly-core

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service.bat #3581

Merged
merged 1 commit into from Apr 14, 2019
Merged

Update service.bat #3581

merged 1 commit into from Apr 14, 2019

Conversation

@simonovdenis
Copy link
Contributor

simonovdenis commented Nov 2, 2018

Script is missing few features, which Wildfly/Commons Daemon provide:

  1. it is not possible to pass properties file to Wildfly instance
  2. it is not possible to pass environment variables to Wildfly instance(more concretely - JBOSS_MODULEPATH to specify one or more external module directories)
@wildfly-ci

This comment has been minimized.

Sign in to view
Copy link

wildfly-ci commented Nov 2, 2018

Can one of the admins verify this patch?
@jmesnil jmesnil requested a review from jamezp Mar 19, 2019
@jamezp

This comment has been minimized.

Sign in to view
Copy link
Member

jamezp commented Mar 19, 2019

this is ok to test
@jamezp

This comment has been minimized.

Sign in to view
Copy link
Member

jamezp commented Mar 19, 2019 •
edited

https://issues.jboss.org/browse/WFCORE-1386

I'm going to update the commit comment to include this JIRA id. Please note this will require me to force push this branch to your repository.
@jamezp jamezp force-pushed the simonovdenis:patch-1 branch from 3ca5cf8 to f6566c8 Mar 19, 2019
@jamezp
jamezp approved these changes Mar 19, 2019
View changes
Copy link
Member

jamezp left a comment

I don't really know how Windows services work, but this seems consistent with what we have so I'm okay with it.
@simonovdenis @jamezp
[WFCORE-1386] Update service.bat
fbfe07e
@jamezp jamezp force-pushed the simonovdenis:patch-1 branch from f6566c8 to fbfe07e Mar 21, 2019
@bstansberry bstansberry merged commit 81536e8 into wildfly:master Apr 14, 2019
@bstansberry

This comment has been minimized.

Sign in to view
Copy link
Contributor

bstansberry commented Apr 14, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp

Assignees
No one assigned
Labels
ready-for-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@simonovdenis @wildfly-ci @jamezp @bstansberry
You can’t perform that action at this time.