Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4129] WFLYSRV0266: Server home is set to... info msg in domain for RPM installation #3596

Merged
merged 1 commit into from Apr 14, 2019

Conversation

@gaol
Copy link
Contributor

gaol commented Nov 15, 2018

Jira: https://issues.jboss.org/browse/WFCORE-4129

This reduces the side effect in Linux where the symbolic link is used

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Nov 15, 2018

Core - Full Integration Build 8162 outcome was FAILURE using a merge of 85ed21b
Summary: Tests failed: 1 (1 new), passed: 4742, ignored: 132 Build time: 02:00:23

Failed tests

org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase.noFailover: java.lang.AssertionError: expected:<200> but was:<500>
	at org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase.queryCount(StatefulFailoverTestCase.java:315)
	at org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase.noFailover(StatefulFailoverTestCase.java:117)
------- Stdout: -------
 [0m03:05:17,488 INFO  [org.jboss.as.repository] (management-handler-thread - 2) WFLYDR0001: Content added at location /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/clustering/target/wildfly-1/standalone/data/content/64/26b3b4a583280c6c8b96b9772bbc8637a41b3b/content
 [0m [0m03:05:17,492 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-8) WFLYSRV0027: Starting deployment of "StatefulFailoverTestCase.war" (runtime-name: "StatefulFailoverTestCase.war")
 [0m [0m03:05:17,543 INFO  [org.jboss.as.jpa] (MSC service thread 1-4) WFLYJPA0002: Read persistence.xml for test
 [0m [0m03:05:17,561 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 38) WFLYJPA0010: Starting Persistence Unit (phase 1 of 2) Service 'StatefulFailoverTestCase.war#test'
 [0m [0m03:05:17,561 INFO  [org.hibernate.jpa.internal.util.LogHelper] (ServerService Thread Pool -- 38) HHH000204: Processing PersistenceUnitInfo [
	name: test
	...]
 [0m [0m03:05:17,575 INFO  [org.jboss.weld.deployer] (MSC service thread 1-8) WFLYWELD0003: Processing weld deployment StatefulFailoverTestCase.war
 [0m [0m03:05:17,597 INFO  [org.jboss.as.ejb3.deployment] (MSC service thread 1-8) WFLYEJB0473: JNDI bindings for session bean named 'TimeoutIncrementorBean' in deployment unit 'deployment "StatefulFailoverTestCase.war"' are as follows:

	java:global/StatefulFailoverTestCase/TimeoutIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:app/StatefulFailoverTestCase/TimeoutIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:module/TimeoutIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	ejb:StatefulFailoverTestCase/TimeoutIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor?stateful
	java:global/StatefulFailoverTestCase/TimeoutIncrementorBean
	java:app/StatefulFailoverTestCase/TimeoutIncrementorBean
	java:module/TimeoutIncrementorBean

 [0m [0m03:05:17,597 INFO  [org.jboss.as.ejb3.deployment] (MSC service thread 1-8) WFLYEJB0473: JNDI bindings for session bean named 'SimpleIncrementorBean' in deployment unit 'deployment "StatefulFailoverTestCase.war"' are as follows:

	java:global/StatefulFailoverTestCase/SimpleIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:app/StatefulFailoverTestCase/SimpleIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:module/SimpleIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	ejb:StatefulFailoverTestCase/SimpleIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor?stateful
	java:global/StatefulFailoverTestCase/SimpleIncrementorBean
	java:app/StatefulFailoverTestCase/SimpleIncrementorBean
	java:module/SimpleIncrementorBean

 [0m [0m03:05:17,597 INFO  [org.jboss.as.ejb3.deployment] (MSC service thread 1-8) WFLYEJB0473: JNDI bindings for session bean named 'JDBCResourceManagerConnectionFactoryIncrementorBean' in deployment unit 'deployment "StatefulFailoverTestCase.war"' are as follows:

	java:global/StatefulFailoverTestCase/JDBCResourceManagerConnectionFactoryIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:app/StatefulFailoverTestCase/JDBCResourceManagerConnectionFactoryIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:module/JDBCResourceManagerConnectionFactoryIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	ejb:StatefulFailoverTestCase/JDBCResourceManagerConnectionFactoryIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor?stateful
	java:global/StatefulFailoverTestCase/JDBCResourceManagerConnectionFactoryIncrementorBean
	java:app/StatefulFailoverTestCase/JDBCResourceManagerConnectionFactoryIncrementorBean
	java:module/JDBCResourceManagerConnectionFactoryIncrementorBean

 [0m [0m03:05:17,597 INFO  [org.jboss.as.ejb3.deployment] (MSC service thread 1-8) WFLYEJB0473: JNDI bindings for session bean named 'TimerIncrementorBean' in deployment unit 'deployment "StatefulFailoverTestCase.war"' are as follows:

	java:global/StatefulFailoverTestCase/TimerIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:app/StatefulFailoverTestCase/TimerIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	java:module/TimerIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor
	ejb:StatefulFailoverTestCase/TimerIncrementorBean!org.jboss.as.test.clustering.cluster.ejb.stateful.bean.Incrementor?stateful
	java:global/StatefulFailoverTestCase/TimerIncrementorBean
	java:app/StatefulFailoverTestCase/TimerIncrementorBean
	java:module/TimerIncrementorBean


resolvedHome = resolvedHome.getParent();
}
}
ServerLogger.ROOT_LOGGER.serverHomeMismatch(homeDir.toPath(), resolvedHome);

This comment has been minimized.

Copy link
@bstansberry

bstansberry Jan 19, 2019

Contributor

If the idea is the user reading this might be confused by the extra levels when the real problem is higher up, I'd rather not add code for helping with that. Also, this results in a different meaning for server home vs the standalone case, so that's also confusing.

This comment has been minimized.

Copy link
@gaol

gaol Feb 18, 2019

Author Contributor

Sorry for the late reply, I was on Chinese new year holidays and PTOs, :)

Yeah, I agree that it is also confusing somehow.

Now the original enhancement issue for the helping(warning in case of c:\ vs C:\ in Windows) has been rejected, because capital letter in Windows should be supported. So I think the original code for the helping should be removed as well, which means to revert the PR: #2346, what do you think?

This comment has been minimized.

Copy link
@bstansberry

bstansberry Feb 21, 2019

Contributor

+1 to removing this.

Please don't just revert the original commit though, because the logger method should remain in the file. It should be commented out though if it is no longer used. Leaving it but commented helps document the message ID sequence.

…n for RPM installation
@gaol gaol force-pushed the gaol:WFCORE-4129_ignore_symbolic branch from 85ed21b to ae095a0 Feb 21, 2019
@gaol

This comment has been minimized.

Copy link
Contributor Author

gaol commented Feb 22, 2019

@bstansberry I have updated the PR to remove the original codes that caused the side effect, the 2 CI errors are non-relevant. :)

@bstansberry bstansberry merged commit f5e8e38 into wildfly:master Apr 14, 2019
6 of 7 checks passed
6 of 7 checks passed
Windows - JDK 11 (Pull Request) - merge TeamCity build failed
Details
Full integration - Linux Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4818, ignored: 133
Details
Full integration - Windows Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4811, ignored: 138
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux - Security Manager - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.