Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFCORE-4129] WFLYSRV0266: Server home is set to... info msg in domain for RPM installation #3596
Conversation
This comment has been minimized.
This comment has been minimized.
wildfly-ci
commented
Nov 15, 2018
|
Core - Full Integration Build 8162 outcome was FAILURE using a merge of 85ed21b Failed tests
|
| resolvedHome = resolvedHome.getParent(); | ||
| } | ||
| } | ||
| ServerLogger.ROOT_LOGGER.serverHomeMismatch(homeDir.toPath(), resolvedHome); |
This comment has been minimized.
This comment has been minimized.
bstansberry
Jan 19, 2019
Contributor
If the idea is the user reading this might be confused by the extra levels when the real problem is higher up, I'd rather not add code for helping with that. Also, this results in a different meaning for server home vs the standalone case, so that's also confusing.
This comment has been minimized.
This comment has been minimized.
gaol
Feb 18, 2019
Author
Contributor
Sorry for the late reply, I was on Chinese new year holidays and PTOs, :)
Yeah, I agree that it is also confusing somehow.
Now the original enhancement issue for the helping(warning in case of c:\ vs C:\ in Windows) has been rejected, because capital letter in Windows should be supported. So I think the original code for the helping should be removed as well, which means to revert the PR: #2346, what do you think?
This comment has been minimized.
This comment has been minimized.
bstansberry
Feb 21, 2019
Contributor
+1 to removing this.
Please don't just revert the original commit though, because the logger method should remain in the file. It should be commented out though if it is no longer used. Leaving it but commented helps document the message ID sequence.
…n for RPM installation
This comment has been minimized.
This comment has been minimized.
|
@bstansberry I have updated the PR to remove the original codes that caused the side effect, the 2 CI errors are non-relevant. :) |
f5e8e38
into
wildfly:master
gaol commentedNov 15, 2018
Jira: https://issues.jboss.org/browse/WFCORE-4129
This reduces the side effect in Linux where the symbolic link is used