Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFCORE-4376 Fix deprecation warnings resulting from the improper deprecation of AbstractCapability. #3653
Conversation
This comment has been minimized.
This comment has been minimized.
wildfly-ci
commented
Jan 23, 2019
|
Core - Full Integration Build 8303 outcome was FAILURE using a merge of cc8444a Failed tests
|
This comment has been minimized.
This comment has been minimized.
|
@pferraro patch looks good to me. Could you please open a WFCORE issue so we can track this change? |
This comment has been minimized.
This comment has been minimized.
|
@jmesnil No problem. Will fix today. |
…ecation of AbstractCapability.
a1b54c8
into
wildfly:master
7 checks passed
7 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4824, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4817, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pferraro commentedJan 23, 2019
•
edited
https://issues.jboss.org/browse/WFCORE-4376
AbstractCapability was deprecated a little over a year ago. However, because RuntimeCapability inherits most of its Capability method implementations from it, users of RuntimeCapability encounter lots of inappropriate deprecation warnings when referencing many of the non-deprecated methods from the Capability interface. This PR fixes that and any compilation errors resulting from the invocation of these methods from a raw-typed RuntimeCapability.