Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-4376 Fix deprecation warnings resulting from the improper deprecation of AbstractCapability. #3653

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@pferraro
Copy link
Contributor

pferraro commented Jan 23, 2019

https://issues.jboss.org/browse/WFCORE-4376

AbstractCapability was deprecated a little over a year ago. However, because RuntimeCapability inherits most of its Capability method implementations from it, users of RuntimeCapability encounter lots of inappropriate deprecation warnings when referencing many of the non-deprecated methods from the Capability interface. This PR fixes that and any compilation errors resulting from the invocation of these methods from a raw-typed RuntimeCapability.

@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Jan 23, 2019

Core - Full Integration Build 8303 outcome was FAILURE using a merge of cc8444a
Summary: Tests failed: 1 (1 new), passed: 4782, ignored: 132 Build time: 02:24:18

Failed tests

org.jboss.as.test.integration.domain.OrderedChildResourcesTestCase.testOrderedChildResources: java.lang.AssertionError: expected:<{
    "statistics-enabled" => false,
    "protocol" => {
        "MPING" => undefined,
        "MERGE3" => undefined,
        "FD_SOCK" => undefined,
        "FD_ALL" => undefined,
        "VERIFY_SUSPECT" => undefined,
        "pbcast.NAKACK2" => undefined,
        "UNICAST3" => undefined,
        "pbcast.STABLE" => undefined,
        "pbcast.GMS" => undefined,
        "MFC" => undefined,
        "FRAG3" => undefined
    },
    "relay" => undefined,
    "transport" => {
        "TCP" => undefined,
        "TRANSPORT" => undefined
    }
}> but was:<{
    "statistics-enabled" => false,
    "protocol" => {
        "MPING" => undefined,
        "MERGE3" => undefined,
        "FD_SOCK" => undefined,
        "VERIFY_SUSPECT" => undefined,
        "pbcast.NAKACK2" => undefined,
        "UNICAST3" => undefined,
        "pbcast.STABLE" => undefined,
        "pbcast.GMS" => undefined,
        "MFC" => undefined,
        "FRAG3" => undefined
    },
    "relay" => undefined,
    "transport" => {
        "TCP" => undefined,
        "TRANSPORT" => undefined
    }
}>
java.lang.AssertionError: 
expected:<{
    "statistics-enabled" => false,
    "protocol" => {
        "MPING" => undefined,
        "MERGE3" => undefined,
        "FD_SOCK" => undefined,
        "FD_ALL" => undefined,
        "VERIFY_SUSPECT" => undefined,
        "pbcast.NAKACK2" => undefined,
        "UNICAST3" => undefined,


@jmesnil

This comment has been minimized.

Copy link
Member

jmesnil commented Mar 19, 2019

@pferraro patch looks good to me. Could you please open a WFCORE issue so we can track this change?

@pferraro

This comment has been minimized.

Copy link
Contributor Author

pferraro commented Mar 19, 2019

@jmesnil No problem. Will fix today.

…ecation of AbstractCapability.
@pferraro pferraro force-pushed the pferraro:master branch from cc8444a to a0e992e Mar 19, 2019
@pferraro pferraro changed the title Fix deprecation warnings resulting from the improper deprecation of AbstractCapability. WFCORE-4376 Fix deprecation warnings resulting from the improper deprecation of AbstractCapability. Mar 19, 2019
@jmesnil
jmesnil approved these changes Apr 3, 2019
@jmesnil jmesnil merged commit a1b54c8 into wildfly:master Apr 5, 2019
7 checks passed
7 checks passed
Full integration - Linux Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4824, ignored: 134
Details
Full integration - Windows Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4817, ignored: 139
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux - Security Manager - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.