Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFCORE-4325] Unable to run testsuite/domain tests with -Delytron #3670
Conversation
This comment has been minimized.
This comment has been minimized.
|
@jmesnil, WDYT please? |
This comment has been minimized.
This comment has been minimized.
|
What does this change actually do to the testsuite? |
|
The fix for this should be splitting testsuite/shared/enable-elytron.cli into separate scripts for standalone and domain and only executing the appropriate script in the different testsuites. I believe the host-controller part of enable-elytron.cli could just be removed from that file and put into a script in testsuite/domain. The other suites use the standalone part. |
|
It would be nice to have the embed-host-controller stuff removed from testsuite/shared/enable-elytron.cli but I think it's reasonable to regard that as out of scope for this task. Core's testsuite/shared is kind of messy as it's a mix of stuff shared across testsuite modules within core and then other stuff that's used in full as well. |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry Thank you. I'd like to stay with the limited scope for this task. |
208356d
into
wildfly:master
OndrejKotek commentedFeb 12, 2019
•
edited
https://issues.jboss.org/browse/WFCORE-4325