Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4325] Unable to run testsuite/domain tests with -Delytron #3670

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@OndrejKotek
Copy link
Contributor

OndrejKotek commented Feb 12, 2019

@OndrejKotek OndrejKotek force-pushed the OndrejKotek:WFCORE-4325 branch from 0e57b33 to b496b53 Mar 22, 2019
@OndrejKotek

This comment has been minimized.

Copy link
Contributor Author

OndrejKotek commented Mar 22, 2019

@jmesnil, WDYT please?

@darranl

This comment has been minimized.

Copy link
Contributor

darranl commented Apr 3, 2019

What does this change actually do to the testsuite?

Copy link
Contributor

bstansberry left a comment

The fix for this should be splitting testsuite/shared/enable-elytron.cli into separate scripts for standalone and domain and only executing the appropriate script in the different testsuites.

I believe the host-controller part of enable-elytron.cli could just be removed from that file and put into a script in testsuite/domain. The other suites use the standalone part.

@OndrejKotek OndrejKotek force-pushed the OndrejKotek:WFCORE-4325 branch from b496b53 to 674a7bf Apr 8, 2019
Copy link
Contributor

bstansberry left a comment

It would be nice to have the embed-host-controller stuff removed from testsuite/shared/enable-elytron.cli but I think it's reasonable to regard that as out of scope for this task.

Core's testsuite/shared is kind of messy as it's a mix of stuff shared across testsuite modules within core and then other stuff that's used in full as well.

@OndrejKotek

This comment has been minimized.

Copy link
Contributor Author

OndrejKotek commented Apr 9, 2019

@bstansberry Thank you. I'd like to stay with the limited scope for this task.

@darranl darranl merged commit 208356d into wildfly:master Apr 10, 2019
7 checks passed
7 checks passed
Full integration - Linux Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4851, ignored: 134
Details
Full integration - Windows Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4844, ignored: 139
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux - Security Manager - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.