Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4359] Ensure the CLI embedded stdio and log contexts are used for CLI loggers. #3698

Merged
merged 2 commits into from Apr 5, 2019

Conversation

@jamezp
Copy link
Member

jamezp commented Mar 5, 2019

WFCORE-4358

This commit just upgrades the log manager with a single commit to expose the LogContext.getLogContextSelector() which is required for the second commit.

WFCORE-4358

This commit fixes the issue where the incorrect log context could be used when creating CLI loggers and the incorrect StdioContext being used when CLI writes log messages.

Instead of just wrapping the current LogContext this wraps the CLI ThreadLocalContextSelector instead to ensure the correct contexts are used. I tested both the embed-server and embed-host-controller with the jboss-cli.sh script and the jboss-cli-client.jar. Log messages from CLI will now use the jboss-cli-logging.properties configuration (assuming that's used) and log messages from the server us the correct contexts from the server itself.

@jfdenise Could you please have a look and approve this?

jamezp added 2 commits Mar 5, 2019
… for CLI loggers. This ensures all CLI loggers write to the log manager configured for CLI and embedded server loggers write to the server configured loggers.
@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Mar 5, 2019

Core - Full Integration Build 8395 outcome was FAILURE using a merge of 50b983f
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:02:54

@jamezp

This comment has been minimized.

Copy link
Member Author

jamezp commented Mar 5, 2019

Note the ModuleInfoTestCase.testModuleInfo consistently fail when a log manager upgrade is done. It's due to the dependency not being found in the repository cache. It can be manually done or the tests can be run the next day after the cache is replicated.

@jmesnil
jmesnil approved these changes Apr 3, 2019
@jmesnil jmesnil merged commit 910b47b into wildfly:master Apr 5, 2019
6 of 7 checks passed
6 of 7 checks passed
Windows - JDK 11 (Pull Request) - merge TeamCity build failed
Details
Full integration - Linux Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4825, ignored: 133
Details
Full integration - Windows Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4818, ignored: 138
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux - Security Manager - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 8 (Pull Request) - merge TeamCity build finished
Details
@jamezp jamezp deleted the jamezp:WFCORE-4359 branch Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.