Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFCORE-4359] Ensure the CLI embedded stdio and log contexts are used for CLI loggers. #3698
Conversation
This comment has been minimized.
This comment has been minimized.
wildfly-ci
commented
Mar 5, 2019
|
Core - Full Integration Build 8395 outcome was FAILURE using a merge of 50b983f |
This comment has been minimized.
This comment has been minimized.
|
Note the |
910b47b
into
wildfly:master
6 of 7 checks passed
6 of 7 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4825, ignored: 133
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4818, ignored: 138
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jamezp commentedMar 5, 2019
WFCORE-4358
This commit just upgrades the log manager with a single commit to expose the
LogContext.getLogContextSelector()which is required for the second commit.WFCORE-4358
This commit fixes the issue where the incorrect log context could be used when creating CLI loggers and the incorrect
StdioContextbeing used when CLI writes log messages.Instead of just wrapping the current
LogContextthis wraps the CLIThreadLocalContextSelectorinstead to ensure the correct contexts are used. I tested both theembed-serverandembed-host-controllerwith thejboss-cli.shscript and thejboss-cli-client.jar. Log messages from CLI will now use thejboss-cli-logging.propertiesconfiguration (assuming that's used) and log messages from the server us the correct contexts from the server itself.@jfdenise Could you please have a look and approve this?