Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFCORE-3891: ensure unique names for default formatters #3713
Conversation
.../org/jboss/as/logging/formatters/PatternFormatterResourceDefinition.java
Outdated
Show resolved
Hide resolved
...ing/src/main/java/org/jboss/as/logging/formatters/StructuredFormatterResourceDefinition.java
Outdated
| @@ -369,6 +369,9 @@ public void performRuntime(final OperationContext context, final ModelNode opera | |||
| } | |||
|
|
|||
| final String name = context.getCurrentAddressValue(); | |||
| if (name.endsWith(PatternFormatterResourceDefinition.DEFAULT_FORMATTER_SUFFIX)) { | |||
| throw new IllegalArgumentException("Formatter name cannot end with '" + PatternFormatterResourceDefinition.DEFAULT_FORMATTER_SUFFIX + "'"); | |||
This comment has been minimized.
This comment has been minimized.
jamezp
Apr 1, 2019
Member
This needs to be internationalized and I think an OperationFailedException would be a better one to throw.
logging/src/main/java/org/jboss/as/logging/handlers/HandlerOperations.java
Outdated
Show resolved
Hide resolved
jmesnil
merged commit aadd115
into
wildfly:master
8 checks passed
8 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michpetrov commentedMar 27, 2019
Issue: WFCORE-3891