Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFCORE-4392] Migrating CapabilityServiceTarget to new MSC API #3719
Conversation
This comment has been minimized.
This comment has been minimized.
|
Please review @bstansberry it is related to your comment wildfly/wildfly#12120 (comment) |
This comment has been minimized.
This comment has been minimized.
|
@jmesnil fyi. What this is doing is what I was thinking when I filed the JIRA. @ropalka Can you add a bit of method javadoc to CapabilityServiceTarget? Also its methods declaring they throw IAE is odd. The reason for that is RuntimeCapability.getCapabilityServiceName will throw that, but it's better to explain that in javadoc via @throws IAE the way RuntimeCapability does, rather than having the IAE in the method signature. |
This was referenced Apr 8, 2019
darranl
merged commit 6796bfd
into
wildfly:master
7 checks passed
7 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4839, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4832, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ropalka commentedMar 27, 2019
https://issues.jboss.org/browse/WFCORE-4392