WFCORE-4399 ResourceEntry implementations to not implement equals/hashCode()

[pferraro]

https://issues.jboss.org/browse/WFCORE-4399

[jmesnil]

why are you not taking extensionRegistry into account?

[pferraro]

Because the path element (specifically the moduleName, as all extensions will have use same path key) of an extension's ResourceEntry is sufficient to identify uniqueness.

[jmesnil]

Shouldn't the hashCode take into account the delegate's hashCode()?

It seems to me that 2 instances of DelegateResource with the same path element but different delegate should not be considered identical.

[pferraro]

Don't confuse the hashCode/equals implementation of a ResourceEntry with that of a Resource. A ResourceEntry is a Resource located at a specific path.
A Set should never contain multiple Resource implementations with the same path. Otherwise, the semantics of Resource.getChildren(...) would be ambiguous.

It seems to me that 2 instances of DelegateResource with the same path element but different delegate should not be considered identical.

Please refer back to the premise of the jira. If I have a hash-based Set containing the ResourceEntry's of a given child type (e.g. the result of Resource.getChildren(String childType), and I want to replace one of the entries with a different Resource implementation (typically by decorating the one that exists for a given path), I cannot do this unless the PathElement of the ResourceEntry is what identifies it in the set.