Fix for WFCORE-4402, Upgrade CLI to use aesh 2.3 #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
approved these changes
Apr 8, 2019
jmesnil
added
the
ready-for-merge
|
@jmesnil , I realize that Wildfly has its own version of jansi, I also need to upgrade this dependency. |
|
@darranl , please wait before to merge this one, it is incomplete. |
darranl
removed
the
ready-for-merge
darranl
requested changes
Apr 8, 2019
darranl
approved these changes
Apr 9, 2019
darranl
added
the
ready-for-merge
wildfly-ci
added
the
deps-ok
|
@jfdenise The Linux JDK8 job appears a couple of times now to have a number of identity operation failures and a hang, as this PR is in relation to UI component upgrades that are likely involved in these test scenarios are you able to take a look? |
darranl
removed
the
ready-for-merge
|
@darranl , I don't see evidence of usage of aesh/jansi in these tests, where do you see these UI components in use in these tests? |
|
Another PR has the same errors so looks like not related to this component upgrade #3736 |
darranl
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: https://issues.jboss.org/browse/WFCORE-4402 and https://issues.jboss.org/browse/WFCORE-4408