Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for WFCORE-4402, Upgrade CLI to use aesh 2.3 #3725
Conversation
This comment has been minimized.
This comment has been minimized.
|
@jmesnil , I realize that Wildfly has its own version of jansi, I also need to upgrade this dependency. |
This comment has been minimized.
This comment has been minimized.
|
@darranl , please wait before to merge this one, it is incomplete. |
|
Add missing dependencies. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@jfdenise The Linux JDK8 job appears a couple of times now to have a number of identity operation failures and a hang, as this PR is in relation to UI component upgrades that are likely involved in these test scenarios are you able to take a look? |
This comment has been minimized.
This comment has been minimized.
|
@darranl , I don't see evidence of usage of aesh/jansi in these tests, where do you see these UI components in use in these tests? |
This comment has been minimized.
This comment has been minimized.
|
Another PR has the same errors so looks like not related to this component upgrade #3736 |
bstansberry
merged commit ca8613e
into
wildfly:master
jfdenise commentedApr 5, 2019
•
edited
Fix for: https://issues.jboss.org/browse/WFCORE-4402 and https://issues.jboss.org/browse/WFCORE-4408