Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-4413] Fixing javax.api and javax.sql.api modules BC issues #3736

Merged
merged 1 commit into from Apr 14, 2019

Conversation

@ropalka
Copy link
Contributor

ropalka commented Apr 10, 2019

@ropalka

This comment has been minimized.

Copy link
Contributor Author

ropalka commented Apr 10, 2019

I analyzed modules before and after the changes and I identified just two backward compatibility issues.
Who's volunteering to review this PR @bstansberry @jmesnil @darranl @kabir @jamezp ?

@darranl

This comment has been minimized.

Copy link
Contributor

darranl commented Apr 10, 2019

Looks like the failures and hang are the same as in #3725 so maybe not related to that component upgrade after all.

@darranl

This comment has been minimized.

Copy link
Contributor

darranl commented Apr 10, 2019

Aren't some of these modules supposed to be automatically generated in jboss-modules now or are these two not a part of that?

@ropalka

This comment has been minimized.

Copy link
Contributor Author

ropalka commented Apr 10, 2019

There was implemented an ability to define dependencies on Jigsaw aka JPMS (Java Platform Module System) modules in module.xml (JBoss module descriptors). If there's a module referenced in module.xml that has no module.xml definition it is considered to be JPMS module and JBoss Modules implementation delegates to PlatformModuleLoader for not-found modules.
Also note that JPMS system is emulated on top of JDK8.

To answer your question neither javax.api nor javax.sql.api represent a JPMS module.
That is also the reason why these modules have been deprecated.
It is necessary to include missing module dependencies there explicitly @darranl .

@kabir kabir added deps-ok and removed deps-ok labels Apr 11, 2019
@wildfly-ci wildfly-ci added the deps-ok label Apr 11, 2019
@bstansberry bstansberry merged commit 551be72 into wildfly:master Apr 14, 2019
8 checks passed
8 checks passed
Dependency Tree (Pull Request) - merge TeamCity build finished
Details
Full integration - Linux Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Full integration - Windows Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux - Security Manager - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Windows - JDK 8 (Pull Request) - merge TeamCity build finished
Details
@ropalka ropalka deleted the ropalka:WFCORE-4413 branch Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.