Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFCORE-3298: do not try to modify protected nodes #3737
Merged
Conversation
| @@ -220,7 +220,7 @@ public EnumValidator(final Class<E> enumType, final boolean nullable, final boo | |||
| public void validateParameter(String parameterName, ModelNode value) throws OperationFailedException { | |||
| super.validateParameter(parameterName, value); | |||
| ModelType type = value.getType(); | |||
| if (type == ModelType.STRING ) { | |||
| if (type == ModelType.STRING && !value.isProtected()) { | |||
This comment has been minimized.
This comment has been minimized.
bstansberry
Apr 14, 2019
Contributor
This if (!value.isProtected()) can only guard the 'value.set(enumValue.toString());' call. Having it here disables the validation. The value being protected doesn't mean it doesn't need validation.
This comment has been minimized.
This comment has been minimized.
|
retest this please |
jmesnil
merged commit d210280
into
wildfly:master
8 checks passed
8 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4863, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4856, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michpetrov commentedApr 10, 2019
Issue: WFCORE-3298