Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for WFCORE-4406 and Upgrade to Galleon 4.0.0.alpha #3751
Conversation
…r WFCORE-4406, Core Galleon feature-pack pom.xml should define deps as provided
jfdenise
changed the title
This comment has been minimized.
This comment has been minimized.
|
@psakar @bstansberry FYI this is not labelled with deps-changed as it does not go into the feature packs |
| <version.org.wildfly.build-tools>1.2.10.Final</version.org.wildfly.build-tools> | ||
| <version.org.wildfly.checkstyle-config>1.0.5.Final</version.org.wildfly.checkstyle-config> | ||
| <version.org.wildfly.galleon-plugins>3.0.1.Final</version.org.wildfly.galleon-plugins> | ||
| <version.org.wildfly.galleon-plugins>4.0.0.Alpha4</version.org.wildfly.galleon-plugins> |
This comment has been minimized.
This comment has been minimized.
jmesnil
Apr 26, 2019
Member
Was it a coincidence that both org.jboss.galleon & org.wildfly.galleon-plugins were at 3.0.1.Final before?
Is there any relation between the 2 versions?
This comment has been minimized.
This comment has been minimized.
jfdenise
Apr 29, 2019
Author
Contributor
@jmesnil , the difference in version is due to some issues found in galleon-plugins. The 2 galleon deps will be 4.0.Final
This comment has been minimized.
This comment has been minimized.
|
@jmesnil , I think that it should be ok, @aloubyansky we have 2 weeks before the final release, is it fine with you? |
This comment has been minimized.
This comment has been minimized.
|
Yes, we'll have the final release by that date. |
jmesnil
merged commit 0b445fb
into
wildfly:master
8 checks passed
8 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4857, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4850, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jfdenise commentedApr 18, 2019
F- ix for https://issues.jboss.org/browse/WFCORE-4406