Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFCORE-4442] Migrating UndertowHttpManagementService & HttpShutdownService to new MSC API #3755
Conversation
...rc/main/java/org/jboss/as/server/mgmt/UndertowHttpManagementService.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/jboss/as/server/mgmt/UndertowHttpManagementService.java
Outdated
Show resolved
Hide resolved
…ervice to use new MSC service builder API.
This comment has been minimized.
This comment has been minimized.
|
@jmesnil This LGTM. |
jmesnil
merged commit 8002d76
into
wildfly:master
8 checks passed
8 checks passed
Full integration - Linux
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration Linux - JDK 8 : Tests passed: 4863, ignored: 134
Details
Full integration - Windows
Finished TeamCity Build WildFly Core / Pull Request / WildFly Core Full - Integration - Windows - JDK 8 : Tests passed: 4856, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ropalka commentedApr 25, 2019
https://issues.jboss.org/browse/WFCORE-4442