[WFCORE-4750] Using regex for role in Elytron #4017

Skyllarr · 2019-11-19T14:35:09Z

Requires ELY-1909

wildfly-ci · 2019-11-19T14:37:14Z

Core - Full Integration Build 9180 outcome was FAILURE using a merge of 7799670
Summary: Compilation error: Compiler (new) Build time: 00:01:45

wildfly-ci · 2019-11-19T14:37:21Z

Core - Full Integration Build 9180 outcome was FAILURE using a merge of 7799670
Summary: Compilation error: Compiler (new) Build time: 00:01:52

wildfly-ci · 2019-11-26T13:35:36Z

Core - Full Integration Build 9215 outcome was UNKNOWN using a merge of 5810c59
Summary: Canceled (Error while applying patch; cannot find commit 2afc90c in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/4017/merge branch was updated and the commit selected for the ... Build time: 00:00:11

wildfly-ci · 2019-11-26T13:35:44Z

Core - Full Integration Build 9213 outcome was UNKNOWN using a merge of 5810c59
Summary: Canceled (Error while applying patch; cannot find commit 2afc90c in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/4017/merge branch was updated and the commit selected for the ... Build time: 00:00:17

wildfly-ci · 2019-11-26T13:50:29Z

Core - Full Integration Build 9214 outcome was FAILURE using a merge of c43be70
Summary: Compilation error: Compiler Build time: 00:01:14

wildfly-ci · 2019-11-26T13:50:52Z

Core - Full Integration Build 9216 outcome was FAILURE using a merge of c43be70
Summary: Compilation error: Compiler Build time: 00:01:37

fjuma · 2019-12-09T20:55:18Z

elytron/src/main/java/org/wildfly/extension/elytron/ElytronDescriptionConstants.java

@@ -427,7 +427,9 @@
    String REFERENCE = "reference";
    String REFERRAL_MODE = "referral-mode";
    String REGISTER_JASPI_FACTORY = "register-jaspi-factory";
+    String REGEX = "regex";


It might be good to use pattern as the attribute name instead of regex to be consistent with other resources that make use of a regular expression.

Fixed. Thanks

fjuma · 2019-12-09T21:01:05Z

elytron/src/main/java/org/wildfly/extension/elytron/RoleMapperDefinitions.java

@@ -80,6 +85,19 @@
        .setRestartAllServices()
        .build();

+    static final SimpleAttributeDefinition REGEX = new SimpleAttributeDefinitionBuilder(ElytronDescriptionConstants.REGEX, ModelType.STRING, false)


I think you can use SimpleAttributeDefinitionBuilder(RegexAttributeDefinitions.PATTERN) here instead and then remove the set calls below.

Fixed. Thank you

fjuma · 2019-12-09T21:12:10Z

elytron/src/test/java/org/wildfly/extension/elytron/RegexRoleMapperTestCase.java

@@ -0,0 +1,148 @@
+package org.wildfly.extension.elytron;


Missing copyright header.

fjuma · 2019-12-09T21:14:55Z

elytron/src/test/java/org/wildfly/extension/elytron/RegexRoleMapperTestCase.java

+    }
+
+    @Before
+    public void init() throws Exception {


Is this method actually needed?

wildfly-ci · 2019-12-12T14:21:10Z

Core - Full Integration Build 9241 outcome was FAILURE using a merge of 1016637
Summary: Compilation error: Compiler Build time: 00:01:56

wildfly-ci · 2019-12-12T14:21:13Z

Core - Full Integration Build 9243 outcome was FAILURE using a merge of 1016637
Summary: Compilation error: Compiler Build time: 00:01:59

wildfly-ci · 2019-12-13T13:26:18Z

Core - Full Integration Build 9245 outcome was FAILURE using a merge of 2507974
Summary: Compilation error: Compiler Build time: 00:00:54

wildfly-ci · 2019-12-13T13:26:38Z

Core - Full Integration Build 9247 outcome was FAILURE using a merge of 2507974
Summary: Compilation error: Compiler Build time: 00:01:14

wildfly-ci · 2019-12-13T14:28:07Z

Core - Full Integration Build 9246 outcome was FAILURE using a merge of 4ae64b7
Summary: Compilation error: Compiler Build time: 00:00:47

wildfly-ci · 2019-12-13T14:28:29Z

Core - Full Integration Build 9248 outcome was FAILURE using a merge of 4ae64b7
Summary: Compilation error: Compiler Build time: 00:01:09

fjuma · 2019-12-13T15:16:15Z

Thanks, @Skyllarr. This looks good, it just has some conflicts that need to be resolved.

wildfly-ci · 2020-01-21T22:28:39Z

Core - Full Integration Build 9323 outcome was FAILURE using a merge of c39741f
Summary: Compilation error: Compiler (new) Build time: 00:01:17

wildfly-ci · 2020-01-21T22:28:47Z

Core - Full Integration Build 9327 outcome was FAILURE using a merge of c39741f
Summary: Compilation error: Compiler (new) Build time: 00:01:25

wildfly-ci · 2020-01-22T11:32:24Z

Core - Full Integration Build 9329 outcome was FAILURE using a merge of 4002efe
Summary: Compilation error: Compiler Build time: 00:01:08

wildfly-ci · 2020-01-22T11:32:43Z

Core - Full Integration Build 9325 outcome was FAILURE using a merge of 4002efe
Summary: Compilation error: Compiler Build time: 00:01:27

wildfly-ci · 2020-01-22T12:53:58Z

Core - Full Integration Build 9326 outcome was FAILURE using a merge of 42f28b0
Summary: Compilation error: Compiler Build time: 00:00:43

wildfly-ci · 2020-01-22T12:54:16Z

Core - Full Integration Build 9330 outcome was FAILURE using a merge of 42f28b0
Summary: Compilation error: Compiler Build time: 00:01:00

wildfly-ci · 2020-01-22T15:45:33Z

Core - Full Integration Build 9328 outcome was FAILURE using a merge of 3efb194
Summary: Error while applying patch Build time: 00:00:04

wildfly-ci · 2020-01-22T15:45:48Z

Core - Full Integration Build 9332 outcome was UNKNOWN using a merge of 3efb194
Summary: Canceled (Error while applying patch; cannot find commit e7f5155 in the https://github.com/wildfly/wildfly-core.git repository, possible reason: refs/pull/4017/merge branch was updated and the commit selected for the ... Build time: 00:00:19

wildfly-ci · 2020-01-22T16:24:10Z

Core - Full Integration Build 9329 outcome was FAILURE using a merge of 19dca67
Summary: Compilation error: Compiler Build time: 00:00:50

wildfly-ci · 2020-01-22T16:24:24Z

Core - Full Integration Build 9333 outcome was FAILURE using a merge of 19dca67
Summary: Compilation error: Compiler Build time: 00:01:07

wildfly-ci · 2020-03-31T15:41:58Z

Core - Full Integration Build 9452 outcome was FAILURE using a merge of e197ab3
Summary: Compilation error: Compiler (new) Build time: 00:01:18

wildfly-ci · 2020-03-31T15:41:58Z

Core - Full Integration Build 9449 outcome was FAILURE using a merge of e197ab3
Summary: Compilation error: Compiler (new) Build time: 00:01:18

wildfly-ci · 2020-04-24T16:45:23Z

Core - Full Integration Build 9582 outcome was FAILURE using a merge of aa94054
Summary: Compilation error: Compiler Build time: 00:01:16

wildfly-ci · 2020-04-24T16:45:30Z

Core - Full Integration Build 9572 outcome was FAILURE using a merge of aa94054
Summary: Compilation error: Compiler Build time: 00:01:23

wildfly-ci · 2020-04-24T16:51:31Z

Core - Full Integration Build 9573 outcome was FAILURE using a merge of d80f246
Summary: Compilation error: Compiler Build time: 00:01:17

wildfly-ci · 2020-04-24T16:52:11Z

Core - Full Integration Build 9583 outcome was FAILURE using a merge of d80f246
Summary: Compilation error: Compiler Build time: 00:01:58

wildfly-ci · 2020-04-24T16:54:36Z

Core - Full Integration Build 9574 outcome was FAILURE using a merge of c0736ac
Summary: Compilation error: Compiler Build time: 00:01:23

wildfly-ci · 2020-04-24T16:55:06Z

Core - Full Integration Build 9584 outcome was FAILURE using a merge of c0736ac
Summary: Compilation error: Compiler Build time: 00:01:59

fabiobrz · 2020-05-08T15:53:45Z

elytron/src/test/java/org/wildfly/extension/elytron/RoleMappersTestCase.java

+
+        Roles roles = identity.getRoles();
+        Assert.assertTrue(roles.contains("admin"));
+        Assert.assertTrue(roles.contains("admin"));


Maybe duplicated line here? From test domain definition I ca see that user5 should have the following roles, resulting from AggregateRoleMapper1 processing:

1-user-1: match, translated into admin

joe: no match, not kept

2-guest-2: match, translated into guest

Hence looks like result should be {admin, guest}.
WDYT?

wildfly-ci · 2020-05-11T13:09:59Z

Core - Full Integration Build 9610 outcome was FAILURE using a merge of 35debf8
Summary: Compilation error: Compiler Build time: 00:00:47

wildfly-ci · 2020-05-11T13:10:35Z

Core - Full Integration Build 9631 outcome was FAILURE using a merge of 35debf8
Summary: Compilation error: Compiler Build time: 00:01:22

wildfly-ci · 2020-05-15T16:42:53Z

Core - Full Integration Build 9636 outcome was FAILURE using a merge of a81d981
Summary: Compilation error: Compiler Build time: 00:00:54

wildfly-ci · 2020-05-15T16:44:26Z

Core - Full Integration Build 9659 outcome was FAILURE using a merge of a81d981
Summary: Compilation error: Compiler Build time: 00:02:27

darranl added Feature This PR adds a new feature to WildFly missing-reqs This PR is missing external requirements before it can be merged labels Nov 20, 2019

Skyllarr force-pushed the WFCORE-4750 branch from 7799670 to 5810c59 Compare November 26, 2019 13:33

Skyllarr force-pushed the WFCORE-4750 branch from 5810c59 to c43be70 Compare November 26, 2019 13:48

fjuma requested changes Dec 9, 2019

View reviewed changes

Skyllarr force-pushed the WFCORE-4750 branch from c43be70 to 1016637 Compare December 12, 2019 14:17

Skyllarr force-pushed the WFCORE-4750 branch from 1016637 to 2507974 Compare December 13, 2019 13:23

Skyllarr force-pushed the WFCORE-4750 branch from 2507974 to 4ae64b7 Compare December 13, 2019 14:26

Skyllarr force-pushed the WFCORE-4750 branch from 4ae64b7 to c39741f Compare January 21, 2020 22:26

Skyllarr force-pushed the WFCORE-4750 branch from c39741f to 4002efe Compare January 22, 2020 11:29

Skyllarr force-pushed the WFCORE-4750 branch from 4002efe to 42f28b0 Compare January 22, 2020 12:52

Skyllarr force-pushed the WFCORE-4750 branch from 3efb194 to 19dca67 Compare January 22, 2020 16:21

Skyllarr force-pushed the WFCORE-4750 branch from 19dca67 to e197ab3 Compare March 31, 2020 15:39

Skyllarr force-pushed the WFCORE-4750 branch from e197ab3 to aa94054 Compare April 24, 2020 16:43

Skyllarr force-pushed the WFCORE-4750 branch from aa94054 to d80f246 Compare April 24, 2020 16:49

Skyllarr force-pushed the WFCORE-4750 branch from d80f246 to c0736ac Compare April 24, 2020 16:52

fabiobrz reviewed May 8, 2020

View reviewed changes

Skyllarr force-pushed the WFCORE-4750 branch from c0736ac to 35debf8 Compare May 11, 2020 13:05

darranl removed the missing-reqs This PR is missing external requirements before it can be merged label May 15, 2020

[WFCORE-4750] Using regex for role in Elytron

a81d981

Skyllarr force-pushed the WFCORE-4750 branch from 35debf8 to a81d981 Compare May 15, 2020 16:39

darranl mentioned this pull request May 15, 2020

[WFCORE-4750] Using regex for role in Elytron #4206

Merged

bstansberry merged commit 1a4c905 into wildfly:master May 17, 2020

[WFCORE-4750] Using regex for role in Elytron #4017

[WFCORE-4750] Using regex for role in Elytron #4017

Conversation

Skyllarr commented Nov 19, 2019

wildfly-ci commented Nov 19, 2019

wildfly-ci commented Nov 19, 2019

wildfly-ci commented Nov 26, 2019

wildfly-ci commented Nov 26, 2019

wildfly-ci commented Nov 26, 2019

wildfly-ci commented Nov 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented Dec 12, 2019

wildfly-ci commented Dec 12, 2019

wildfly-ci commented Dec 13, 2019

wildfly-ci commented Dec 13, 2019

wildfly-ci commented Dec 13, 2019

wildfly-ci commented Dec 13, 2019

fjuma commented Dec 13, 2019

wildfly-ci commented Jan 21, 2020

wildfly-ci commented Jan 21, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Jan 22, 2020

wildfly-ci commented Mar 31, 2020

wildfly-ci commented Mar 31, 2020

wildfly-ci commented Apr 24, 2020

wildfly-ci commented Apr 24, 2020

wildfly-ci commented Apr 24, 2020

wildfly-ci commented Apr 24, 2020

wildfly-ci commented Apr 24, 2020

wildfly-ci commented Apr 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wildfly-ci commented May 11, 2020

wildfly-ci commented May 11, 2020

wildfly-ci commented May 15, 2020

wildfly-ci commented May 15, 2020