Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFCORE-6221 Add formal experimental/preview mode to management model #5413

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

pferraro
Copy link
Contributor

@pferraro pferraro commented Mar 20, 2023

https://issues.redhat.com/browse/WFCORE-6221

This pull request formalizes the concept of a quality level in the WildFly kernel based on the general strategy described in WFCORE-6221.
In general, a subsystem associate features within its management model with a specific Quality. During management registration, only those features enabled by the quality level of the server will be registered.

See the test case here for an example of how I imagined this might work: https://github.com/pferraro/wildfly-core/tree/WFCORE-6221/subsystem-test/tests/src/test/java/org/jboss/as/subsystem/test/quality

Please scrutinize. Tell me what you like and do not like.

@github-actions github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Mar 20, 2023
@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments. Overall though I think this looks good.

@wildfly-ci

This comment was marked as outdated.

@pferraro pferraro force-pushed the WFCORE-6221 branch 4 times, most recently from 5ab65b2 to 3649807 Compare March 31, 2023 19:24
@bstansberry bstansberry added the Feature This PR adds a new feature to WildFly label Apr 12, 2023
@pferraro pferraro changed the title WFCORE-6221 Add formal experimental mode to management model WFCORE-6221 Add formal experimental/preview mode to management model Apr 18, 2023
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pferraro, I did another review. Regarding domain mode, we also need to reject registrations of host controllers that are not running at the same FeatureStream level as the domain controller.

I think Zulip could be better to discuss this, so I'll add the comments there

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@pferraro pferraro force-pushed the WFCORE-6221 branch 2 times, most recently from 8dc3916 to 4591954 Compare October 27, 2023 15:38
@wildfly wildfly deleted a comment from wildfly-ci Oct 27, 2023
@wildfly wildfly deleted a comment from wildfly-ci Oct 27, 2023
@wildfly wildfly deleted a comment from wildfly-ci Oct 27, 2023
@wildfly-ci
Copy link

Core -> Full Integration Build 13184 outcome was FAILURE using a merge of 4591954
Summary: Tests failed: 4, passed: 7437, ignored: 134 Build time: 03:37:56

Failed tests

org.jboss.as.test.integration.domain.mixed.eap740.MixedDomain740TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:144)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:116)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:61)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:51)
	at org.jboss.as.test.integration.domain.mixed.eap740.MixedDomain740TestSuite.initializeDomain(MixedDomain740TestSuite.java:28)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:207)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:105)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:140)
	... 24 more
Caused by: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:282)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:203)
	... 26 more
Caused by: java.util.concurrent.TimeoutException: Managed servers were not started within [120] seconds
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:683)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:667)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:271)
	... 27 more
------- Stdout: -------
INFO  [org.jboss.remoting] JBoss Remoting version 5.0.27.Final
INFO  [org.xnio] XNIO version 3.8.12.Final
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.8.12.Final
INFO  [org.jboss.threads] JBoss Threads version 2.4.0.Final
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] Starting HostController (host = primary)
INFO  [org.wildfly.security] ELY00001: WildFly Elytron version 2.2.2.Final
 [0m19:17:14,732 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final
 [0m [0m19:17:15,023 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m19:17:15,037 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m19:17:15,501 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final [0m
[Host Controller]  [0m [0m19:17:15,861 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.2.Final [0m
[Host Controller]  [0m [0m19:17:15,870 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final [0m
[Host Controller]  [0m [0m19:17:15,922 INFO  [org.jboss.as] (MSC service thread 1-3) WFLYSRV0049: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) starting [0m
[Host Controller]  [0m [0m19:17:16,404 INFO  [org.wildfly.security] (Host Controller Service Threads - 2) ELY00001: WildFly Elytron version 2.2.2.Final [0m
[Host Controller]  [0m [0m19:17:16,766 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:16,768 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:16,769 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:16,769 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:16,815 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m19:17:16,818 INFO  [org.xnio] (MSC service thread 1-2) XNIO version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:16,825 INFO  [org.xnio.nio] (MSC service thread 1-2) XNIO NIO Implementation Version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:16,888 INFO  [org.jboss.remoting] (MSC service thread 1-1) JBoss Remoting version 5.0.27.Final [0m
[Host Controller]  [0m [0m19:17:16,981 INFO  [org.jboss.as.remoting] (MSC service thread 1-6) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [33m19:17:17,714 WARN  [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0456: System property "java.net.preferIPv4Stack" is already set in the <system-properties> section of the configuration file. The value set in the command line will be overridden by that value. [0m
[Host Controller]  [33m [0m [0m19:17:18,517 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=default/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:18,590 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=ha/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:18,634 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=full/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m


org.jboss.as.test.integration.domain.mixed.eap740.ElytronOnlyPrimary740TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:144)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:95)
	at org.jboss.as.test.integration.domain.mixed.ElytronOnlyPrimaryTestSuite.getSupport(ElytronOnlyPrimaryTestSuite.java:15)
	at org.jboss.as.test.integration.domain.mixed.eap740.ElytronOnlyPrimary740TestSuite.initializeDomain(ElytronOnlyPrimary740TestSuite.java:24)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:207)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:105)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:140)
	... 23 more
Caused by: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:282)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:203)
	... 25 more
Caused by: java.util.concurrent.TimeoutException: Managed servers were not started within [120] seconds
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:683)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:667)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:271)
	... 26 more
------- Stdout: -------
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] Starting HostController (host = primary)
 [0m19:17:25,583 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final
 [0m [0m19:17:25,889 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m19:17:25,907 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m19:17:26,364 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final [0m
[Host Controller]  [0m [0m19:17:26,730 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.2.Final [0m
[Host Controller]  [0m [0m19:17:26,741 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final [0m
[Host Controller]  [0m [0m19:17:26,803 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) starting [0m
[Host Controller]  [0m [0m19:17:27,329 INFO  [org.wildfly.security] (Host Controller Service Threads - 4) ELY00001: WildFly Elytron version 2.2.2.Final [0m
[Host Controller]  [0m [0m19:17:27,697 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permissions' in the resource at address '/host=primary/subsystem=elytron/constant-permission-mapper=default-permission-mapper' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:27,731 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m19:17:27,732 INFO  [org.xnio] (MSC service thread 1-1) XNIO version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:27,739 INFO  [org.xnio.nio] (MSC service thread 1-1) XNIO NIO Implementation Version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:27,795 INFO  [org.jboss.remoting] (MSC service thread 1-1) JBoss Remoting version 5.0.27.Final [0m
[Host Controller]  [0m [0m19:17:27,913 INFO  [org.jboss.as.remoting] (MSC service thread 1-2) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [33m19:17:28,426 WARN  [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0456: System property "java.net.preferIPv4Stack" is already set in the <system-properties> section of the configuration file. The value set in the command line will be overridden by that value. [0m
[Host Controller]  [33m [0m [0m19:17:29,175 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=default/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:29,263 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=ha/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:29,297 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=full/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:29,332 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=full-ha/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:29,587 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0062: Http management interface listening on http://[::1]:9990/management and https://[::1]:-1/management [0m
[Host Controller]  [0m [0m19:17:29,588 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled [0m
[Host Controller]  [0m [0m19:17:29,588 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) (Host Controller) started in 3574ms - Started 70 of 70 services (16 services are lazy, passive or on-demand) - Host Controller configuration files in use: testing-domain.xml, testing-host-primary-elytron.xml [0m
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] HostController (host = primary) started in 4777 ms
Failed operation:
{
    "operation" => "read-resource",
    "address" => [


org.jboss.as.test.integration.domain.mixed.eap740.KernelBehavior740TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:144)
	at org.jboss.as.test.integration.domain.mixed.KernelBehaviorTestSuite.getSupport(KernelBehaviorTestSuite.java:24)
	at org.jboss.as.test.integration.domain.mixed.eap740.KernelBehavior740TestSuite.initializeDomain(KernelBehavior740TestSuite.java:25)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:282)
	at org.jboss.as.test.integration.domain.management.util.DomainTestSupport.start(DomainTestSupport.java:433)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:107)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:140)
	... 22 more
Caused by: java.util.concurrent.TimeoutException: Managed servers were not started within [120] seconds
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:683)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:667)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:271)
	... 25 more
------- Stdout: -------
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] Starting HostController (host = primary)
 [0m19:17:35,818 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final
 [0m [0m19:17:36,119 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m19:17:36,132 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m19:17:36,656 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final [0m
[Host Controller]  [0m [0m19:17:37,068 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.2.Final [0m
[Host Controller]  [0m [0m19:17:37,079 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final [0m
[Host Controller]  [0m [0m19:17:37,138 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) starting [0m
[Host Controller]  [0m [0m19:17:37,700 INFO  [org.wildfly.security] (Host Controller Service Threads - 2) ELY00001: WildFly Elytron version 2.2.2.Final [0m
[Host Controller]  [0m [0m19:17:38,054 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:38,055 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:38,055 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:38,056 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:38,100 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m19:17:38,104 INFO  [org.xnio] (MSC service thread 1-7) XNIO version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:38,114 INFO  [org.xnio.nio] (MSC service thread 1-7) XNIO NIO Implementation Version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:38,162 INFO  [org.jboss.remoting] (MSC service thread 1-7) JBoss Remoting version 5.0.27.Final [0m
[Host Controller]  [0m [0m19:17:38,249 INFO  [org.jboss.as.remoting] (MSC service thread 1-3) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [0m19:17:38,563 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0062: Http management interface listening on http://[::1]:9990/management and https://[::1]:-1/management [0m
[Host Controller]  [0m [0m19:17:38,563 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0053: Admin console listening on http://[::1]:9990 and https://[::1]:-1 [0m
[Host Controller]  [0m [0m19:17:38,657 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) (Host Controller) started in 2372ms - Started 69 of 72 services (16 services are lazy, passive or on-demand) - Host Controller configuration files in use: testing-domain-minimal.xml, testing-host.xml [0m
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] All servers started in 3551 ms
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] HostController (host = primary) started in 3812 ms
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] Starting HostController (host = secondary)
 [0m19:17:39,855 INFO  [org.jboss.modules] (main) JBoss Modules version 1.11.0.Final-redhat-00001
 [0m [0m19:17:40,162 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final-redhat-00001
 [0m [0m19:17:40,176 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m19:17:40,725 INFO  [org.jboss.modules] (main) JBoss Modules version 1.11.0.Final-redhat-00001 [0m
[Host Controller] WFLYHC0062: Invalid option '--quality=default'. Use domain.sh --help for information on valid command line arguments and their syntax.
[Host Controller]  [0m [0m
[Host Controller] Usage: domain.sh [args...]
[Host Controller] where args include:


org.jboss.as.test.integration.domain.mixed.eap740.MixedDomainOverlay740TestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:144)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:87)
	at org.jboss.as.test.integration.domain.mixed.eap740.MixedDomainOverlay740TestSuite.initializeDomain(MixedDomainOverlay740TestSuite.java:26)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
Caused by: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:207)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.start(MixedDomainTestSupport.java:105)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSuite.getSupport(MixedDomainTestSuite.java:140)
	... 22 more
Caused by: java.lang.RuntimeException: Could not start container
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:282)
	at org.jboss.as.test.integration.domain.mixed.MixedDomainTestSupport.startAndAdjust(MixedDomainTestSupport.java:203)
	... 24 more
Caused by: java.util.concurrent.TimeoutException: Managed servers were not started within [120] seconds
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:683)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:667)
	at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:271)
	... 25 more
------- Stdout: -------
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] Starting HostController (host = primary)
 [0m19:17:42,720 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final
 [0m [0m19:17:43,036 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m19:17:43,050 INFO  [org.jboss.as.process.Host Controller.status] (main) WFLYPC0018: Starting process 'Host Controller'
 [0m[Host Controller]  [0m19:17:43,577 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.2.Final [0m
[Host Controller]  [0m [0m19:17:43,920 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.2.Final [0m
[Host Controller]  [0m [0m19:17:43,929 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final [0m
[Host Controller]  [0m [0m19:17:43,986 INFO  [org.jboss.as] (MSC service thread 1-3) WFLYSRV0049: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) starting [0m
[Host Controller]  [0m [0m19:17:44,509 INFO  [org.wildfly.security] (Host Controller Service Threads - 2) ELY00001: WildFly Elytron version 2.2.2.Final [0m
[Host Controller]  [0m [0m19:17:44,870 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:44,871 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:44,871 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:44,872 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'max-permgen-size' in the resource at address '/host=primary/jvm=default' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:44,907 INFO  [org.jboss.as.host.controller] (Controller Boot Thread) WFLYHC0003: Creating http management service using network interface (management) port (9990) securePort (-1) [0m
[Host Controller]  [0m [0m19:17:44,914 INFO  [org.xnio] (MSC service thread 1-8) XNIO version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:44,922 INFO  [org.xnio.nio] (MSC service thread 1-8) XNIO NIO Implementation Version 3.8.12.Final [0m
[Host Controller]  [0m [0m19:17:44,979 INFO  [org.jboss.remoting] (MSC service thread 1-7) JBoss Remoting version 5.0.27.Final [0m
[Host Controller]  [0m [0m19:17:45,083 INFO  [org.jboss.as.remoting] (MSC service thread 1-3) WFLYRMT0001: Listening on [::1]:9999 [0m
[Host Controller]  [0m [33m19:17:45,637 WARN  [org.jboss.as.controller] (Controller Boot Thread) WFLYCTL0456: System property "java.net.preferIPv4Stack" is already set in the <system-properties> section of the configuration file. The value set in the command line will be overridden by that value. [0m
[Host Controller]  [33m [0m [0m19:17:46,465 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=default/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:46,539 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=ha/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:46,582 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=full/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:46,617 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'cluster' in the resource at address '/profile=full-ha/subsystem=ejb3/service=remote' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation. [0m
[Host Controller]  [0m [0m19:17:46,775 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0062: Http management interface listening on http://[::1]:9990/management and https://[::1]:-1/management [0m
[Host Controller]  [0m [0m19:17:46,776 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0054: Admin console is not enabled [0m
[Host Controller]  [0m [0m19:17:46,776 INFO  [org.jboss.as] (Controller Boot Thread) WFLYSRV0025: WildFly Full 31.0.0.Beta1-SNAPSHOT (WildFly Core 23.0.0.Beta1-SNAPSHOT) (Host Controller) started in 3615ms - Started 69 of 72 services (18 services are lazy, passive or on-demand) - Host Controller configuration files in use: testing-domain.xml, testing-host.xml [0m
INFO  [org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil] HostController (host = primary) started in 4923 ms
Failed operation:
{


@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

@wildfly-ci

This comment was marked as outdated.

* @param registration the child registration of this registry that should no longer be available
* @param descriptionProvider provider for descriptions of the additional attributes or child types
*
* @return a resource registration which may be used to add attributes, operations and sub-models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should note that it may return null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -127,6 +133,7 @@ private HostInfo(final ModelNode hostInfo, DomainHostExcludeRegistry hostIgnoreR
productVersion = hostInfo.hasDefined(PRODUCT_VERSION) ? hostInfo.require(PRODUCT_VERSION).asString() : null;
remoteConnectionId = hostInfo.hasDefined(RemoteDomainConnectionService.DOMAIN_CONNECTION_ID)
? hostInfo.get(RemoteDomainConnectionService.DOMAIN_CONNECTION_ID).asLong() : null;
this.stability = Optional.ofNullable(hostInfo.get(ModelDescriptionConstants.STABILITY).asStringOrNull()).map(Stability::valueOf).orElse(productConfig.getDefaultStability());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a comment explaining why orElse(productConfig.getDefaultStability()) is ok.

I think it is, but I'm tired and can't articulate why I think so. But in any case a future maintainer likely won't easily understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added clarifying comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI this basically means if the DC is running at a level other than its default, then a legacy HC can't join.

That's ok, as it's conservative, but otoh I think it should work fine. Anything on the DC that's not at 'default' stability must be associated with a later API version than whatever is on the legacy HC, so it would have to be transformed back to that legacy version.

This is what I was too tired to articulate yesterday. :) Thanks for adding the comment. I wrote the above two paragraphs for the sake of discussion in case I'm thinking about it wrong.

logging/pom.xml Outdated
<groupId>*</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to this file seem odd, since there are no other changes to this module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See: e081907

@@ -366,6 +367,12 @@ public static ServerEnvironmentWrapper determineEnvironment(String[] args, Prope
} else {
gitBranch = arg.substring(idx + 1);
}
} else if (arg.startsWith(CommandLineConstants.STABILITY)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, if ProductConfig.getDefaultStability() == DEFAULT this should fail. A similar check can be done in CommandLineArgumentUsageImpl to guard allowing the argument.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Also removed from command line usage, when stability has only 1 possible value.

@@ -445,6 +446,12 @@ public static HostControllerEnvironmentWrapper determineEnvironment(String[] arg
} else if (arg.equals(CommandLineConstants.SECMGR)) {
// Enable the security manager
securityManagerEnabled = true;
} else if (arg.startsWith(CommandLineConstants.STABILITY)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in server module Main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Also removed from command line usage, when stability has only 1 possible value.

@bstansberry
Copy link
Contributor

@pferraro I've made some minor comments but in general looks good.

@wildfly-ci

This comment was marked as outdated.

@@ -127,6 +133,7 @@ private HostInfo(final ModelNode hostInfo, DomainHostExcludeRegistry hostIgnoreR
productVersion = hostInfo.hasDefined(PRODUCT_VERSION) ? hostInfo.require(PRODUCT_VERSION).asString() : null;
remoteConnectionId = hostInfo.hasDefined(RemoteDomainConnectionService.DOMAIN_CONNECTION_ID)
? hostInfo.get(RemoteDomainConnectionService.DOMAIN_CONNECTION_ID).asLong() : null;
this.stability = Optional.ofNullable(hostInfo.get(ModelDescriptionConstants.STABILITY).asStringOrNull()).map(Stability::valueOf).orElse(productConfig.getDefaultStability());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI this basically means if the DC is running at a level other than its default, then a legacy HC can't join.

That's ok, as it's conservative, but otoh I think it should work fine. Anything on the DC that's not at 'default' stability must be associated with a later API version than whatever is on the legacy HC, so it would have to be transformed back to that legacy version.

This is what I was too tired to articulate yesterday. :) Thanks for adding the comment. I wrote the above two paragraphs for the sake of discussion in case I'm thinking about it wrong.

server/src/main/java/org/jboss/as/server/Main.java Outdated Show resolved Hide resolved
@bstansberry bstansberry merged commit 2ae1c3c into wildfly:main Dec 9, 2023
@bstansberry
Copy link
Contributor

Thanks @pferraro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature This PR adds a new feature to WildFly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants