Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: wildfly/wildfly
Choose a Base Repository
wildfly/wildfly
2002simon01/jboss-as
ALRubinger/wildfly
ErikWRasmussen/jboss-as
KurtStam/jboss-as
Lerm/jboss-as
LinuxEvangelist/jboss-as
Mogztter/wildfly
OndraZizka/jboss-as
PayU-EMEA/jboss-as
aaronwalker/jboss-as
agibsonccc/jboss-as
akalachm/jboss-as
alesj/jboss-as
alns/jboss-as
aloubyansky/wildfly
aminorex/jboss-as
andersnorgaard/jboss-as
andredemathe/jboss-as
andytaylor/wildfly
aprilhu0/jboss-as
ashields/jboss-as
aslakknutsen/jboss-as
asoldano/wildfly
awirayaksa/jboss-as
bershath/jboss-as
bgeorges/jboss-as
blue61/jboss-as
bosschaert/jboss-as
bstansberry/wildfly
btison/jboss-as
cbue/jboss-as
charleswmiller/jboss-as
chikin/jboss-as
chriskriel/jboss-as
coberle/jboss-as
colmsean/jboss-as
ctomc/wildfly
dandreadis/wildfly
darranl/wildfly
dcaillia/jboss-as
denuno/jboss-as
deruelle/jboss-as
dhollandAtWex/dh-old-forks-jboss-as
dmlloyd/wildfly
dobozysaurus/jboss-as
dpospisil/wildfly
edbean/jboss-as
emannuel/jboss-as
emerile1/jboss-as
emuckenhuber/wildfly
esantana/jboss-as
fbricon/jboss-as
fedora-jboss-as/wildfly
fei-yin/jboss-as
fharms/wildfly
fregaham/jboss-as
fxlambda-twickly5/wildfly
garcimouche/jboss-as
goldmann/jboss-as
gonne/jboss-as
gvagenas/jboss-as
hamanju/jboss-as
hamming229/jboss-as
heiko-braun/wildfly
hgkmiracle/jboss-as
hunter-thom/jboss-as
ikaro/jboss-as
istudens/wildfly
jaikiran/wildfly
jamezp/wildfly
janpiel/jboss-as
java-coder/jboss-as
jayhowell/jboss-as
jbossejb3/jboss-as
jdmr/jboss-as
jdpgrailsdev/jboss-as
jeenapeter/jboss-as
jeffzhang/jboss-as
jeremiahshirk/jboss-as
jiwils/jboss-as
jlindesmith/jboss-as
jmartisk/wildfly
jocstar/jboss-as
joseph2000/jboss-as
jrwhitley/jboss-as
jswordfish/jboss-as
jtoerber/jboss-as
julianzhu/jboss-as
jwulf/jboss-as
kabir/wildfly
kbys/jboss-as
koledzhikov/jboss-as
kpiwko/wildfly
kylape/wildfly
ldevrie/jboss-as
lingling788/jboss-as
liweinan/jboss-as
luksa/wildfly
lydonchandra/jboss-as
maasvdberg/wildfly
madhumita/jboss-as
madhumita12/jboss-as
maerqiang/jboss-as
maeste/jboss-as
mageshbk/jboss-as
markmc/jboss-as
markyour/jboss-as
maschmid/jboss-as
matejonnet/jboss-as
mathieuancelin/jboss-as
mathieufortin01/jboss-as
mattdrees/jboss-as
maxandersen/jboss-as
maximilienw/jboss-as
mbogoevici/jboss-as
mbrasier/jboss-as
mdemerath/jboss-as
mgencur/jboss-as
michaelschuetz/jboss-as
miclark/jboss-as
migue/wildfly
mikebrock/jboss-as
mkiman/jboss-as
mlinhard/jboss-as
mmoyses/jboss-as
mojavelinux/jboss-as
mschwartzman/jboss-as
mstruk/jboss-as
nikkack/jboss-as
nookala/jboss-as
npfr/jboss-as
nscavell/jboss-as
ochaloup/wildfly
patmcdonough/jboss-as
pbielicki/jboss-as
pentarou/jboss-as
pepite/jboss-as
petbac/jboss-as
pferraro/wildfly
pmf8/jboss-as
pmuir/jboss-as
porobd/jboss-as
prabugp/jboss-as
pragnesh/jboss-as
prasad-deshpande/jboss-as
prcg66/jboss-as
pskopek/wildfly
pslegr/jboss-as
rachmatowicz/wildfly
rachmatowicz2/jboss-as
randythomas/jboss-as
rhusar/wildfly
richmidwinter/jboss-as
richsharples/jboss-as
ringerc/jboss-as
robertpanzer/jboss-as
robstryker/jboss-as
rsvoboda/wildfly
rzimmermann/jboss-as
sacdroid/jboss-as
samuelo/jboss-as
sasgww/jboss-as
scottmarlow/wildfly
sebersole/jboss-as
seeburger-ag/jboss-as
seko2000/jboss-as
sgilda/wildfly
shadangi/jboss-as
shuawest/jboss-as
sjancke/jboss-as
skoussou/jboss-as
smcgowan/wildfly
spreadline/jboss-as
ssilvert/wildfly
starksm64/jboss-as
starksmjboss/jboss-as
stliu/jboss-as
stuartwdouglas/wildfly
sujaybawaskar/jboss-as
tdiesler/wildfly
tfennelly/jboss-as
thammoud/jboss-as
thanhvc/jboss-as
thauser/jboss-as
thomasnymand/jboss-as
thunderlei/jboss-as
tomathome/jboss-as
tomwells/jboss-as
tristantarrant/wildfly
tyasuma/jboss-as
undertow-io/jboss-as
vladimirralev/jboss-as
vmariusvv/jboss-as
vratsel/jboss-as
weld/wildfly
wfink/wildfly
wolfc/jboss-as
zhigunovs/jboss-as
zhleonix/jboss-as
Nothing to show
base: 2763925
head repository: wildfly/wildfly
Choose a Head Repository
wildfly/wildfly
2002simon01/jboss-as
ALRubinger/wildfly
ErikWRasmussen/jboss-as
KurtStam/jboss-as
Lerm/jboss-as
LinuxEvangelist/jboss-as
Mogztter/wildfly
OndraZizka/jboss-as
PayU-EMEA/jboss-as
aaronwalker/jboss-as
agibsonccc/jboss-as
akalachm/jboss-as
alesj/jboss-as
alns/jboss-as
aloubyansky/wildfly
aminorex/jboss-as
andersnorgaard/jboss-as
andredemathe/jboss-as
andytaylor/wildfly
aprilhu0/jboss-as
ashields/jboss-as
aslakknutsen/jboss-as
asoldano/wildfly
awirayaksa/jboss-as
bershath/jboss-as
bgeorges/jboss-as
blue61/jboss-as
bosschaert/jboss-as
bstansberry/wildfly
btison/jboss-as
cbue/jboss-as
charleswmiller/jboss-as
chikin/jboss-as
chriskriel/jboss-as
coberle/jboss-as
colmsean/jboss-as
ctomc/wildfly
dandreadis/wildfly
darranl/wildfly
dcaillia/jboss-as
denuno/jboss-as
deruelle/jboss-as
dhollandAtWex/dh-old-forks-jboss-as
dmlloyd/wildfly
dobozysaurus/jboss-as
dpospisil/wildfly
edbean/jboss-as
emannuel/jboss-as
emerile1/jboss-as
emuckenhuber/wildfly
esantana/jboss-as
fbricon/jboss-as
fedora-jboss-as/wildfly
fei-yin/jboss-as
fharms/wildfly
fregaham/jboss-as
fxlambda-twickly5/wildfly
garcimouche/jboss-as
goldmann/jboss-as
gonne/jboss-as
gvagenas/jboss-as
hamanju/jboss-as
hamming229/jboss-as
heiko-braun/wildfly
hgkmiracle/jboss-as
hunter-thom/jboss-as
ikaro/jboss-as
istudens/wildfly
jaikiran/wildfly
jamezp/wildfly
janpiel/jboss-as
java-coder/jboss-as
jayhowell/jboss-as
jbossejb3/jboss-as
jdmr/jboss-as
jdpgrailsdev/jboss-as
jeenapeter/jboss-as
jeffzhang/jboss-as
jeremiahshirk/jboss-as
jiwils/jboss-as
jlindesmith/jboss-as
jmartisk/wildfly
jocstar/jboss-as
joseph2000/jboss-as
jrwhitley/jboss-as
jswordfish/jboss-as
jtoerber/jboss-as
julianzhu/jboss-as
jwulf/jboss-as
kabir/wildfly
kbys/jboss-as
koledzhikov/jboss-as
kpiwko/wildfly
kylape/wildfly
ldevrie/jboss-as
lingling788/jboss-as
liweinan/jboss-as
luksa/wildfly
lydonchandra/jboss-as
maasvdberg/wildfly
madhumita/jboss-as
madhumita12/jboss-as
maerqiang/jboss-as
maeste/jboss-as
mageshbk/jboss-as
markmc/jboss-as
markyour/jboss-as
maschmid/jboss-as
matejonnet/jboss-as
mathieuancelin/jboss-as
mathieufortin01/jboss-as
mattdrees/jboss-as
maxandersen/jboss-as
maximilienw/jboss-as
mbogoevici/jboss-as
mbrasier/jboss-as
mdemerath/jboss-as
mgencur/jboss-as
michaelschuetz/jboss-as
miclark/jboss-as
migue/wildfly
mikebrock/jboss-as
mkiman/jboss-as
mlinhard/jboss-as
mmoyses/jboss-as
mojavelinux/jboss-as
mschwartzman/jboss-as
mstruk/jboss-as
nikkack/jboss-as
nookala/jboss-as
npfr/jboss-as
nscavell/jboss-as
ochaloup/wildfly
patmcdonough/jboss-as
pbielicki/jboss-as
pentarou/jboss-as
pepite/jboss-as
petbac/jboss-as
pferraro/wildfly
pmf8/jboss-as
pmuir/jboss-as
porobd/jboss-as
prabugp/jboss-as
pragnesh/jboss-as
prasad-deshpande/jboss-as
prcg66/jboss-as
pskopek/wildfly
pslegr/jboss-as
rachmatowicz/wildfly
rachmatowicz2/jboss-as
randythomas/jboss-as
rhusar/wildfly
richmidwinter/jboss-as
richsharples/jboss-as
ringerc/jboss-as
robertpanzer/jboss-as
robstryker/jboss-as
rsvoboda/wildfly
rzimmermann/jboss-as
sacdroid/jboss-as
samuelo/jboss-as
sasgww/jboss-as
scottmarlow/wildfly
sebersole/jboss-as
seeburger-ag/jboss-as
seko2000/jboss-as
sgilda/wildfly
shadangi/jboss-as
shuawest/jboss-as
sjancke/jboss-as
skoussou/jboss-as
smcgowan/wildfly
spreadline/jboss-as
ssilvert/wildfly
starksm64/jboss-as
starksmjboss/jboss-as
stliu/jboss-as
stuartwdouglas/wildfly
sujaybawaskar/jboss-as
tdiesler/wildfly
tfennelly/jboss-as
thammoud/jboss-as
thanhvc/jboss-as
thauser/jboss-as
thomasnymand/jboss-as
thunderlei/jboss-as
tomathome/jboss-as
tomwells/jboss-as
tristantarrant/wildfly
tyasuma/jboss-as
undertow-io/jboss-as
vladimirralev/jboss-as
vmariusvv/jboss-as
vratsel/jboss-as
weld/wildfly
wfink/wildfly
wolfc/jboss-as
zhigunovs/jboss-as
zhleonix/jboss-as
Nothing to show
compare: 7c60736
  • 3 commits
  • 8 files changed
  • 0 commit comments
  • 1 contributor
Commits on Mar 23, 2019
…ifferent JVMs

MisxedDomainTestSupport will trigger caller (i.e a TestSuite) being ignored if the version under test can't handle the JVMs on offer.

Test jobs can be configured with different java home paths for different JVMs. If this is done MixedDomainTestSupport will try and use an appropriate one for the legacy host.
Commits on Apr 05, 2019
[WFLY-11896] Improve ability of mixed-domain testsuite to deal with different JVMs
@@ -199,8 +199,28 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<jboss.test.host.slave.jvmhome>${java8.home}</jboss.test.host.slave.jvmhome>
<jboss.test.host.slave.controller.jvmhome>${java8.home}</jboss.test.host.slave.controller.jvmhome>
<jboss.test.legacy.host.java8.home>${java8.home}</jboss.test.legacy.host.java8.home>
</systemPropertyVariables>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>legacy-slave-java11-home</id>
<activation>
<jdk>[12,)</jdk>
<property>
<name>java11.home</name>
</property>
</activation>
<build>
<plugins>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<systemPropertyVariables>
<jboss.test.legacy.host.java11.home>${java11.home}</jboss.test.legacy.host.java11.home>
</systemPropertyVariables>
</configuration>
</plugin>
@@ -87,9 +87,6 @@ static void adjustForVersion(final DomainClient client, final Version.AsVersion

final DomainAdjuster adjuster;
switch (asVersion) {
case EAP_6_2_0:
case EAP_6_3_0:
throw new UnsupportedOperationException();
case EAP_6_4_0:
adjuster = new DomainAdjuster640();
break;
@@ -47,9 +47,6 @@ static void adjustForVersion(final DomainClient client, final Version.AsVersion

final LegacyConfigAdjuster adjuster;
switch (asVersion) {
case EAP_6_2_0:
case EAP_6_3_0:
throw new UnsupportedOperationException();
case EAP_6_4_0:
adjuster = new LegacyConfigAdjuster640();
break;
@@ -68,7 +68,7 @@ protected static MixedDomainTestSupport getSupport(Class<?> testClass) {
return getSupport(testClass, Profile.FULL_HA, false);
}

protected static MixedDomainTestSupport getSupport(Class<?> testClass, boolean withMasterServers) {
protected static MixedDomainTestSupport getSupport(Class<?> testClass, boolean withMasterServers) {
return getSupport(testClass, Profile.FULL_HA, withMasterServers);
}

@@ -79,6 +79,7 @@ protected static MixedDomainTestSupport getSupport(Class<?> testClass, Profile p
}
return support;
}

/**
* Call this from a @BeforeClass method
*
@@ -91,6 +92,7 @@ protected static MixedDomainTestSupport getSupport(Class<?> testClass, String ma
protected static MixedDomainTestSupport getSupport(Class<?> testClass, String masterConfig, boolean adjustDomain, boolean legacyConfig, boolean withMasterServers) {
return getSupport(testClass, masterConfig, null, Profile.FULL_HA, adjustDomain, legacyConfig, withMasterServers);
}

/**
* Call this from a @BeforeClass method
*
@@ -147,7 +149,8 @@ static MixedDomainTestSupport getSupport(Class<?> testClass, String domainConfig
testSupport = MixedDomainTestSupport.create(testClass.getSimpleName(), version);
}
} catch (Exception e) {
throw new RuntimeException(e);
MixedDomainTestSuite.version = null;
throw (e instanceof RuntimeException ? (RuntimeException) e : new RuntimeException(e));
}
try {
//Start the the domain with adjustments to domain.xml
@@ -43,6 +43,7 @@
import org.jboss.as.test.shared.TimeoutUtil;
import org.jboss.dmr.ModelNode;
import org.junit.Assert;
import org.junit.Assume;


/**
@@ -52,6 +53,12 @@

public static final String STANDARD_DOMAIN_CONFIG = "copied-master-config/domain.xml";
private static final String JBOSS_DOMAIN_SERVER_ARGS = "jboss.domain.server.args";
private static final int TEST_VM_VERSION;

static {
String spec = System.getProperty("java.specification.version");
TEST_VM_VERSION = "1.8".equals(spec) ? 8 : Integer.parseInt(spec);
}

private final Version.AsVersion version;
private final boolean adjustDomain;
@@ -69,6 +76,7 @@ private MixedDomainTestSupport(Version.AsVersion version, String testClass, Stri
this.legacyConfig = legacyConfig;
this.withMasterServers = withMasterServers;
this.profile = profile;
configureSlaveJavaHome();
}

private static WildFlyManagedConfiguration configWithDisabledAsserts(String jbossHome){
@@ -158,6 +166,29 @@ private void startSlaveServer() {
Assert.fail("Slave server-one did not start within " + timeout + " ms");
}

private void configureSlaveJavaHome() {
// Look for properties pointing to a java home to use for the legacy host.
// Look for homes for the max JVM version the host can handle, working back to the min it can handle.
// We could start with the oldest and work forward, but that would likely result in all versions testing
// against the oldest VM. Starting with the newest will increase coverage by increasing the probability
// of different VM versions being used across the overall set of legacy host versions.
String javaHome = null;
for (int i = Math.min(version.getMaxVMVersion(), TEST_VM_VERSION - 1); i >= version.getMinVMVersion() && javaHome == null; i--) {
javaHome = System.getProperty("jboss.test.legacy.host.java" + i + ".home");
}

if (javaHome != null) {
WildFlyManagedConfiguration cfg = getDomainSlaveConfiguration();
cfg.setJavaHome(javaHome);
cfg.setControllerJavaHome(javaHome);
System.out.println("Set legacy host controller to use " + javaHome + " as JAVA_HOME");
} else {
// Ignore the test if the slave cannot run using the current VM version
Assume.assumeTrue(TEST_VM_VERSION <= version.getMaxVMVersion());
Assume.assumeTrue(TEST_VM_VERSION >= version.getMinVMVersion());
}
}

private void startAndAdjust() {

String jbossDomainServerArgsValue = null;
@@ -116,9 +116,7 @@ public void test00001_ServerRunning() throws Exception {

@Test
public void test00002_Versioning() throws Exception {
if (version == Version.AsVersion.EAP_6_2_0
|| version == Version.AsVersion.EAP_7_0_0) {
//6.2.0 (https://issues.jboss.org/browse/WFLY-3228) and
if (version == Version.AsVersion.EAP_7_0_0) {
//7.0.0 (https://issues.jboss.org/browse/WFCORE-401)
// have the slave report back its own version, rather than the one from the DC,
//which is what should happen
@@ -226,10 +224,6 @@ public void test00010_JgroupsTransformers() throws Exception {
*/
@Test
public void test00011_ExampleDSConnection() throws Exception{
if (version == Version.AsVersion.EAP_6_2_0) {
// see: https://issues.jboss.org/browse/WFLY-7792
return;
}
PathAddress exampleDSAddress = PathAddress.pathAddress(PathElement.pathElement(HOST, "slave"),
PathElement.pathElement(RUNNING_SERVER, "server-one"), PathElement.pathElement(SUBSYSTEM, "datasources"),
PathElement.pathElement("data-source", "ExampleDS"));
@@ -21,6 +21,8 @@
*/
package org.jboss.as.test.integration.domain.mixed;

import org.junit.Assume;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -41,12 +43,10 @@
String EAP = "jboss-eap-";

enum AsVersion {
EAP_6_2_0(EAP, 6, 2, 0),
EAP_6_3_0(EAP, 6, 3, 0),
EAP_6_4_0(EAP, 6, 4, 0),
EAP_7_0_0(EAP, 7, 0, 0),
EAP_7_1_0(EAP, 7, 1, 0),
EAP_7_2_0(EAP, 7, 2, 0),
EAP_6_4_0(EAP, 6, 4, 0, 8, 8),
EAP_7_0_0(EAP, 7, 0, 0, 8, 8),
EAP_7_1_0(EAP, 7, 1, 0, 8, 8),
EAP_7_2_0(EAP, 7, 2, 0, 11, 8),
;


@@ -55,14 +55,18 @@
private final int major;
private final int minor;
private final int micro;
private final int maxVM;
private final int minVM;
final String version;

AsVersion(String basename, int major, int minor, int micro){
AsVersion(String basename, int major, int minor, int micro, int maxVM, int minVM){
this.basename = basename;
this.major = major;
this.minor = minor;
this.micro = micro;
this.version = major + "." + minor + "." + micro;
this.maxVM = maxVM;
this.minVM = minVM;
}

public String getBaseName() {
@@ -86,7 +90,7 @@ public String getZipFileName() {
}

public boolean isEAP6Version() {
return (this == EAP_6_2_0 || this == EAP_6_3_0 || this == EAP_6_4_0);
return (this == EAP_6_4_0);
}

public int getMajor() {
@@ -101,6 +105,34 @@ public int getMicro() {
return micro;
}

/**
* Gets the maximum Java version under which a legacy host can properly
* execute tests.
*/
public int getMaxVMVersion() {
return maxVM;
}

/**
* Gets the minimum Java version under which a legacy host can properly
* execute tests.
*/
public int getMinVMVersion() {
return minVM;
}

/**
* Checks whether the current VM version exceeds the maximum version under which a legacy host can properly
* execute tests. The check is disabled if system property "jboss.test.host.slave.jvmhome" is set.
*/
public void assumeMaxVM() {
if (System.getProperty("jboss.test.host.slave.jvmhome") == null) {
String javaSpecVersion = System.getProperty("java.specification.version");
int vm = "1.8".equals(javaSpecVersion) ? 8 : Integer.parseInt(javaSpecVersion);
Assume.assumeFalse(vm > maxVM);
}
}

int compare(int major, int minor) {
if (this.major < major) {
return -1;
@@ -36,6 +36,7 @@

@BeforeClass
public static void initializeDomain() {
Version.AsVersion.EAP_6_4_0.assumeMaxVM();
ElytronOnlyMasterTestSuite.getSupport(ElytronOnlyMaster640TestSuite.class);
}
}

No commit comments for this range

You can’t perform that action at this time.