Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure websockets to the Undertow subsystem #6801

Merged
merged 1 commit into from Oct 22, 2014
Merged

Add ability to configure websockets to the Undertow subsystem #6801

merged 1 commit into from Oct 22, 2014

Conversation

stuartwdouglas
Copy link
Contributor

No description provided.

@wildfly-ci
Copy link

Linux with security manager Build 200 is now running using a merge of 73e3579

@wildfly-ci
Copy link

Linux Build 5186 is now running using a merge of 73e3579

@wildfly-ci
Copy link

Windows Build 315 is now running using a merge of 73e3579

@wildfly-ci
Copy link

Linux with security manager Build 200 outcome was SUCCESS using a merge of 73e3579
Summary: Tests passed: 755, ignored: 243 Build time: 0:30:55

@wildfly-ci
Copy link

Linux Build 5186 outcome was SUCCESS using a merge of 73e3579
Summary: Tests passed: 3084, ignored: 261 Build time: 0:56:18

@wildfly-ci
Copy link

Windows Build 315 outcome was SUCCESS using a merge of 73e3579
Summary: Tests passed: 3084, ignored: 261 Build time: 0:56:21

bstansberry
bstansberry reviewed Oct 10, 2014
View reviewed changes
undertow/src/main/java/org/wildfly/extension/undertow/WebsocketsDefinition.java
protected static final SimpleAttributeDefinition BUFFER_POOL =
new SimpleAttributeDefinitionBuilder("buffer-pool", ModelType.STRING, true)
.setFlags(AttributeAccess.Flag.RESTART_ALL_SERVICES)
.setAllowExpression(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This attribute is a model reference so it shouldn't support expressions.

@stuartwdouglas
Copy link
Contributor Author

I also forgot to update the older versions of the parsers to add this automatically.

@wildfly-ci
Copy link

Windows Build 332 is now running using a merge of fb66469

@wildfly-ci
Copy link

Linux Build 5205 is now running using a merge of fb66469

@wildfly-ci
Copy link

Linux with security manager Build 217 is now running using a merge of fb66469

@wildfly-ci
Copy link

Linux with security manager Build 217 outcome was FAILURE using a merge of fb66469
Summary: Tests failed: 1 (1 new), passed: 754, ignored: 244 Build time: 0:30:39

Build problems:

Failed tests detected

Failed tests

org.wildfly.extension.undertow.UndertowDefaultConfigUpgradeTestCase.testSubsystem: java.lang.IllegalArgumentException: WFLYCTL0289: No operation entry called 'add' registered at '[
    ("subsystem" => "undertow"),
    ("setting" => "websockets")

@wildfly-ci
Copy link

Linux Build 5205 outcome was FAILURE using a merge of 7021f0a
Summary: Tests failed: 4 (4 new), passed: 3021, ignored: 262 Build time: 0:54:18

Build problems:

Failed tests detected

Failed tests

org.wildfly.extension.undertow.UndertowDefaultConfigUpgradeTestCase.testSubsystem: java.lang.IllegalArgumentException: WFLYCTL0289: No operation entry called 'add' registered at '[
    ("subsystem" => "undertow"),
    ("setting" => "websockets")

org.jboss.as.test.integration.domain.SlaveHostControllerAuthenticationTestCase: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:238)

org.jboss.as.test.integration.domain.suites.DomainTestSuite: org.jboss.as.test.integration.domain.suites.CLITestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:238)

org.jboss.as.test.integration.domain.suites.DomainTestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:238)

@wildfly-ci
Copy link

Windows Build 332 outcome was FAILURE using a merge of 7021f0a
Summary: Tests failed: 4 (4 new), passed: 3020, ignored: 262, muted: 1 Build time: 0:55:51

Build problems:

Failed tests detected

Failed tests

org.wildfly.extension.undertow.UndertowDefaultConfigUpgradeTestCase.testSubsystem: java.lang.IllegalArgumentException: WFLYCTL0289: No operation entry called 'add' registered at '[
    ("subsystem" => "undertow"),
    ("setting" => "websockets")

org.jboss.as.test.integration.domain.suites.DomainTestSuite: org.jboss.as.test.integration.domain.SlaveHostControllerAuthenticationTestCase: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitHostController(DomainLifecycleUtil.java:459)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:243)

org.jboss.as.test.integration.domain.suites.DomainTestSuite: org.jboss.as.test.integration.domain.suites.CLITestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:238)

org.jboss.as.test.integration.domain.suites.DomainTestSuite: java.lang.RuntimeException: java.lang.RuntimeException: java.lang.RuntimeException: Could not start container
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.awaitServers(DomainLifecycleUtil.java:442)
    at org.jboss.as.test.integration.domain.management.util.DomainLifecycleUtil.start(DomainLifecycleUtil.java:238)

@wildfly-ci
Copy link

Linux with security manager Build 218 is now running using a merge of 7021f0a

@wildfly-ci
Copy link

Windows Build 333 is now running using a merge of 7021f0a

@wildfly-ci
Copy link

Linux Build 5206 is now running using a merge of 7021f0a

@wildfly-ci
Copy link

Linux with security manager Build 218 outcome was SUCCESS using a merge of 7021f0a
Summary: Tests passed: 755, ignored: 244 Build time: 0:30:13

@wildfly-ci
Copy link

Windows Build 333 outcome was SUCCESS using a merge of 7021f0a
Summary: Tests passed: 3084, ignored: 262 Build time: 0:54:33

@wildfly-ci
Copy link

Linux Build 5206 outcome was SUCCESS using a merge of 7021f0a
Summary: Tests passed: 3083, ignored: 262, muted: 1 Build time: 0:57:51

@bstansberry bstansberry added the ready-for-merge Only for use by those with merge permissions! label Oct 22, 2014
bstansberry added a commit that referenced this pull request Oct 22, 2014
@bstansberry
Merge pull request #6801 from stuartwdouglas/undertow-websockets
8b35114 
Add ability to configure websockets to the Undertow subsystem
@bstansberry bstansberry merged commit 8b35114 into wildfly:master Oct 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-merge Only for use by those with merge permissions!
Projects
None yet
Milestone
No milestone
3 participants
@stuartwdouglas @wildfly-ci @bstansberry