Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-10288] Remove remaining Java EE 8 Preview information #11424

Merged
merged 4 commits into from Jul 18, 2018

Conversation

@jamezp
Copy link
Member

jamezp commented Jul 11, 2018

https://issues.jboss.org/browse/WFLY-10288

The first commit just updates the documentation removing the reference to Java EE 8 preview mode.

The second commit removes the JAX-WS Java EE 7 support. It looks like this one got missed somehow.

The third commit moves the BeanValidationEE8TestCase to the integration tests.

The forth commit cleans up the rest of the Java EE 8 tech preview resources.

@@ -48,6 +48,10 @@
<groupId>org.asciidoctor</groupId>
<artifactId>asciidoctor-maven-plugin</artifactId>
<configuration>
<attributes>
<javaee_version>8</javaee_version>
<wildflyversion>${verifier.product.release.version}</wildflyversion>

This comment has been minimized.

Copy link
@bstansberry

bstansberry Jul 11, 2018

Contributor

This is kind of a hijack of something meant and documented for a different purpose. If we want different uses we should probably rework the property and clarify it's use.

For the verifier use it's major.minor while wildflyversion in the past was just major. So there's a bit of a mismatch there.

This comment has been minimized.

Copy link
@bstansberry

bstansberry Jul 11, 2018

Contributor

Any change to the properties should be discussed with Yeray though, as these are important for eap-ization and any changes will need to be accounted for there.

This comment has been minimized.

Copy link
@jamezp

jamezp Jul 11, 2018

Author Member

Yeah. It's on my documentation todo list to change several constants to attributes.

Sure yeah. We don't have to use that version as it was set to just "13" before. I just figured the less places we need to make changes the better. I kind of wonder if these docs should just be in their own repository anyway.

This comment has been minimized.

Copy link
@kabir

kabir Jul 13, 2018

Contributor

@jamezp I think a product.docs.server.version in the root pom next to verifier.product.release.version will make this cleaner

This comment has been minimized.

Copy link
@jamezp

jamezp Jul 13, 2018

Author Member

Done.

@scottmarlow

This comment has been minimized.

Copy link
Contributor

scottmarlow commented Jul 11, 2018

Would it make sense to keep the BeanValidationEE8TestCase test? Perhaps move it to testsuite/integration/basic? I'm not sure if there is anything worth keeping in it but thought I would ask.

Copy link
Contributor

asoldano left a comment

Thanks for the jaxws module fix

@jamezp

This comment has been minimized.

Copy link
Member Author

jamezp commented Jul 12, 2018

We could keep the test. I just deleted the ee8-temp module. Since it was in that module I guess it fell victim :)

@rsvoboda

This comment has been minimized.

Copy link
Contributor

rsvoboda commented Jul 12, 2018

@mjurc - keep the BeanValidationEE8TestCase ?

@mjurc

This comment has been minimized.

Copy link
Contributor

mjurc commented Jul 12, 2018

Please move the BeanValidationEE8TestCase to testsuite/integration/basic module. It seems to be a bit more thorough than our standing BeanValidationTestCase.

Copy link
Contributor

kabir left a comment

In addition to the above comments, please also remove the full-feature-pack-licenses-addendum.html and servlet-feature-pack-licenses-addendum.html files as I think we should now have removed all the remaining hardcoded versioned jars (ie the ones not coming from the pom)?

@jamezp jamezp force-pushed the jamezp:WFLY-10288 branch from 7df1b6b to dd2a179 Jul 12, 2018
@jamezp

This comment has been minimized.

Copy link
Member Author

jamezp commented Jul 12, 2018

Thanks @kabir I missed those and they are now removed.

@mjurc @rsvoboda I added a commit that moves the BeanValidationEE8TestCase to the integration tests.

Copy link
Contributor

rsvoboda left a comment

I have no further comments?

@mjurc
mjurc approved these changes Jul 13, 2018
@jamezp jamezp force-pushed the jamezp:WFLY-10288 branch from dd2a179 to 5ddf0bf Jul 13, 2018
@scottmarlow

This comment has been minimized.

Copy link
Contributor

scottmarlow commented Jul 16, 2018

@kabir @jamezp will the BeanValidationEE8TestCase be moved as part of this PR or will that be a separate pr? The above feedback seems to support merging this pr now except, BeanValidationEE8TestCase wasn't addressed yet.

@jamezp

This comment has been minimized.

Copy link
Member Author

jamezp commented Jul 16, 2018

@scottmarlow It was moved in commit 5ddf0bf. It's the third commit.

@kabir kabir merged commit 3496a55 into wildfly:master Jul 18, 2018
5 checks passed
5 checks passed
Linux Finished TeamCity Build WildFly :: Pull Request :: Linux : Tests passed: 4421, ignored: 145
Details
Linux - elytron (Pull Request) - merge TeamCity build finished
Details
Linux JDK10 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager Finished TeamCity Build WildFly :: Pull Request :: Linux SM : Tests passed: 1191, ignored: 76
Details
Windows Finished TeamCity Build WildFly :: Pull Request :: Windows : Tests passed: 4418, ignored: 147
Details
@jamezp jamezp deleted the jamezp:WFLY-10288 branch Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.