Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-11752 testsuite/integration/elytron uses directly a jboss.dist d… #12094

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@OndrejKotek
Copy link
Contributor

OndrejKotek commented Feb 20, 2019

…ir when set instead of its copy in the target dir

https://issues.jboss.org/browse/WFLY-11752

When the jboss.dist property is set for the mvn command, the testsuite/integration/elytron project uses directly a server distribution in the jboss.dist directory instead of its copy in the target/wildfly directory, and the distribution is customized with the modify-elytron-config.cli script.
As a result, when running the test suite in the elytron mode (-Delytron), the next testing module (compat) fails.

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • [ x ] Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
  • [ x ] Pull Request contains link to the JIRA issue(s)
  • [ x ] Pull Request contains description of the issue(s)
  • [ x ] Pull Request does not include fixes for issues other than the main ticket
  • [ x ] Attached commits represent units of work and are properly formatted

For bigger changes, major and minor component upgrades make sure your PR also meets following requirements:

  • Pull Request requires a change to the documentation
  • Documentation have been updated accordingly
  • Tests were added to cover changes

For new features ensure as well:

  • Analysis was done
  • Test Plan has been done
  • Tests were verified in advance

If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.

@OndrejKotek

This comment has been minimized.

Copy link
Contributor Author

OndrejKotek commented Feb 21, 2019

@bstansberry WDYT please?

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Mar 21, 2019

@OndrejKotek I don't know if this is right or not for the jboss.dist case but since that's not a particularly relevant case for normal WildFly testing and nothing changes for the !jboss.dist case, I'm fine with this if it works for you.

Needs a rebase though.

@OndrejKotek OndrejKotek force-pushed the OndrejKotek:wfly-11752 branch from bfb8955 to b0aec7c Mar 22, 2019
@OndrejKotek

This comment has been minimized.

Copy link
Contributor Author

OndrejKotek commented Mar 22, 2019

@bstansberry, thank you, the jboss.dist case works for me, rebased.

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Apr 5, 2019

retest this please

Copy link
Contributor

bstansberry left a comment

Tests fail now.

…ir when set instead of its copy in the target dir
@OndrejKotek OndrejKotek force-pushed the OndrejKotek:wfly-11752 branch from b0aec7c to 3cd57bb Apr 17, 2019
@wildfly-ci wildfly-ci added the deps-ok label Apr 17, 2019
@OndrejKotek

This comment has been minimized.

Copy link
Contributor Author

OndrejKotek commented Apr 18, 2019

@bstansberry Fixed.

@bstansberry bstansberry merged commit 71de3e7 into wildfly:master Apr 24, 2019
5 of 7 checks passed
5 of 7 checks passed
Linux - JDK 11 (Pull Request) - merge TeamCity build failed
Details
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests failed: 1 (1 new), passed: 4831, ignored: 138
Details
Dependency Tree (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4857, ignored: 134
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4513, ignored: 152
Details
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4848, ignored: 141
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.