Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFLY-11752 testsuite/integration/elytron uses directly a jboss.dist d… #12094
Conversation
This comment has been minimized.
This comment has been minimized.
|
@bstansberry WDYT please? |
This comment has been minimized.
This comment has been minimized.
|
@OndrejKotek I don't know if this is right or not for the jboss.dist case but since that's not a particularly relevant case for normal WildFly testing and nothing changes for the !jboss.dist case, I'm fine with this if it works for you. Needs a rebase though. |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry, thank you, the jboss.dist case works for me, rebased. |
This comment has been minimized.
This comment has been minimized.
|
retest this please |
|
Tests fail now. |
…ir when set instead of its copy in the target dir
This comment has been minimized.
This comment has been minimized.
|
@bstansberry Fixed. |
71de3e7
into
wildfly:master
5 of 7 checks passed
5 of 7 checks passed
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests failed: 1 (1 new), passed: 4831, ignored: 138
Details
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4857, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4513, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4848, ignored: 141
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
OndrejKotek commentedFeb 20, 2019
…ir when set instead of its copy in the target dir
https://issues.jboss.org/browse/WFLY-11752
When the jboss.dist property is set for the mvn command, the testsuite/integration/elytron project uses directly a server distribution in the jboss.dist directory instead of its copy in the target/wildfly directory, and the distribution is customized with the modify-elytron-config.cli script.
As a result, when running the test suite in the elytron mode (-Delytron), the next testing module (compat) fails.
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[WFLY-XYZ] SubjectorWFLY-XYZ SubjectFor bigger changes, major and minor component upgrades make sure your PR also meets following requirements:
For new features ensure as well:
If you are not an active contributor of the WildFly project you can request sponsorship by one of the members to help guide you through the process.