Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11896] Improve ability of mixed-domain testsuite to deal with different JVMs #12182
Conversation
…ifferent JVMs MisxedDomainTestSupport will trigger caller (i.e a TestSuite) being ignored if the version under test can't handle the JVMs on offer. Test jobs can be configured with different java home paths for different JVMs. If this is done MixedDomainTestSupport will try and use an appropriate one for the legacy host.
This comment has been minimized.
This comment has been minimized.
|
I put the core-upgrade-needed on this because for the 'pass in the alternate java home' thing to work properly https://issues.jboss.org/browse/WFCORE-4383 needs to be fixed. |
This comment has been minimized.
This comment has been minimized.
|
retest this please |
bstansberry
merged commit 7c60736
into
wildfly:master
7 of 9 checks passed
7 of 9 checks passed
Windows
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests failed: 17 (17 new), passed: 4614, ignored: 139
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests failed: 1 (1 new), passed: 4614, ignored: 135
Details
Linux
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4839, ignored: 134
Details
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4842, ignored: 134
Details
Linux with security manager
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4495, ignored: 152
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4498, ignored: 152
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 1521, ignored: 69
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bstansberry commentedMar 23, 2019
MERGERS: If this is ok, please let me merge it. I want to make some CI config changes associated with that, and merging this will be my reminder to do those.
MixedDomainTestSupport will trigger caller (i.e a TestSuite) being ignored if the version under test can't handle the JVMs on offer.
Test jobs can be configured with different java home paths for different JVMs. If this is done MixedDomainTestSupport will try and use an appropriate one for the legacy host.
https://issues.jboss.org/browse/WFLY-11896
Also: Remove unneeded mixed domain Version enums