Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11911] Remove READ_TIMEOUT from channel configuration options #12187
Conversation
|
The equivalent change needs to be made in ejb3/src/main/resources/subsystem-templates/ejb3.xml That file drives what ends up in build-legacy and dist-legacy, which we're still maintaining as an aid in checking the the build output from our Galleon-based builds is doing what we expect. |
This comment has been minimized.
This comment has been minimized.
|
@chengfang @tadamski FYI. This change is correct; i.e. other options besides the ones mentioned in the JIRA have no effect so we shouldn't put them in our standard config. @tmiyargi Can you update the JIRA description with more info why only the listed ones are meaningful? It's not obvious and that will save people researching. AIUI it's because org.jboss.remoting3.remote.RemoteReadListener, the ultimate consumer of the options, only processes the ones you listed. |
[WFLY-11911] Remove READ_TIMEOUT from cannel configuration options
06ca2a1
into
wildfly:master
tmiyargi commentedMar 27, 2019
•
edited
Issue: https://issues.jboss.org/browse/WFLY-11911
READ_TIMEOUT cannot be set as channel option as sample configuration is missleading.
The only configuration options allowed on the channel by the ultimate consumer of the options org.jboss.remoting3.remote.RemoteReadListener are
RemotingOptions.TRANSMIT_WINDOW_SIZE,
RemotingOptions.MAX_OUTBOUND_MESSAGES
RemotingOptions.RECEIVE_WINDOW_SIZE
RemotingOptions.MAX_INBOUND_MESSAGES
RemotingOptions.MAX_OUTBOUND_MESSAGE_SIZE
RemotingOptions.MAX_INBOUND_MESSAGE_SIZE.