Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11911] Remove READ_TIMEOUT from channel configuration options #12187

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@tmiyargi
Copy link
Contributor

tmiyargi commented Mar 27, 2019

Issue: https://issues.jboss.org/browse/WFLY-11911

READ_TIMEOUT cannot be set as channel option as sample configuration is missleading.

The only configuration options allowed on the channel by the ultimate consumer of the options org.jboss.remoting3.remote.RemoteReadListener are
RemotingOptions.TRANSMIT_WINDOW_SIZE,
RemotingOptions.MAX_OUTBOUND_MESSAGES
RemotingOptions.RECEIVE_WINDOW_SIZE
RemotingOptions.MAX_INBOUND_MESSAGES
RemotingOptions.MAX_OUTBOUND_MESSAGE_SIZE
RemotingOptions.MAX_INBOUND_MESSAGE_SIZE.

Copy link
Contributor

bstansberry left a comment

The equivalent change needs to be made in ejb3/src/main/resources/subsystem-templates/ejb3.xml

That file drives what ends up in build-legacy and dist-legacy, which we're still maintaining as an aid in checking the the build output from our Galleon-based builds is doing what we expect.

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Mar 27, 2019

@chengfang @tadamski FYI. This change is correct; i.e. other options besides the ones mentioned in the JIRA have no effect so we shouldn't put them in our standard config.

@tmiyargi Can you update the JIRA description with more info why only the listed ones are meaningful? It's not obvious and that will save people researching. AIUI it's because org.jboss.remoting3.remote.RemoteReadListener, the ultimate consumer of the options, only processes the ones you listed.

@tmiyargi tmiyargi force-pushed the tmiyargi:WFLY-11911 branch from f5412ce to 6894e74 Mar 28, 2019
@tmiyargi tmiyargi changed the title [WFLY-11911] Remove READ_TIMEOUT from cannel configuration options [WFLY-11911] Remove READ_TIMEOUT from channel configuration options Apr 4, 2019
jamezp added a commit that referenced this pull request Apr 4, 2019
[WFLY-11911] Remove READ_TIMEOUT from cannel configuration options
@jamezp jamezp merged commit 06ca2a1 into wildfly:master Apr 4, 2019
5 of 6 checks passed
5 of 6 checks passed
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests failed: 2 (2 new), passed: 4831, ignored: 139
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4839, ignored: 134
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4495, ignored: 152
Details
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4612, ignored: 135
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.