Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFLY-11807 Auto-configure external address/port for FD_SOCK protocol based on socket binding's client mappings #12188
Conversation
This comment has been minimized.
This comment has been minimized.
|
retest this please |
This comment has been minimized.
This comment has been minimized.
|
@rhusar Please review. Seems ok to me but sadly if there was something subtly wrong re JGroups integration I'd likely not notice. :( |
|
|
bstansberry
merged commit 8f6c2ec
into
wildfly:master
6 checks passed
6 checks passed
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4842, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4498, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4615, ignored: 135
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4835, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pferraro commentedMar 27, 2019
•
edited
https://issues.jboss.org/browse/WFLY-11807
JGroups subsystem transformer tests will fail until wildfly-core is updated to contain wildfly/wildfly-core#3716