Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11915] Test case for passing a remote EJB Exception by reference (WFLY-11866) #12191
Conversation
This comment has been minimized.
This comment has been minimized.
|
I would consider the test as not complete. There should be the following tests
|
|
Can we please try and use meaningful commit messages that help in the future. When looking through the git history in 5 years time or an annotated view of source messages like "Test for WFLY-11866" don't reveal much unless you manually open the referenced Jira issues - when looking at a class with a lot of updates you can end up cross referencing quite a few issues. |
tmiyargi
changed the title
tmiyargi
force-pushed the
tmiyargi:WFLY-11866
branch
2 times, most recently
from
3cdb9f6
to
653c528
...java/org/jboss/as/test/integration/ejb/remote/byreference/HelloBean.java
Outdated
Show resolved
Hide resolved
...va/org/jboss/as/test/integration/ejb/remote/byreference/HelloRemote.java
Outdated
Show resolved
Hide resolved
...ss/as/test/integration/ejb/remote/byreference/NonSerializableObject.java
Outdated
Show resolved
Hide resolved
.../test/integration/ejb/remote/byreference/RemoteByReferenceException.java
Outdated
Show resolved
Hide resolved
...jboss/as/test/integration/ejb/remote/byreference/SerializableObject.java
Outdated
Show resolved
Hide resolved
.../jboss/as/test/integration/ejb/remote/byreference/TransferParameter.java
Outdated
Show resolved
Hide resolved
...boss/as/test/integration/ejb/remote/byreference/TransferReturnValue.java
Outdated
Show resolved
Hide resolved
…e (WFLY-11866)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
done
…On Thu, Apr 4, 2019 at 6:52 PM Brian Stansberry ***@***.***> wrote:
@tmiyargi <https://github.com/tmiyargi> In the future please send the
test to the original fix author for inclusion in that PR so the fix can be
tested automatically by CI.
@wfink <https://github.com/wfink> is going to cherry-pick this commit
into his branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12191 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABL91N6M7CB8XsBT5zassAHrJ6oyawwCks5vdi3XgaJpZM4cQS7v>
.
--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael O'Neill, Tom Savage, Eric Shander
|
This comment has been minimized.
This comment has been minimized.
|
Closing as the commit was merged as part of #12167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tmiyargi commentedMar 28, 2019
Issue: https://issues.jboss.org/browse/WFLY-11915
The test will fail until https://issues.jboss.org/browse/WFLY-11866 gets merged