Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFLY-9477: avoid registering ROOT.war as default web module more than… #12198
Conversation
… once
This comment has been minimized.
This comment has been minimized.
|
@fl4via Please review. |
|
This looks good to me |
This comment has been minimized.
This comment has been minimized.
|
Retest this please |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry done |
bstansberry
merged commit 28f528a
into
wildfly:master
5 of 6 checks passed
5 of 6 checks passed
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests failed: 23 (23 new), passed: 4821, ignored: 139
Details
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4508, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4843, ignored: 141
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
michpetrov commentedApr 2, 2019
… once
Issue: WFLY-9477
default-web-moduleis an optional attribute with default value "ROOT.war" but because the module names have to be unique per server it essentially becomes required. Since you can control which host to deploy to in other ways the simplest solution would be to remove the default value. However some users may depend on the default value so I propose to register "ROOT.war" once and then ignore it if it's used by other hosts.