[WFLY-11932] Use HTTPS for repository and pluginRepository URLs

[bstansberry]

https://issues.jboss.org/browse/WFLY-11932

[jamezp]

Should we change all the links to the licenses to be https as well? For example

wildfly/feature-pack/src/license/full-feature-pack-licenses.xml

Line 191 in 7169e62

<url>http://repository.jboss.org/licenses/epl-1.0.txt</url>

.

Maybe in the Example_subsystem.adoc too.

[bstansberry]

@jamezp Sure, I'll change the Example_subsystem; it's somewhat related; might as well give good advice.

@psakar @dosoudil Are files like https://github.com/wildfly/wildfly/blob/7169e62f33e77aeb6fdbcc22031204c1d754026e/feature-pack/src/license/full-feature-pack-licenses.xml relevant to WFLY-11932? The point here is when WildFly is built we want it to use HTTPS to pull down things that end up in our dist. I forget whether the license plugin pulls anything down.

[bstansberry]

@jamezp I went ahead and updated the [full|servlet]-feature-pack-licenses.xml files, regardless of my question above (which I'm still curious about.) For all the URLs, https works so might as well use that.

[psakar]

@bstansberry licenses are not downloaded during build, they must be already present in the feature pack's folder src/main/resources/content/docs/licenses (eg https://github.com/wildfly/wildfly/tree/master/feature-pack/src/main/resources/content/docs/licenses)
List of approved licenses (their urls) should be updated first (or procedure checking those urls)

[bstansberry]

@psakar Thanks. I'll drop that last commit then as it's not relevant to the purpose of the JIRA.

[bstansberry]

@psakar WDYT about the new commit I added here? It's your idea of allowing -D to control this. I made the prop just control the protocol vs the whole URL, figuring that would be easier to use, but the entire URL could be configurable if there's a benefit.

[psakar]

I personally think that ability to control whole url is better (gives you chance to use different repo), OTOH for the purpose of being able to use http protocol to be able to use maven proxy this is perfectly valid

[bstansberry]

I'll add a second property, which uses this one for the protocol part of its default value.

[bstansberry]

@psakar Done