Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11944] Some clustering test cases do not close JNDI context between tests #12207
Conversation
…ween tests.
| * NOTE: | ||
| * if you hold a static reference to this class, it causes any JNDI lookups across different tests to use the same discovered node registry (DNR). | ||
| * This can cause server starts and stops in one test to contaminate other tests and produce incorrect results. | ||
| * It is adviseable to use one instance per test by defining a @Before and @After method to create and dispose of the instance on a per test basis. |
This comment has been minimized.
This comment has been minimized.
pferraro
Apr 4, 2019
Contributor
Generally, it is inadvisable to hold any references to an EJBDirectory.
The preferred pattern of usage is:
for (EJBDirectory directory = new RemoteEJBDirectory(MODULE_NAME)) {
// lookup EJBs
// invoke EJBs
// remove EJBs
}
bstansberry
merged commit 9c7871a
into
wildfly:master
5 of 6 checks passed
5 of 6 checks passed
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests failed: 1 (1 new), passed: 4614, ignored: 135
Details
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4842, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4498, ignored: 152
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4835, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rachmatowicz commentedApr 4, 2019
This PR adjusts the use of RemoteEJBDirectory for a few clustering test cases, making it non-static as opposed to static. Static use is not advised as it negatively affects EJB client invocation.
The JIRA issue: https://issues.jboss.org/browse/WFLY-11944