Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-11946/WFLY-10340 Remove unneeded dependencies from OpenJPA module #12208

Merged

Conversation

@scottmarlow
Copy link
Contributor

scottmarlow commented Apr 4, 2019

https://issues.jboss.org/browse/WFLY-10340 (Enable OpenJPA integration tests for Java 10)
https://issues.jboss.org/browse/WFLY-11946 (Remove unneeded dependencies from OpenJPA module)

As per http://openjpa.apache.org/build-and-runtime-dependencies.html, we don't need the org.apache.commons.lang dependency, as openjpa-all.jar includes that and other dependencies.

Also updated doc accordingly (current doc is at https://docs.wildfly.org/16/Developer_Guide.html#migrating-from-openjpa).

@bstansberry bstansberry merged commit db287c9 into wildfly:master Apr 5, 2019
5 of 6 checks passed
5 of 6 checks passed
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Execution timeout (new); tests failed: 1 (1 new), passed: 4202, ignore…
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4839, ignored: 133
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4499, ignored: 151
Details
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4836, ignored: 138
Details
@tomjenkinson

This comment has been minimized.

Copy link
Contributor

tomjenkinson commented Apr 5, 2019

Is this definitely OK? I looked at the html doc you referenced and it seems that the open-jpa-all.jar is for Java SE environments rather than Java EE?

@scottmarlow

This comment has been minimized.

Copy link
Contributor Author

scottmarlow commented Apr 5, 2019

@tomjenkinson no problem since we currently use a modular class loader, that provides an isolated classloader for the OpenJPA module.

If you are migrating a large application to WildFly, rewriting all of your database interaction code to use Hibernate, might not be the first thing that you want to do, while you are evaluating WildFly, instead you can delay that by setting up OpenJPA (or EclipseLink), just like other application servers allow. If it was really important to you as a user, to not use open-jpa-all.jar, you could include the individual jars instead somehow (e.g. either inline or via other modules that you add or use).

@scottmarlow scottmarlow deleted the scottmarlow:WFLY-11946_openjpa_dependencies branch Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.