Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFLY-11946/WFLY-10340 Remove unneeded dependencies from OpenJPA module #12208
Conversation
db287c9
into
wildfly:master
This comment has been minimized.
This comment has been minimized.
|
Is this definitely OK? I looked at the html doc you referenced and it seems that the open-jpa-all.jar is for Java SE environments rather than Java EE? |
This comment has been minimized.
This comment has been minimized.
|
@tomjenkinson no problem since we currently use a modular class loader, that provides an isolated classloader for the OpenJPA module. If you are migrating a large application to WildFly, rewriting all of your database interaction code to use Hibernate, might not be the first thing that you want to do, while you are evaluating WildFly, instead you can delay that by setting up OpenJPA (or EclipseLink), just like other application servers allow. If it was really important to you as a user, to not use open-jpa-all.jar, you could include the individual jars instead somehow (e.g. either inline or via other modules that you add or use). |
scottmarlow commentedApr 4, 2019
https://issues.jboss.org/browse/WFLY-10340 (Enable OpenJPA integration tests for Java 10)
https://issues.jboss.org/browse/WFLY-11946 (Remove unneeded dependencies from OpenJPA module)
As per http://openjpa.apache.org/build-and-runtime-dependencies.html, we don't need the org.apache.commons.lang dependency, as openjpa-all.jar includes that and other dependencies.
Also updated doc accordingly (current doc is at https://docs.wildfly.org/16/Developer_Guide.html#migrating-from-openjpa).