Skip to content

/ wildfly

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11672] @ApplicationScoped does not work when used with @ServerEndpoint #12214

Merged
merged 1 commit into from Apr 9, 2019
Merged

[WFLY-11672] @ApplicationScoped does not work when used with @ServerEndpoint #12214

merged 1 commit into from Apr 9, 2019

Conversation

@MMarus
Copy link
Contributor

MMarus commented Apr 5, 2019

Wildfly issue: https://issues.jboss.org/browse/WFLY-11672

This fixes injection of bean which has combination of @ApplicationScoped and @ServerEndpoint annotations.

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [WFLY-XYZ] Subject or WFLY-XYZ Subject
  • Pull Request contains link to the JIRA issue(s)
  • Pull Request contains description of the issue(s)
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
@MMarus MMarus force-pushed the MMarus:WFLY-11672-@ApplicationScoped-does-not-work-when-used-with-@ServerEndpoint branch from 4437da0 to 4e83b6e Apr 5, 2019
@wildfly-ci

This comment has been minimized.

Sign in to view
Copy link

wildfly-ci commented Apr 5, 2019

Can one of the admins verify this patch?
@kabir

This comment has been minimized.

Sign in to view
Copy link
Contributor

kabir commented Apr 8, 2019

This is ok to test
@kabir

This comment has been minimized.

Sign in to view
Copy link
Contributor

kabir commented Apr 8, 2019

@MMarus I think it looks ok, but there are some checkstyle errors
@kabir kabir added the fixme label Apr 8, 2019
@MMarus
[WFLY-11672] @ApplicationScoped does not work when used with @ServerE…
Loading status checks…
274bc3f 
…ndpoint
@MMarus MMarus force-pushed the MMarus:WFLY-11672-@ApplicationScoped-does-not-work-when-used-with-@ServerEndpoint branch from 4e83b6e to 274bc3f Apr 8, 2019
@MMarus

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

MMarus commented Apr 9, 2019

Thank you @kabir I fixed it. I am sorry, I must have run the build without checkstyle on.
@kabir kabir merged commit ac5f5ca into wildfly:master Apr 9, 2019
6 checks passed
6 checks passed
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4508, ignored: 152
Details
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4843, ignored: 141
Details
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixme ready-for-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@MMarus @wildfly-ci @kabir
You can’t perform that action at this time.