Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-9954] Fixing too many services and dependencies created for EJBs issue #12215
Conversation
|
Just restating what this does, in case I'm wrong: This adds a service per component but by doing so reduces the number of dependencies another service has by replacing 5 dependencies with 1 dependency. |
| @@ -29,8 +29,11 @@ | |||
| import org.jboss.as.server.deployment.DeploymentUnitProcessingException; | |||
| import org.jboss.as.server.deployment.DeploymentUnitProcessor; | |||
|
|
|||
| import java.util.HashMap; | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -85,7 +90,9 @@ private void bindServices(DeploymentUnit deploymentUnit, ServiceTarget serviceTa | |||
| serviceTarget.addService(inAppClientServiceName, inAppClientContainerService) | |||
| .addDependency(contextServiceName, ServiceBasedNamingStore.class, inAppClientContainerService.getNamingStoreInjector()) | |||
| .install(); | |||
| deploymentUnit.addToAttachmentList(org.jboss.as.server.deployment.Attachments.JNDI_DEPENDENCIES, inAppClientServiceName); | |||
| final Map<ServiceName, Set<ServiceName>> jndiComponentDependencies = deploymentUnit.getAttachment(org.jboss.as.server.deployment.Attachments.COMPONENT_JNDI_DEPENDENCIES); | |||
| final Set<ServiceName> jndiDependencies = jndiComponentDependencies.computeIfAbsent(contextServiceName, k-> new HashSet<>()); | |||
This comment has been minimized.
This comment has been minimized.
bstansberry
Apr 9, 2019
Contributor
Using a lambda like this instead a few lines to do a get and if null, a put, adds to the amount of metaspace the server needs.
This comment has been minimized.
This comment has been minimized.
from o.j.a.s.d.Attachments.JNDI_DEPENDENCIES to o.j.a.s.d.Attachments.COMPONENT_JNDI_DEPENDENCIES attachment. Before this fix JNDI_DEPENDENCY_SERVICE had too many dependencies. With this fix applied JNDI_DEPENDENCY_SERVICE will now depend on JNDI_AGGREGATION_SERVICES and these aggregation services will reference COMPONENT_JNDI_DEPENDENCIES that were referenced by JNDI_DEPENDENCY_SERVICE before. In other words we are decreasing JNDI_DEPENDENCY_SERVICE dependencies count and reorganizing (simplifying) its dependency tree.
This comment has been minimized.
This comment has been minimized.
|
Correct @bstansberry but we are replacing not 5 but just 4 dependencies with one intermediary aggregating dependency. This will allow us to deploy more than 7000 EJBs per deployment since now on. |
|
I count 5; two in TransactionJndiBindingProcessor. ;) |
This comment has been minimized.
This comment has been minimized.
|
You're of course right @bstansberry . I shouldn't even make elementary counting if I'm tired :) |
bstansberry
merged commit c3c150e
into
wildfly:master
6 checks passed
6 checks passed
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4508, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4843, ignored: 141
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ropalka commentedApr 5, 2019
https://issues.jboss.org/browse/WFLY-9954
Moving component related JNDI dependencies from o.j.a.s.d.Attachments.JNDI_DEPENDENCIES
to o.j.a.s.d.Attachments.COMPONENT_JNDI_DEPENDENCIES attachment.
Before this fix JNDI_DEPENDENCY_SERVICE had too many dependencies.
With this fix applied JNDI_DEPENDENCY_SERVICE will now depend on
JNDI_AGGREGATION_SERVICES and these aggregation services
will reference COMPONENT_JNDI_DEPENDENCIES that were referenced
by JNDI_DEPENDENCY_SERVICE before. In other words we are decreasing
JNDI_DEPENDENCY_SERVICE dependencies count and reorganizing (simplifying)
its dependency tree.