Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11979] Stop using jboss fork of glassfish el impl; move to v3.0.2 #12223

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@bstansberry
Copy link
Contributor

bstansberry commented Apr 12, 2019

https://issues.jboss.org/browse/WFLY-11979

@psakar Please note that this brings in a new license --EPL 2.0.

@psakar

This comment has been minimized.

Copy link
Contributor

psakar commented Apr 12, 2019

@bstansberry According to https://projects.eclipse.org/projects/ee4j.el there are two licenses
Eclipse Public License 2.0
GNU General Public License, version 2 with the GNU Classpath Exception

@psakar

This comment has been minimized.

Copy link
Contributor

psakar commented Apr 12, 2019

@bstansberry Pom file for given version http://central.maven.org/maven2/org/glassfish/jakarta.el/3.0.2/jakarta.el-3.0.2.pom references scm repo https://github.com/eclipse-ee4j/el-ri.git which does not contain the tag for the version ...

@bstansberry

This comment has been minimized.

Copy link
Contributor Author

bstansberry commented Apr 12, 2019

@bstansberry

This comment has been minimized.

Copy link
Contributor Author

bstansberry commented Apr 12, 2019

@psakar Re the two licenses, they are there. The second just doesn't show up in the diff because the chunk of xml didn't need to change.

https://github.com/wildfly/wildfly/pull/12223/files#diff-3798148b2e9669a445324ad441bfa1adR171

@bstansberry

This comment has been minimized.

Copy link
Contributor Author

bstansberry commented Apr 12, 2019

@tmiyargi FYI re this proposed change.

@psakar

This comment has been minimized.

Copy link
Contributor

psakar commented Apr 15, 2019

@bstansberry thank you for answers, sorry for confusion

@psakar

This comment has been minimized.

Copy link
Contributor

psakar commented Apr 15, 2019

@kabir what is the result of your check for this PR ?

@kabir

This comment has been minimized.

Copy link
Contributor

kabir commented Apr 16, 2019

@psakar @bstansberry The check should be fixed now

@wildfly-ci wildfly-ci added deps-ok and removed deps-changed labels Apr 16, 2019
@kabir kabir removed the deps-ok label Apr 16, 2019
@wildfly wildfly deleted a comment from wildfly-ci Apr 16, 2019
@wildfly-ci

This comment has been minimized.

Copy link

wildfly-ci commented Apr 16, 2019

Dependency Tree Analyzer Output:

New Dependencies:

  • org.glassfish:jakarta.el:jar:3.0.2:compile

Removed Dependencies:

  • org.glassfish:javax.el-impl:jar:3.0.1-b08-jbossorg-1:compile
@kabir kabir merged commit d604e13 into wildfly:master Apr 17, 2019
7 checks passed
7 checks passed
Dependency Tree (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4848, ignored: 134
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4508, ignored: 152
Details
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4846, ignored: 141
Details
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
@tmiyargi

This comment has been minimized.

Copy link
Contributor

tmiyargi commented Apr 22, 2019

@bstansberry FYI: org.glassfish:jakarta.el:jar:3.0.2 includes the API and the implementation, but we also include the API in javax.el.api:jboss-el-api_3.0_spec-1.0.13.Final-redhat-00001.jar and jakarta.el has a dependency to it... old el-impl did only contain the implementation.

@bstansberry bstansberry deleted the bstansberry:WFLY-11979 branch Apr 22, 2019
@bstansberry

This comment has been minimized.

Copy link
Contributor Author

bstansberry commented Apr 22, 2019

@tmiyargi

Yes, suppressing the included impl is what https://github.com/wildfly/wildfly/pull/12223/files#diff-4228df7d73dcdfe524b5a425e215b38dR33 is about.

If that approach doesn't work I'll revert this and restart the old el-impl project. We need our javax.el.api:jboss-el-api_3.0_spec as it includes custom code that we won't drop unless it's proven unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.