Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11979] Stop using jboss fork of glassfish el impl; move to v3.0.2 #12223
Conversation
This comment has been minimized.
This comment has been minimized.
|
@bstansberry According to https://projects.eclipse.org/projects/ee4j.el there are two licenses |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry Pom file for given version http://central.maven.org/maven2/org/glassfish/jakarta.el/3.0.2/jakarta.el-3.0.2.pom references scm repo https://github.com/eclipse-ee4j/el-ri.git which does not contain the tag for the version ... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@psakar Re the two licenses, they are there. The second just doesn't show up in the diff because the chunk of xml didn't need to change. https://github.com/wildfly/wildfly/pull/12223/files#diff-3798148b2e9669a445324ad441bfa1adR171 |
This comment has been minimized.
This comment has been minimized.
|
@tmiyargi FYI re this proposed change. |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry thank you for answers, sorry for confusion |
This comment has been minimized.
This comment has been minimized.
|
@kabir what is the result of your check for this PR ? |
This comment has been minimized.
This comment has been minimized.
|
@psakar @bstansberry The check should be fixed now |
This comment has been minimized.
This comment has been minimized.
wildfly-ci
commented
Apr 16, 2019
|
Dependency Tree Analyzer Output: New Dependencies:
Removed Dependencies:
|
d604e13
into
wildfly:master
This comment has been minimized.
This comment has been minimized.
|
@bstansberry FYI: org.glassfish:jakarta.el:jar:3.0.2 includes the API and the implementation, but we also include the API in javax.el.api:jboss-el-api_3.0_spec-1.0.13.Final-redhat-00001.jar and jakarta.el has a dependency to it... old el-impl did only contain the implementation. |
This comment has been minimized.
This comment has been minimized.
|
Yes, suppressing the included impl is what https://github.com/wildfly/wildfly/pull/12223/files#diff-4228df7d73dcdfe524b5a425e215b38dR33 is about. If that approach doesn't work I'll revert this and restart the old el-impl project. We need our javax.el.api:jboss-el-api_3.0_spec as it includes custom code that we won't drop unless it's proven unnecessary. |
bstansberry commentedApr 12, 2019
https://issues.jboss.org/browse/WFLY-11979
@psakar Please note that this brings in a new license --EPL 2.0.