Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-11985] Upgrade Commons Codec to 1.11 #12226

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

@ivassile
Copy link
Contributor

ivassile commented Apr 12, 2019

https://issues.jboss.org/browse/WFLY-11985

Upgrading Commons Codec to 1.11

Release notes: https://commons.apache.org/proper/commons-codec/changes-report.html#a1.11
Source diff: apache/commons-codec@1.10...commons-codec-1.11
The pom only has test dependencies, so this should not drive a requirement for upgrading other dependents.

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Apr 14, 2019

@jimma @ronsigal @fjuma @yrodiere Any objections?

Primary uses are CXF, RESTEasy, Lucene, MyFaces, com.sun.jsf-impl.

See the description for release notes and source diff. This is a minor version upgrade.

The pom only has test dependencies.

@yrodiere

This comment has been minimized.

Copy link
Contributor

yrodiere commented Apr 15, 2019

@bstansberry Lucene does not depend on commons-codec as far as I can tell. In fact it doesn't depend on anything.

Could you please point me what made you think otherwise? I've been wrong before.

The only way this could impact Hibernate Search is through the optional Apache Tika dependency, or the Elasticsearch integration, but as far as I know none of them is included in WildFly.

@jimma

This comment has been minimized.

Copy link
Contributor

jimma commented Apr 15, 2019

@bstansberry This upgrade is OK for CXF.

@wildfly-ci wildfly-ci added the deps-ok label Apr 15, 2019
@fjuma

This comment has been minimized.

Copy link
Contributor

fjuma commented Apr 15, 2019

This upgrade is ok for JSF.

@bstansberry

This comment has been minimized.

Copy link
Contributor

bstansberry commented Apr 15, 2019

@yrodiere My apologies! I was grepping our module.xml files looking for uses and wasn't careful enough. The lucene module has the completely irrelevant...

artifact name="${org.apache.lucene:lucene-backward-codecs}"

@kabir kabir merged commit 3839ec0 into wildfly:master Apr 16, 2019
7 checks passed
7 checks passed
Dependency Tree (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 11 (Pull Request) - merge TeamCity build finished
Details
Linux - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4852, ignored: 134
Details
Linux - elytron - JDK 8 (Pull Request) - merge TeamCity build finished
Details
Linux with security manager - JDK 8 Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4508, ignored: 152
Details
Windows - JDK 11 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4843, ignored: 141
Details
Windows - JDK 8 Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4845, ignored: 139
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.