Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-11985] Upgrade Commons Codec to 1.11 #12226
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bstansberry Lucene does not depend on commons-codec as far as I can tell. In fact it doesn't depend on anything. Could you please point me what made you think otherwise? I've been wrong before. The only way this could impact Hibernate Search is through the optional Apache Tika dependency, or the Elasticsearch integration, but as far as I know none of them is included in WildFly. |
This comment has been minimized.
This comment has been minimized.
|
@bstansberry This upgrade is OK for CXF. |
This comment has been minimized.
This comment has been minimized.
|
This upgrade is ok for JSF. |
This comment has been minimized.
This comment has been minimized.
|
@yrodiere My apologies! I was grepping our module.xml files looking for uses and wasn't careful enough. The lucene module has the completely irrelevant... artifact name="${org.apache.lucene:lucene-backward-codecs}" |
3839ec0
into
wildfly:master
ivassile commentedApr 12, 2019
•
edited by bstansberry
https://issues.jboss.org/browse/WFLY-11985
Upgrading Commons Codec to 1.11
Release notes: https://commons.apache.org/proper/commons-codec/changes-report.html#a1.11
Source diff: apache/commons-codec@1.10...commons-codec-1.11
The pom only has test dependencies, so this should not drive a requirement for upgrading other dependents.