Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWFLY-12006 EJB3 IIOP attributes enable-by-default and use-qualified-name should be required #12237
Conversation
|
EJB3IIOPAdd can be cleaned up a bit too; in performBoottime when it reads these values it should assign to 'boolean' variables, not 'Boolean'. Technically the EJB subsystem management API version should be bumped for this, but, meh. I think it was never possible to effectively not define these if the resource was added. |
| @@ -57,12 +57,14 @@ | |||
| new SimpleAttributeDefinitionBuilder(EJB3SubsystemModel.USE_QUALIFIED_NAME, ModelType.BOOLEAN, true) | |||
| .setAllowExpression(true) | |||
| .setFlags(AttributeAccess.Flag.RESTART_NONE) | |||
| .setRequired(true) | |||
This comment has been minimized.
This comment has been minimized.
bstansberry
Apr 22, 2019
Contributor
Please remove the 'true' from L57 as that says the opposite of this setRequired(true).
| .build(); | ||
|
|
||
| static final SimpleAttributeDefinition ENABLE_BY_DEFAULT = | ||
| new SimpleAttributeDefinitionBuilder(EJB3SubsystemModel.ENABLE_BY_DEFAULT, ModelType.BOOLEAN, true) | ||
| .setAllowExpression(true) | ||
| .setFlags(AttributeAccess.Flag.RESTART_NONE) | ||
| .setRequired(true) |
This comment has been minimized.
This comment has been minimized.
bstansberry
Apr 22, 2019
Contributor
Please remove the 'true' from L64 as that says the opposite of this setRequired(true).
soul2zimate
force-pushed the
soul2zimate:WFLY-12006-master
branch
from
0efc900
to
bac1a1f
This comment has been minimized.
This comment has been minimized.
|
Thanks, I have updated as per review request. I also removed opposite optional value "true" in three other classes. |
bstansberry
merged commit 216a681
into
wildfly:master
7 checks passed
7 checks passed
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4857, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4513, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4848, ignored: 141
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4850, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
soul2zimate commentedApr 18, 2019
https://issues.jboss.org/browse/WFLY-12006
Update attributes enable-by-default and use-qualified-name to required.
Because enable-by-default and use-qualified-name must be required during parsing at https://github.com/wildfly/wildfly/blob/16.0.0.Final/ejb3/src/main/java/org/jboss/as/ejb3/subsystem/EJB3Subsystem12Parser.java#L227