Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[WFLY-10798] Setting correct TCCL for Datasource constructor #12244
Conversation
This comment has been minimized.
This comment has been minimized.
|
@fl4via @tadamski since this is follow up to ironjacamar/ironjacamar#680 you reviewed, could you please take a look at this? |
This comment has been minimized.
This comment has been minimized.
|
@maeste FYI. |
bstansberry
merged commit 948d860
into
wildfly:master
7 checks passed
7 checks passed
Linux - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux - JDK 8 : Tests passed: 4866, ignored: 134
Details
Linux with security manager - JDK 8
Finished TeamCity Build WildFly / Pull Request / Linux SM - JDK 8 : Tests passed: 4522, ignored: 152
Details
Windows - JDK 11
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 11 : Tests passed: 4857, ignored: 141
Details
Windows - JDK 8
Finished TeamCity Build WildFly / Pull Request / Windows - JDK 8 : Tests passed: 4859, ignored: 139
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
spyrkob commentedApr 24, 2019
JIRA: https://issues.jboss.org/browse/WFLY-10798
Follow up to fixes made in https://issues.jboss.org/browse/JBJCA-1386 to address situation when the Driver tries to load classes in its constructor.