Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-12681 Provide a 'microprofile-platform' Galleon layer #12948

Merged
merged 2 commits into from Sep 10, 2020
Merged

WFLY-12681 Provide a 'microprofile-platform' Galleon layer #12948

merged 2 commits into from Sep 10, 2020

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Jan 29, 2020 •
edited

@wildfly-ci wildfly-ci added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 29, 2020
@jmesnil jmesnil added the 19.x label Jan 31, 2020
@rhusar
Copy link
Member Author

rhusar commented Feb 18, 2020

As per @bstansberry 's suggestion, made all the specs optional except for config which is required by all specifications.

@rhusar
Copy link
Member Author

rhusar commented Feb 18, 2020

For the sake of completeness, I have opened the proposal as well wildfly/wildfly-proposals#293

@rhusar rhusar mentioned this pull request Feb 19, 2020
Closed
@darranl darranl removed the 19.x label Feb 20, 2020
pferraro
pferraro approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@pferraro pferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhusar
Copy link
Member Author

rhusar commented Mar 10, 2020

Rebased again..

@darranl
Copy link
Contributor

darranl commented Apr 30, 2020

No objection from me, do we need to double check the approach on Monday?

Also FYI this needs a rebase again.

@rhusar
Copy link
Member Author

rhusar commented May 4, 2020

@darranl Right, lets discuss on Mondays call.

@bstansberry bstansberry added Feature PR provides a new feature missing-reqs Features missing one or more of the pre-merge requirements labels Jun 26, 2020
@rhusar rhusar force-pushed the WFLY-12681 branch 3 times, most recently from edd853e to c8ec853 Compare July 20, 2020 16:19
@rhusar rhusar changed the title WFLY-12681 Provide a 'microprofile' Galleon layer WFLY-12681 Provide a 'microprofile-platform' Galleon layer Jul 20, 2020
@darranl darranl added the rebase-this PR has a merge conflict. label Jul 29, 2020
@darranl
Copy link
Contributor

darranl commented Jul 29, 2020

Sorry @rhusar but this is conflicting again.

@rhusar
Copy link
Member Author

rhusar commented Aug 4, 2020

@darranl Thanks, back from PTO, rebased now.

@bstansberry bstansberry removed the rebase-this PR has a merge conflict. label Sep 2, 2020
@rhusar rhusar force-pushed the WFLY-12681 branch 2 times, most recently from 4d455b7 to 92ee175 Compare September 10, 2020 10:15
@bstansberry bstansberry removed the missing-reqs Features missing one or more of the pre-merge requirements label Sep 10, 2020
@bstansberry
Copy link
Contributor

/retest

@rhusar
Copy link
Member Author

rhusar commented Sep 10, 2020

@bstansberry Needed a rebase again (also I think I botched the previous rebased, fixed that too).

@bstansberry bstansberry mentioned this pull request Sep 10, 2020
Closed
@bstansberry bstansberry merged commit 20d0d86 into wildfly:master Sep 10, 2020
@rhusar rhusar deleted the WFLY-12681 branch September 11, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan left review comments

@tommaso-borgato tommaso-borgato tommaso-borgato requested changes

@pferraro pferraro pferraro approved these changes

@darranl darranl darranl approved these changes

Assignees
No one assigned
Labels
deps-ok Dependencies have been checked, and there are no significant changes Feature PR provides a new feature
Projects
None yet
Milestone
No milestone
8 participants
@rhusar @darranl @bstansberry @pferraro @yersan @tommaso-borgato @jmesnil @wildfly-ci