New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-15092] Use maven-resource-plugin filtering to avoid duplicating … #14507
Conversation
<!-- Use filter expressions so standard WildFly and WildFly Preview can use artifacts with different qualifiers --> | ||
<artifact name="@gav.exp.start@com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider@module.jakarta.classifier@@gav.exp.end@"/> | ||
<artifact name="@gav.exp.start@com.fasterxml.jackson.jaxrs:jackson-jaxrs-base@module.jakarta.classifier@@gav.exp.end@"/> | ||
<artifact name="@gav.exp.start@com.fasterxml.jackson.module:jackson-module-jaxb-annotations@module.jakarta.classifier@@gav.exp.end@"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A possible alternative to allow the nested expressions avoiding the uses of @gav.exp.start@ and @gav.exp.end@ is to configure a scape character on the maven resource plugin. If we scape the first $, then it seems we could use nested expressions like the following one:
<artifact name="\${com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider${module.jakarta.classifier}}"/>
The maven resource plugin has to include the following configuration:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<version>3.2.0</version>
<configuration>
...
<escapeString>\</escapeString>
...
</configuration>
</plugin>
It is not a great advantage, but personally, it improves the readability of the module from my point of view and removes two maven properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yersan ; I've updated to use that.
8b941dc
to
5c32d92
Compare
… module.xml files for WildFly Preview
5c32d92
to
6f482b4
Compare
@bstansberry looks good to me. |
…module.xml files
https://issues.redhat.com/browse/WFLY-15092