Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-1899: refactor how the Undertow subsystem sets up the security context #4962

Closed
wants to merge 3 commits into from
Closed

WFLY-1899: refactor how the Undertow subsystem sets up the security context #4962

wants to merge 3 commits into from

Conversation

stuartwdouglas
Copy link
Contributor

No description provided.

@wildfly-ci
Copy link

Build 296 is now running using a merge of 1ac2bdf14dc11acdcfb363b66e7bc1c9910f64d8

@wildfly-ci
Copy link

Build 296 outcome was FAILURE using a merge of 1ac2bdf14dc11acdcfb363b66e7bc1c9910f64d8
Summary: Tests failed: 512 (512 new), passed: 3695, ignored: 64 Build time: 1:16:12

Failed tests

org.jboss.as.arquillian.container.embedded.CdiTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: test.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.arquillian.container.managed.ManagedAsClientWebArchiveServletTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: b51e1aa0-e655-45d8-9beb-cf555b332b51.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.arquillian.container.managed.ManagedAsClientEnterpriseArchiveServletTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: 66e54eaa-7571-4426-966b-649b48980077.ear
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.arquillian.container.managed.InjectManagementClientTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: 17f87e76-2b42-4d82-aed4-199a551cba46.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.arquillian.container.domain.managed.test.ManagedDomainTestCase.shouldBeAbleToRunInTargetedServer: java.lang.RuntimeException: Could not extract deployment information for server: [host=master, name=server-one, group=main-server-group, containerName=backend-1] on deployment: a868412e-b7f9-40ac-b071-bcde2fdd5c8e.war
    at org.jboss.as.arquillian.container.domain.ManagementClient.getHTTPDeploymentMetaData(ManagementClient.java:172)
    at org.jboss.as.arquillian.container.domain.LazyHttpContext.initiateContext(LazyHttpContext.java:85)

org.jboss.as.arquillian.container.domain.managed.test.ManagedDomainTwoTestCase.shouldBeAbleToStartServer: java.lang.RuntimeException: Server did not start within set timeout [serverOperationTimeoutInSeconds=120]. [host=master, name=server-two, group=main-server-group, containerName=backend-2]
    at org.jboss.as.arquillian.container.domain.ServerContainer.waitForServerState(ServerContainer.java:117)
    at org.jboss.as.arquillian.container.domain.ServerContainer.waitForServerToStart(ServerContainer.java:94)

org.jboss.as.arquillian.container.domain.managed.test.ManagedDomainTwoTestCase.shouldBeAbleToRunInStartedServer: java.lang.RuntimeException: Could not extract deployment information for server: [host=master, name=server-two, group=main-server-group, containerName=backend-2] on deployment: 69df5c42-d159-4952-8fde-9040ace3ecf7.war
    at org.jboss.as.arquillian.container.domain.ManagementClient.getHTTPDeploymentMetaData(ManagementClient.java:172)
    at org.jboss.as.arquillian.container.domain.LazyHttpContext.initiateContext(LazyHttpContext.java:85)

org.jboss.as.test.smoke.web.WarTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: war-example.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.test.smoke.deployment.rar.tests.eardeployment.EarDeploymentTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: new.ear
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.test.smoke.jaxrs.JaxrsTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: jaxrs-example.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.test.smoke.webservices.WSTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: ws-example.war
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)


##### there are 502 more failed tests, see build details

jaikiran
jaikiran reviewed Aug 26, 2013
View reviewed changes
undertow/src/main/java/org/wildfly/extension/undertow/security/SecurityActions.java
} catch (Exception e) {
throw MESSAGES.failToCreateSecurityContext(e);
if (WildFlySecurityManager.isChecking()) {
return WildFlySecurityManager.doUnchecked(new PrivilegedAction<SecurityContext>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a typo and instead should have been doChecked(...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, Stuart explained to me what the intention of this PR is. So ignore my previous comment.

@ctomc
Copy link
Contributor

ctomc commented Aug 26, 2013 

Caused by: java.lang.NullPointerException
    at org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.setup(SecurityContextThreadSetupAction.java:67)
    at io.undertow.servlet.core.CompositeThreadSetupAction.setup(CompositeThreadSetupAction.java:42)
    at io.undertow.servlet.core.DeploymentManagerImpl.deploy(DeploymentManagerImpl.java:143)
    at org.wildfly.extension.undertow.deployment.UndertowDeploymentService.startContext(UndertowDeploymentService.java:83)
    at org.wildfly.extension.undertow.deployment.UndertowDeploymentService.start(UndertowDeploymentService.java:71)
    at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1944) [jboss-msc-1.2.0.Beta2.jar:1.2.0.Beta2]
    at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1877) [jboss-msc-1.2.0.Beta2.jar:1.2.0.Beta2]
    ... 3 more

@wildfly-ci
Copy link

Build 299 is now running using a merge of 55c7ee78dacd03bbd3c9945b8988a8b34547dbb5

@wildfly-ci
Copy link

Build 300 is now running using a merge of 3e57885

@wildfly-ci
Copy link

Build 301 is now running using a merge of e21cd31

@wildfly-ci
Copy link

Build 299 outcome was SUCCESS using a merge of e21cd31
Summary: Tests passed: 4510, ignored: 86 Build time: 1:24:37

@wildfly-ci
Copy link

Build 300 outcome was SUCCESS using a merge of e21cd31
Summary: Tests passed: 4510, ignored: 86 Build time: 1:21:28

@wildfly-ci
Copy link

Build 301 outcome was FAILURE using a merge of e21cd31
Summary: Tests failed: 3 (3 new), passed: 4507, ignored: 86 Build time: 1:26:46

Failed tests

org.jboss.as.test.integration.ejb.timerservice.schedule.SimpleScheduleSecondTestCase.testScheduleMethodTimeout: java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.clustering.cluster.ejb3.StatefulTimeoutTestCase(SYNC-tcp).setup: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: StatefulTimeoutTestCase.jar
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

org.jboss.as.test.clustering.cluster.dispatcher.CommandDispatcherTestCase(SYNC-tcp).test: java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

@jaikiran
Copy link
Contributor

Merged

@jaikiran jaikiran closed this Aug 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@stuartwdouglas @wildfly-ci @ctomc @jaikiran