New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/convert/update platform-mbean #6301

Merged
merged 6 commits into from Jun 3, 2014

Conversation

Projects
None yet
3 participants
@ctomc
Contributor

ctomc commented May 22, 2014

  • No more deprecated api usages.
  • No more checking if java version is > 6 as it always is.
  • fix controller tools for comparing to work with http-remoting
  • add 8.0.0.Final legacy models
@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 22, 2014

Build 3804 is now running using a merge of 1a97a47

wildfly-ci commented May 22, 2014

Build 3804 is now running using a merge of 1a97a47

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 22, 2014

Build 3804 outcome was SUCCESS using a merge of 1a97a47
Summary: Tests passed: 5822, ignored: 89 Build time: 1:55:22

wildfly-ci commented May 22, 2014

Build 3804 outcome was SUCCESS using a merge of 1a97a47
Summary: Tests passed: 5822, ignored: 89 Build time: 1:55:22

.setAllowNull(false)
.build();
static final SimpleAttributeDefinition MAX_DEPTH = new SimpleAttributeDefinitionBuilder(PlatformMBeanConstants.MAX_DEPTH, ModelType.INT, false)

This comment has been minimized.

@bstansberry

bstansberry May 23, 2014

Contributor

This allows null. That's how the overloaded variants of java.lang.management.ThreadMXBean.getThreadInfo are handled.

@bstansberry

bstansberry May 23, 2014

Contributor

This allows null. That's how the overloaded variants of java.lang.management.ThreadMXBean.getThreadInfo are handled.

This comment has been minimized.

@ctomc

ctomc May 23, 2014

Contributor

Damn, i had it like that, but changed it to not allowed after doing model compare with 8.0.0...
I Guess old was wrong :)

@ctomc

ctomc May 23, 2014

Contributor

Damn, i had it like that, but changed it to not allowed after doing model compare with 8.0.0...
I Guess old was wrong :)

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 23, 2014

Build 3809 is now running using a merge of 62e6124

wildfly-ci commented May 23, 2014

Build 3809 is now running using a merge of 62e6124

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 23, 2014

Build 3809 outcome was SUCCESS using a merge of 62e6124
Summary: Tests passed: 5825, ignored: 89 Build time: 1:55:07

wildfly-ci commented May 23, 2014

Build 3809 outcome was SUCCESS using a merge of 62e6124
Summary: Tests passed: 5825, ignored: 89 Build time: 1:55:07

.setReplyType(ModelType.LIST)
.setReplyValueType(ModelType.LONG)
.setRuntimeOnly()
.setReadOnly()

This comment has been minimized.

@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return an array of IDs of the threads that are
 * deadlocked waiting for object monitors or ownable synchronizers, if any;
 * <tt>null</tt> otherwise.
@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return an array of IDs of the threads that are
 * deadlocked waiting for object monitors or ownable synchronizers, if any;
 * <tt>null</tt> otherwise.
.setReplyType(ModelType.LIST)
.setReplyValueType(ModelType.LONG)
.setRuntimeOnly()
.setReadOnly()

This comment has been minimized.

@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return an array of IDs of the threads that are monitor
 * deadlocked, if any; <tt>null</tt> otherwise.
@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return an array of IDs of the threads that are monitor
 * deadlocked, if any; <tt>null</tt> otherwise.
.setReplyType(ModelType.OBJECT)
.setReplyParameters(CommonAttributes.THREAD_INFO_ATTRIBUTES)
.setReadOnly()
.setRuntimeOnly()

This comment has been minimized.

@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return a {@link ThreadInfo} object for the thread of the given ID
 * with no stack trace, no locked monitor and no synchronizer info;
 * <tt>null</tt> if the thread of the given ID is not alive or
 * it does not exist.
@bstansberry

bstansberry May 24, 2014

Contributor

needs .allowReturnNull() as the method javadoc says:

 * @return a {@link ThreadInfo} object for the thread of the given ID
 * with no stack trace, no locked monitor and no synchronizer info;
 * <tt>null</tt> if the thread of the given ID is not alive or
 * it does not exist.
@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 26, 2014

Build 3822 is now running using a merge of e5a30e3

wildfly-ci commented May 26, 2014

Build 3822 is now running using a merge of e5a30e3

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 26, 2014

Build 3822 outcome was FAILURE using a merge of e5a30e3
Summary: Tests failed: 1 (1 new), passed: 5823, ignored: 89 Build time: 1:54:18

Build problems:

Failed tests detected

java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:188)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testConcurrentFailover(RemoteFailoverTestCase.java:314)
Caused by: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:236)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:181)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:144)
    at com.sun.proxy.$Proxy26.increment(Unknown Source)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase$IncrementTask.run(RemoteFailoverTestCase.java:372)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:744)
Caused by: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at org.jboss.ejb.client.remoting.ChannelAssociation$1.handleClose(ChannelAssociation.java:123)
    at org.jboss.ejb.client.remoting.ChannelAssociation$1.handleClose(ChannelAssociation.java:115)
    at org.jboss.remoting3.spi.SpiUtils.safeHandleClose(SpiUtils.java:54)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable$CloseHandlerTask.run(AbstractHandleableCloseable.java:501)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.runCloseTask(AbstractHandleableCloseable.java:406)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.closeComplete(AbstractHandleableCloseable.java:277)
    at org.jboss.remoting3.remote.RemoteConnectionChannel.closeAction(RemoteConnectionChannel.java:532)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.closeAsync(AbstractHandleableCloseable.java:359)
    at org.jboss.remoting3.remote.RemoteConnectionHandler.closeAllChannels(RemoteConnectionHandler.java:392)
    at org.jboss.remoting3.remote.RemoteConnectionHandler.receiveCloseRequest(RemoteConnectionHandler.java:213)
    at org.jboss.remoting3.remote.RemoteReadListener.handleEvent(RemoteReadListener.java:110)
    at org.jboss.remoting3.remote.RemoteReadListener.handleEvent(RemoteReadListener.java:45)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:199)
    at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:113)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.ChannelListeners$DelegatingChannelListener.handleEvent(ChannelListeners.java:1092)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.conduits.ReadReadyHandler$ChannelListenerHandler.readReady(ReadReadyHandler.java:66)
    at org.xnio.nio.NioSocketConduit.handleReady(NioSocketConduit.java:87)
    at org.xnio.nio.WorkerThread.run(WorkerThread.java:539)

Failed tests

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testConcurrentFailover: java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:188)

wildfly-ci commented May 26, 2014

Build 3822 outcome was FAILURE using a merge of e5a30e3
Summary: Tests failed: 1 (1 new), passed: 5823, ignored: 89 Build time: 1:54:18

Build problems:

Failed tests detected

java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:188)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testConcurrentFailover(RemoteFailoverTestCase.java:314)
Caused by: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:236)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:181)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:144)
    at com.sun.proxy.$Proxy26.increment(Unknown Source)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase$IncrementTask.run(RemoteFailoverTestCase.java:372)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:304)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:178)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:744)
Caused by: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at org.jboss.ejb.client.remoting.ChannelAssociation$1.handleClose(ChannelAssociation.java:123)
    at org.jboss.ejb.client.remoting.ChannelAssociation$1.handleClose(ChannelAssociation.java:115)
    at org.jboss.remoting3.spi.SpiUtils.safeHandleClose(SpiUtils.java:54)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable$CloseHandlerTask.run(AbstractHandleableCloseable.java:501)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.runCloseTask(AbstractHandleableCloseable.java:406)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.closeComplete(AbstractHandleableCloseable.java:277)
    at org.jboss.remoting3.remote.RemoteConnectionChannel.closeAction(RemoteConnectionChannel.java:532)
    at org.jboss.remoting3.spi.AbstractHandleableCloseable.closeAsync(AbstractHandleableCloseable.java:359)
    at org.jboss.remoting3.remote.RemoteConnectionHandler.closeAllChannels(RemoteConnectionHandler.java:392)
    at org.jboss.remoting3.remote.RemoteConnectionHandler.receiveCloseRequest(RemoteConnectionHandler.java:213)
    at org.jboss.remoting3.remote.RemoteReadListener.handleEvent(RemoteReadListener.java:110)
    at org.jboss.remoting3.remote.RemoteReadListener.handleEvent(RemoteReadListener.java:45)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.channels.TranslatingSuspendableChannel.handleReadable(TranslatingSuspendableChannel.java:199)
    at org.xnio.channels.TranslatingSuspendableChannel$1.handleEvent(TranslatingSuspendableChannel.java:113)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.ChannelListeners$DelegatingChannelListener.handleEvent(ChannelListeners.java:1092)
    at org.xnio.ChannelListeners.invokeChannelListener(ChannelListeners.java:92)
    at org.xnio.conduits.ReadReadyHandler$ChannelListenerHandler.readReady(ReadReadyHandler.java:66)
    at org.xnio.nio.NioSocketConduit.handleReady(NioSocketConduit.java:87)
    at org.xnio.nio.WorkerThread.run(WorkerThread.java:539)

Failed tests

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testConcurrentFailover: java.util.concurrent.ExecutionException: javax.ejb.EJBException: java.io.IOException: Channel Channel ID e25ef89e (outbound) of Remoting connection 0028a31b to /0:0:0:0:0:0:0:1:8180 has been closed
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:188)

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 26, 2014

Build 3824 is now running using a merge of e5a30e3

wildfly-ci commented May 26, 2014

Build 3824 is now running using a merge of e5a30e3

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 26, 2014

Build 3824 outcome was SUCCESS using a merge of e5a30e3
Summary: Tests passed: 5824, ignored: 89 Build time: 1:55:10

wildfly-ci commented May 26, 2014

Build 3824 outcome was SUCCESS using a merge of e5a30e3
Summary: Tests passed: 5824, ignored: 89 Build time: 1:55:10

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 28, 2014

Build 3847 is now running using a merge of dd91f03

wildfly-ci commented May 28, 2014

Build 3847 is now running using a merge of dd91f03

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 28, 2014

Build 3848 is now running using a merge of 5056a23

wildfly-ci commented May 28, 2014

Build 3848 is now running using a merge of 5056a23

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 28, 2014

Build 3848 outcome was FAILURE using a merge of 5056a23
Summary: Tests failed: 1 (1 new), passed: 5882, ignored: 98 Build time: 1:55:21

Build problems:

Failed tests detected

java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final
INFO  [org.jboss.security] PBOX000361: Default Security Vault Implementation Initialized and Ready
INFO  [org.xnio] XNIO version 3.3.0.Beta1
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.3.0.Beta1
INFO  [org.jboss.remoting] JBoss Remoting version 4.0.3.Final
"
java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final
INFO  [org.jboss.security] PBOX000361: Default Security Vault Implementation Initialized and Ready
INFO  [org.xnio] XNIO version 3.3.0.Beta1
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.3.0.Beta1
INFO  [org.jboss.remoting] JBoss Remoting version 4.0.3.Final
"
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    at org.junit.Assert.assertThat(Assert.java:865)
    at org.jboss.as.test.manualmode.management.cli.VaultPasswordsInCLITestCase.testRightVaultPassword(VaultPasswordsInCLITestCase.java:158)

Failed tests

org.jboss.as.test.manualmode.management.cli.VaultPasswordsInCLITestCase.testRightVaultPassword: java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final

wildfly-ci commented May 28, 2014

Build 3848 outcome was FAILURE using a merge of 5056a23
Summary: Tests failed: 1 (1 new), passed: 5882, ignored: 98 Build time: 1:55:21

Build problems:

Failed tests detected

java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final
INFO  [org.jboss.security] PBOX000361: Default Security Vault Implementation Initialized and Ready
INFO  [org.xnio] XNIO version 3.3.0.Beta1
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.3.0.Beta1
INFO  [org.jboss.remoting] JBoss Remoting version 4.0.3.Final
"
java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final
INFO  [org.jboss.security] PBOX000361: Default Security Vault Implementation Initialized and Ready
INFO  [org.xnio] XNIO version 3.3.0.Beta1
INFO  [org.xnio.nio] XNIO NIO Implementation Version 3.3.0.Beta1
INFO  [org.jboss.remoting] JBoss Remoting version 4.0.3.Final
"
    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
    at org.junit.Assert.assertThat(Assert.java:865)
    at org.jboss.as.test.manualmode.management.cli.VaultPasswordsInCLITestCase.testRightVaultPassword(VaultPasswordsInCLITestCase.java:158)

Failed tests

org.jboss.as.test.manualmode.management.cli.VaultPasswordsInCLITestCase.testRightVaultPassword: java.lang.AssertionError: Password should be right and authentication successful
Expected: a string containing "\"outcome\" => \"success\""
     but: was "0: INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 28, 2014

Build 3854 is now running using a merge of 5056a23

wildfly-ci commented May 28, 2014

Build 3854 is now running using a merge of 5056a23

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci May 28, 2014

Build 3854 outcome was SUCCESS using a merge of 5056a23
Summary: Tests passed: 5883, ignored: 98 Build time: 1:55:53

wildfly-ci commented May 28, 2014

Build 3854 outcome was SUCCESS using a merge of 5056a23
Summary: Tests passed: 5883, ignored: 98 Build time: 1:55:53

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci Jun 3, 2014

Build 3879 is now running using a merge of a16ecb3

wildfly-ci commented Jun 3, 2014

Build 3879 is now running using a merge of a16ecb3

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci Jun 3, 2014

Build 3879 outcome was SUCCESS using a merge of a16ecb3
Summary: Tests passed: 5885, ignored: 98 Build time: 1:55:03

wildfly-ci commented Jun 3, 2014

Build 3879 outcome was SUCCESS using a merge of a16ecb3
Summary: Tests passed: 5885, ignored: 98 Build time: 1:55:03

bstansberry added a commit that referenced this pull request Jun 3, 2014

Merge pull request #6301 from ctomc/cleanup
Cleanup/convert/update platform-mbean

@bstansberry bstansberry merged commit c38972f into wildfly:master Jun 3, 2014

1 check passed

default TeamCity Build WildFly :: Pull request finished: Tests passed: 5885, ignored: 98
Details
@ctomc

This comment has been minimized.

Show comment
Hide comment
@ctomc

ctomc Jun 3, 2014

Contributor

Thank you!

Contributor

ctomc commented Jun 3, 2014

Thank you!

@ctomc ctomc deleted the ctomc:cleanup branch Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment