[WFLY-4295] Fix -ds.xml deprecation logging

[kabir]

I found that the deprecation logging message was getting logged whether or not a deployment contains a -ds.xml. I have moved it to where I believe it would get triggered if it actually does.

[wildfly-ci]

Linux Build 5833 is now running using a merge of 6e9e3b5

[wildfly-ci]

Linux with security manager Build 818 is now running using a merge of 6e9e3b5

[wildfly-ci]

Windows Build 942 is now running using a merge of 6e9e3b5

[wildfly-ci]

Linux with security manager Build 818 outcome was SUCCESS using a merge of 6e9e3b5
Summary: Tests passed: 839, ignored: 316 Build time: 0:05:10

[wildfly-ci]

Windows Build 942 outcome was FAILURE using a merge of 6e9e3b5
Summary: Tests failed: 1, passed: 2920, ignored: 312 Build time: 0:47:34

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.jpa.cfgfile.CfgFileTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: jpa_cfgfile.jar
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

[wildfly-ci]

Linux Build 5833 outcome was FAILURE using a merge of 6e9e3b5
Summary: Tests failed: 1, passed: 2920, ignored: 312 Build time: 0:48:34

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.jpa.cfgfile.CfgFileTestCase: org.jboss.arquillian.container.spi.client.container.DeploymentException: Cannot deploy: jpa_cfgfile.jar
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:83)
    at org.jboss.as.arquillian.container.ArchiveDeployer.deployInternal(ArchiveDeployer.java:64)

[bstansberry]

Since this is in a loop, it should be guarded by a boolean var so it only logs once if there's more than one -ds.xml.

[wildfly-ci]

Linux with security manager Build 821 is now running using a merge of 74b555d

[wildfly-ci]

Windows Build 945 is now running using a merge of 74b555d

[wildfly-ci]

Linux Build 5836 is now running using a merge of 74b555d

[wildfly-ci]

Linux with security manager Build 821 outcome was SUCCESS using a merge of 74b555d
Summary: Tests passed: 839, ignored: 316 Build time: 0:05:05

[wildfly-ci]

Windows Build 945 outcome was FAILURE using a merge of 74b555d
Summary: Tests failed: 1 (1 new), passed: 2921, ignored: 312 Build time: 0:45:44

Build problems:

Failed tests detected

Failed tests

org.jboss.as.test.integration.domain.suites.DeploymentManagementTestCase.testFullReplaceViaHash: java.lang.AssertionError: C:\BuildAgent\work\340a2b56aab3b1db\testsuite\domain\target\domains\DomainTestSuite\master\data\content\0f
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

[wildfly-ci]

Linux Build 5836 outcome was SUCCESS using a merge of 74b555d
Summary: Tests passed: 2922, ignored: 312 Build time: 0:48:43