New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reverted] [WFLY-6779] added WISE feature code #8998

Merged
merged 1 commit into from Aug 27, 2016

Conversation

Projects
None yet
6 participants
@rsearls
Contributor

rsearls commented Jun 27, 2016

Kabir: This PR was merged and then reverted as mentioned in https://issues.jboss.org/browse/WFLY-6779.

Show outdated Hide outdated feature-pack/src/main/resources/configuration/standalone/subsystems.xml
@@ -30,5 +30,6 @@
<subsystem>undertow.xml</subsystem>
<subsystem>webservices.xml</subsystem>
<subsystem>weld.xml</subsystem>
<subsystem>wise.xml</subsystem>

This comment has been minimized.

@kabir

kabir Jun 27, 2016

Contributor

Nitpick: indentation

@kabir

kabir Jun 27, 2016

Contributor

Nitpick: indentation

Show outdated Hide outdated pom.xml
@@ -307,6 +309,7 @@
<module>servlet-feature-pack</module>
<module>webservices</module>
<module>weld</module>
<module>wise</module>

This comment has been minimized.

@kabir

kabir Jun 27, 2016

Contributor

Nitpick: indentation

@kabir

kabir Jun 27, 2016

Contributor

Nitpick: indentation

@kabir

This comment has been minimized.

Show comment
Hide comment
@kabir

kabir Jun 27, 2016

Contributor

I've not looked in much detail, but notice that this needs an xsd. jdr/jboss-as-jdr/src/main/resources/schema/jboss-as-jdr_1_0.xsd contains an example for an empty subsystem.

Contributor

kabir commented Jun 27, 2016

I've not looked in much detail, but notice that this needs an xsd. jdr/jboss-as-jdr/src/main/resources/schema/jboss-as-jdr_1_0.xsd contains an example for an empty subsystem.

Show outdated Hide outdated ...re-pack/src/main/resources/content/appclient/configuration/appclient.xml
<module-option name="realm" value="ManagementRealm"/>
</login-module>
</authentication>
</security-domain>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

app client needs this? really?

@ctomc

ctomc Jul 5, 2016

Contributor

app client needs this? really?

This comment has been minimized.

@rsearls

rsearls Jul 5, 2016

Contributor

Just to be clear, I should move this into ./security/subsystem/src/main/resources/subsystem-templates/security.xml
Right?

----- Original Message -----

From: "Tomaz Cerar" notifications@github.com
To: "wildfly/wildfly" wildfly@noreply.github.com
Cc: "rsearls" rsearls@redhat.com, "Author" author@noreply.github.com
Sent: Tuesday, July 5, 2016 5:53:11 AM
Subject: Re: [wildfly/wildfly] [WFLY-6779] added WISE feature code (#8998)

@@ -154,6 +154,13 @@


  •            <security-domain name="wise-security-domain"
    
    cache-type="default">
  •                <authentication>
    
  •                    <login-module code="RealmDirect" flag="required">
    
  •                        <module-option name="realm"
    
    value="ManagementRealm"/>
  •                    </login-module>
    
  •                </authentication>
    
  •            </security-domain>
    

app client needs this? really?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/wildfly/wildfly/pull/8998/files/1cc1e6d45243b24d555028c72475d8565505c969#r69535902

@rsearls

rsearls Jul 5, 2016

Contributor

Just to be clear, I should move this into ./security/subsystem/src/main/resources/subsystem-templates/security.xml
Right?

----- Original Message -----

From: "Tomaz Cerar" notifications@github.com
To: "wildfly/wildfly" wildfly@noreply.github.com
Cc: "rsearls" rsearls@redhat.com, "Author" author@noreply.github.com
Sent: Tuesday, July 5, 2016 5:53:11 AM
Subject: Re: [wildfly/wildfly] [WFLY-6779] added WISE feature code (#8998)

@@ -154,6 +154,13 @@


  •            <security-domain name="wise-security-domain"
    
    cache-type="default">
  •                <authentication>
    
  •                    <login-module code="RealmDirect" flag="required">
    
  •                        <module-option name="realm"
    
    value="ManagementRealm"/>
  •                    </login-module>
    
  •                </authentication>
    
  •            </security-domain>
    

app client needs this? really?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/wildfly/wildfly/pull/8998/files/1cc1e6d45243b24d555028c72475d8565505c969#r69535902

This comment has been minimized.

@ctomc

ctomc Jul 7, 2016

Contributor

yes

@ctomc

ctomc Jul 7, 2016

Contributor

yes

Show outdated Hide outdated pom.xml
</exclusion>
<exclusion>
<groupId>org.jboss.as</groupId>
<artifactId>jboss-as-controller</artifactId>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

no need to exclude that, as it shouldn't be used in first place at all.

@ctomc

ctomc Jul 5, 2016

Contributor

no need to exclude that, as it shouldn't be used in first place at all.

Show outdated Hide outdated servlet-feature-pack/pom.xml
<exclusions>
<exclusion>
<groupId>*</groupId>
<artifactId>*</artifactId>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

why servlet feature pack? does this work without web services present?

@ctomc

ctomc Jul 5, 2016

Contributor

why servlet feature pack? does this work without web services present?

Show outdated Hide outdated servlet-feature-pack/pom.xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>2.10</version>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

this needs to be completely removed, as feature pack wont work like this.
it is maven dependency and such should be defined in module.xml provisioning plugin does the rest of the work

@ctomc

ctomc Jul 5, 2016

Contributor

this needs to be completely removed, as feature pack wont work like this.
it is maven dependency and such should be defined in module.xml provisioning plugin does the rest of the work

Show outdated Hide outdated ...n/resources/modules/system/layers/base/org/jboss/as/wise/main/module.xml
~ 02110-1301 USA, or see the FSF site: http://www.fsf.org.
-->
<module xmlns="urn:jboss:module:1.1" name="org.jboss.as.wise">

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

1.3
name, org.wildfly.extension.wise, we don't use org.jboss.as namespace for new stuff anymore.

@ctomc

ctomc Jul 5, 2016

Contributor

1.3
name, org.wildfly.extension.wise, we don't use org.jboss.as namespace for new stuff anymore.

Show outdated Hide outdated wise/pom.xml
<version>10.1.0.Final-SNAPSHOT</version>
</parent>
<artifactId>jboss-as-wise</artifactId>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

this should be wildfly-wise

@ctomc

ctomc Jul 5, 2016

Contributor

this should be wildfly-wise

Show outdated Hide outdated wise/pom.xml
<dependency>
<groupId>org.jboss.as</groupId>
<artifactId>jboss-as-controller</artifactId>
<version>7.2.0.Final</version>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

remove this dependancy completly, as it brings in different version that is already build.

just use

<dependency>
           <groupId>org.wildfly.core</groupId>
           <artifactId>wildfly-controller</artifactId>
</dependency>

doing this will also remove need for extra exclusions everywhere.

@ctomc

ctomc Jul 5, 2016

Contributor

remove this dependancy completly, as it brings in different version that is already build.

just use

<dependency>
           <groupId>org.wildfly.core</groupId>
           <artifactId>wildfly-controller</artifactId>
</dependency>

doing this will also remove need for extra exclusions everywhere.

Show outdated Hide outdated wise/pom.xml
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

remove it completely , as config like this is no longer needed.

@ctomc

ctomc Jul 5, 2016

Contributor

remove it completely , as config like this is no longer needed.

Show outdated Hide outdated wise/src/main/java/org/jboss/as/wise/WiseExtension.java
* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/
package org.jboss.as.wise;

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

package name should be
org.wildfly.extension.wise

@ctomc

ctomc Jul 5, 2016

Contributor

package name should be
org.wildfly.extension.wise

Show outdated Hide outdated wise/src/main/java/org/jboss/as/wise/WiseExtension.java
private static final int MANAGEMENT_API_MAJOR_VERSION = 1;
private static final int MANAGEMENT_API_MINOR_VERSION = 0;
private static final int MANAGEMENT_API_MICRO_VERSION = 0;

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

use private static final ModelVersion VERSION = ModelVersion.create(1,0,0) instead.

@ctomc

ctomc Jul 5, 2016

Contributor

use private static final ModelVersion VERSION = ModelVersion.create(1,0,0) instead.

Show outdated Hide outdated wise/src/main/java/org/jboss/as/wise/WiseExtension.java
@Override
public void initialize(final ExtensionContext context) {
WiseLogger.ROOT_LOGGER.activatingWiseExtension();
final SubsystemRegistration subsystem = context.registerSubsystem(

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

should be
context.registerSubsystem(VERSION);

@ctomc

ctomc Jul 5, 2016

Contributor

should be
context.registerSubsystem(VERSION);

Show outdated Hide outdated wise/src/main/java/org/jboss/as/wise/WiseLogger.java
WiseLogger ROOT_LOGGER = Logger.getMessageLogger(WiseLogger.class, "org.jboss.as.wise");
@LogMessage(level = INFO)
@Message(id = 1, value = "Activating Wise Extension")

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

this should be level DEBUG, not INFO

@ctomc

ctomc Jul 5, 2016

Contributor

this should be level DEBUG, not INFO

Show outdated Hide outdated wise/src/main/java/org/jboss/as/wise/WiseSubsystemAdd.java
Module module = Module.forClass(getClass());
URL url = module.getExportedResource("wise.war");
String urlString = url.toExternalForm();
System.out.println(url);

This comment has been minimized.

@ctomc

ctomc Jul 5, 2016

Contributor

system.out must not be used.

@ctomc

ctomc Jul 5, 2016

Contributor

system.out must not be used.

@ctomc

This comment has been minimized.

Show comment
Hide comment
@ctomc

ctomc Jul 5, 2016

Contributor

on top of all stuff mentioned in code review, this PR is missing at least subsystem test case.

Contributor

ctomc commented Jul 5, 2016

on top of all stuff mentioned in code review, this PR is missing at least subsystem test case.

@bstansberry bstansberry added the 11.x label Jul 7, 2016

Show outdated Hide outdated ...es/modules/system/layers/base/org/wildfly/extension/wise/main/module.xml
<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2010, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/pom.xml
<?xml version="1.0" encoding="UTF-8"?>
<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2011, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseExtension.java
@@ -0,0 +1,142 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseExtension.java
/**
* Extension for subsystem that deploys wise.war.
*
* @author Brian Stansberry (c) 2012 Red Hat Inc.

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

author

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

author

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseLogger.java
@@ -0,0 +1,46 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseMessages.java
@@ -0,0 +1,36 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseSubsystemAdd.java
@@ -0,0 +1,97 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseSubsystemRemove.java
@@ -0,0 +1,68 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/main/resources/schema/jboss-as-wise_1_0.xsd
<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2011, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/test/java/org/wildfly/extension/wise/WiseSubsystemTestCase.java
@@ -0,0 +1,53 @@
/*
* JBoss, Home of Professional Open Source.
* Copyright 2013, Red Hat, Inc., and individual contributors

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

year ...

Show outdated Hide outdated wise/src/test/java/org/wildfly/extension/wise/WiseSubsystemTestCase.java
import org.jboss.as.subsystem.test.AbstractSubsystemBaseTest;
/**
* @author rsearls@redhat.com

This comment has been minimized.

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

Other places use * User: rsearls
please sync it

@rsvoboda

rsvoboda Jul 13, 2016

Contributor

Other places use * User: rsearls
please sync it

Show outdated Hide outdated wise/src/test/java/org/wildfly/extension/wise/WiseSubsystemTestCase.java
@Override
protected String getSubsystemXsdPath() throws Exception {
return "schema/jboss-as-wise_1_0.xsd";

This comment has been minimized.

@rsvoboda

rsvoboda Jul 15, 2016

Contributor

Shouldn't be the schema named wildfly-wise-... ?

@rsvoboda

rsvoboda Jul 15, 2016

Contributor

Shouldn't be the schema named wildfly-wise-... ?

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseMessages.java
/**
*/
@MessageBundle(projectCode = "JBWS")

This comment has been minimized.

@ctomc

ctomc Jul 15, 2016

Contributor

probably WFLYWSW

@ctomc

ctomc Jul 15, 2016

Contributor

probably WFLYWSW

Show outdated Hide outdated feature-pack/pom.xml
<type>war</type>
<overWrite>true</overWrite>
<outputDirectory>${project.build.directory}/wildfly-${project.version}/modules/system/layers/base/org/wildfly/extension/wise/main/deployments</outputDirectory>
<destFileName>wise.war</destFileName>

This comment has been minimized.

@ctomc

ctomc Jul 15, 2016

Contributor

i think this can be done in feature pack config file (feature-pack-build.xml)
with notion which would than copy the war file where ever you want it to.

@ctomc

ctomc Jul 15, 2016

Contributor

i think this can be done in feature pack config file (feature-pack-build.xml)
with notion which would than copy the war file where ever you want it to.

@ctomc

This comment has been minimized.

Show comment
Hide comment
@ctomc

ctomc Jul 15, 2016

Contributor

Beyond few small things commented above, it looks ok.
Just please squash commits into just one once you are done.

Contributor

ctomc commented Jul 15, 2016

Beyond few small things commented above, it looks ok.
Just please squash commits into just one once you are done.

@rsvoboda

This comment has been minimized.

Show comment
Hide comment
@rsvoboda

rsvoboda Aug 10, 2016

Contributor

Can be this merged ?

Contributor

rsvoboda commented Aug 10, 2016

Can be this merged ?

@rsearls

This comment has been minimized.

Show comment
Hide comment
@rsearls

rsearls Aug 11, 2016

Contributor

All the issues identified since original submission have been addressed.
This should be mergable

Contributor

rsearls commented Aug 11, 2016

All the issues identified since original submission have been addressed.
This should be mergable

@wildfly-ci wildfly-ci added rebase-this and removed rebase-this labels Aug 12, 2016

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseLogger.java
@LogMessage(level = DEBUG)
@Message(id = 1, value = "Activating Wise Extension")
void activatingWiseExtension();

This comment has been minimized.

@ctomc

ctomc Aug 16, 2016

Contributor

given that this is logged at DEBUG level, which is proper thing, it shouldn't be localized and as such no need to have it in localized logger.

@ctomc

ctomc Aug 16, 2016

Contributor

given that this is logged at DEBUG level, which is proper thing, it shouldn't be localized and as such no need to have it in localized logger.

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseMessages.java
/**
* The messages
*/
WiseMessages MESSAGES = Messages.getBundle(WiseMessages.class);

This comment has been minimized.

@ctomc

ctomc Aug 16, 2016

Contributor

please remove this one, as having one localized logger is enough.
Just keep WiseLogger as that one should do it.
We also changed all subsystems to have all localized stuff in one place instead in two.

@ctomc

ctomc Aug 16, 2016

Contributor

please remove this one, as having one localized logger is enough.
Just keep WiseLogger as that one should do it.
We also changed all subsystems to have all localized stuff in one place instead in two.

Show outdated Hide outdated wise/src/main/java/org/wildfly/extension/wise/WiseSubsystemAdd.java
}
@Override
protected void populateModel(ModelNode operation, ModelNode model)

This comment has been minimized.

@ctomc

ctomc Aug 16, 2016

Contributor

you don't need to override this method, just remove it all together.

@ctomc

ctomc Aug 16, 2016

Contributor

you don't need to override this method, just remove it all together.

@ctomc

This comment has been minimized.

Show comment
Hide comment
@ctomc

ctomc Aug 16, 2016

Contributor

I left few minor comments which are mostly just cleanup not major changes in the code.
The only thing that I am not 100% about is, does this subsystem really need to be in default config (standalone.xml) as I think it would be better suited in standalone-full.xml
But none of this is showstopper.

Contributor

ctomc commented Aug 16, 2016

I left few minor comments which are mostly just cleanup not major changes in the code.
The only thing that I am not 100% about is, does this subsystem really need to be in default config (standalone.xml) as I think it would be better suited in standalone-full.xml
But none of this is showstopper.

@rsearls

This comment has been minimized.

Show comment
Hide comment
@rsearls

rsearls Aug 17, 2016

Contributor

It should be in both standalone.xml and standalone-full.xml. Is there some other file to be edited to add to
standalone-full?

Contributor

rsearls commented Aug 17, 2016

It should be in both standalone.xml and standalone-full.xml. Is there some other file to be edited to add to
standalone-full?

@ctomc

This comment has been minimized.

Show comment
Hide comment
@ctomc

ctomc Aug 17, 2016

Contributor

@rsearls subsystems-full.xml or subsystems-*.xml

Contributor

ctomc commented Aug 17, 2016

@rsearls subsystems-full.xml or subsystems-*.xml

rsearls
@rsearls

This comment has been minimized.

Show comment
Hide comment
@rsearls

rsearls Aug 17, 2016

Contributor

removed WiseMessages.java
removed 2nd WiseSubsystemAdd.populateModel() method
removed WiseLogger.activatingWiseExtension()
Added wise to standalone-full.xml

Contributor

rsearls commented Aug 17, 2016

removed WiseMessages.java
removed 2nd WiseSubsystemAdd.populateModel() method
removed WiseLogger.activatingWiseExtension()
Added wise to standalone-full.xml

@rsearls

This comment has been minimized.

Show comment
Hide comment
@rsearls

rsearls Aug 17, 2016

Contributor

I don't see that any of the wise code or configuration cause this failure.
Any suggestions on how best to resolve?

Contributor

rsearls commented Aug 17, 2016

I don't see that any of the wise code or configuration cause this failure.
Any suggestions on how best to resolve?

@kabir kabir added ready-for-merge and removed 11.x labels Aug 19, 2016

@kabir

This comment has been minimized.

Show comment
Hide comment
@kabir

kabir Aug 25, 2016

Contributor

Retest this please

Contributor

kabir commented Aug 25, 2016

Retest this please

@wildfly-ci

This comment has been minimized.

Show comment
Hide comment
@wildfly-ci

wildfly-ci Aug 25, 2016

Linux Build 10272 outcome was FAILURE using a merge of 7aa95e9
Summary: Tests failed: 2 (2 new), passed: 3441, ignored: 192 Build time: 01:06:23

Failed tests

org.jboss.as.test.integration.ejb.stateful.passivation.ejb2.PassivationSucceedsEJB2TestCase.testPassivationMaxSize: java.rmi.NoSuchObjectException: WFLYEJB0168: Could not find EJB with id UnknownSessionID [6651545769504854527055665268676656506569495668504857696665505470]
    at org.jboss.as.ejb3.component.interceptors.EjbExceptionTransformingInterceptorFactories$1.processInvocation(EjbExceptionTransformingInterceptorFactories.java:84)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.as.ee.component.NamespaceContextInterceptor.processInvocation(NamespaceContextInterceptor.java:50)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.as.ejb3.component.interceptors.AdditionalSetupInterceptor.processInvocation(AdditionalSetupInterceptor.java:54)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.ContextClassLoaderInterceptor.processInvocation(ContextClassLoaderInterceptor.java:64)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.InterceptorContext.run(InterceptorContext.java:356)
    at org.wildfly.security.manager.WildFlySecurityManager.doChecked(WildFlySecurityManager.java:636)
    at org.jboss.invocation.AccessCheckingInterceptor.processInvocation(AccessCheckingInterceptor.java:61)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.InterceptorContext.run(InterceptorContext.java:356)
    at org.jboss.invocation.PrivilegedWithCombinerInterceptor.processInvocation(PrivilegedWithCombinerInterceptor.java:80)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.ChainedInterceptor.processInvocation(ChainedInterceptor.java:61)
    at org.jboss.as.ee.component.ViewService$View.invoke(ViewService.java:198)
    at org.jboss.as.ejb3.remote.LocalEjbReceiver.processInvocation(LocalEjbReceiver.java:266)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:184)
    at org.jboss.ejb.client.EJBObjectInterceptor.handleInvocation(EJBObjectInterceptor.java:58)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.EJBHomeInterceptor.handleInvocation(EJBHomeInterceptor.java:83)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.TransactionInterceptor.handleInvocation(TransactionInterceptor.java:42)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.as.test.integration.ejb.remote.client.api.interceptor.SimpleEJBClientInterceptor.handleInvocation(SimpleEJBClientInterceptor.java:48)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.ReceiverInterceptor.handleInvocation(ReceiverInterceptor.java:138)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.EJBInvocationHandler.sendRequestWithPossibleRetries(EJBInvocationHandler.java:255)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:200)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:183)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:146)
    at com.sun.proxy.$Proxy386.remove(Unknown Source)
    at org.jboss.as.test.integration.ejb.stateful.passivation.ejb2.PassivationSucceedsEJB2TestCase.testPassivationMaxSize(PassivationSucceedsEJB2TestCase.java:110)
------- Stdout: -------
 [0m04:18:21,258 INFO  [org.infinispan.eviction.impl.PassivationManagerImpl] (ServerService Thread Pool -- 21) ISPN000029: Passivating all entries to disk
 [0m [0m04:18:21,262 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 69) WFLYJPA0011: Stopping Persistence Unit (phase 2 of 2) Service 'passivation-test.jar#main'
 [0m [0m04:18:21,263 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 69) HHH000227: Running hbm2ddl schema export
 [0m [0m04:18:21,264 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 69) HHH000230: Schema export complete
 [0m [0m04:18:21,271 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 69) WFLYJPA0011: Stopping Persistence Unit (phase 1 of 2) Service 'passivation-test.jar#main'
 [0m [33m04:18:21,277 WARN  [org.infinispan.factories.ComponentRegistry] (ServerService Thread Pool -- 21) ISPN000189: While stopping a cache or cache manager, one of its components failed to stop: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.eviction.impl.PassivationManagerImpl.passivateAll() throws org.infinispan.persistence.spi.PersistenceException on object of type PassivationManagerImpl
    at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:172)
    at org.infinispan.factories.AbstractComponentRegistry$PrioritizedMethod.invoke(AbstractComponentRegistry.java:859)
    at org.infinispan.factories.AbstractComponentRegistry.internalStop(AbstractComponentRegistry.java:664)
    at org.infinispan.factories.AbstractComponentRegistry.stop(AbstractComponentRegistry.java:564)
    at org.infinispan.factories.ComponentRegistry.stop(ComponentRegistry.java:260)
    at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:869)
    at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:864)
    at org.infinispan.cache.impl.AbstractDelegatingCache.stop(AbstractDelegatingCache.java:331)


org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testGracefulShutdownConcurrentFailover: java.util.concurrent.ExecutionException: javax.ejb.EJBException: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from node-0, see cause for remote stack trace
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:192)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testConcurrentFailover(RemoteFailoverTestCase.java:325)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testGracefulShutdownConcurrentFailover(RemoteFailoverTestCase.java:295)
Caused by: javax.ejb.EJBException: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from node-0, see cause for remote stack trace
    at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler$1.run(MethodInvocationMessageHandler.java:217)
    at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler.processMessage(MethodInvocationMessageHandler.java:263)
    at org.jboss.as.ejb3.remote.protocol.versionone.VersionOneProtocolChannelReceiver.processMessage(VersionOneProtocolChannelReceiver.java:213)
    at org.jboss.as.ejb3.remote.protocol.versiontwo.VersionTwoProtocolChannelReceiver.processMessage(VersionTwoProtocolChannelReceiver.java:76)
    at org.jboss.as.ejb3.remote.protocol.versionone.VersionOneProtocolChannelReceiver.handleMessage(VersionOneProtocolChannelReceiver.java:159)
    at org.jboss.remoting3.remote.RemoteConnectionChannel$5.run(RemoteConnectionChannel.java:456)
    at org.jboss.remoting3.EndpointImpl$TrackingExecutor$1.run(EndpointImpl.java:731)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
    at ...asynchronous invocation...(Unknown Source)
    at org.jboss.ejb.client.remoting.InvocationExceptionResponseHandler$MethodInvocationExceptionResultProducer.getResult(InvocationExceptionResponseHandler.java:96)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:276)
    at org.jboss.ejb.client.EJBObjectInterceptor.handleInvocationResult(EJBObjectInterceptor.java:64)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.EJBHomeInterceptor.handleInvocationResult(EJBHomeInterceptor.java:88)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.TransactionInterceptor.handleInvocationResult(TransactionInterceptor.java:46)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.ReceiverInterceptor.handleInvocationResult(ReceiverInterceptor.java:142)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:265)
    at org.jboss.ejb.client.EJBClientInvocationContext.awaitResponse(EJBClientInvocationContext.java:453)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:204)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:183)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:146)
    at com.sun.proxy.$Proxy29.increment(Unknown Source)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase$IncrementTask.run(RemoteFailoverTestCase.java:389)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
------- Stdout: -------
04:31:36,299 INFO  [org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase] (main) remote-failover-test.jar:
/org/
/org/jboss/
/org/jboss/as/
/org/jboss/as/test/
/org/jboss/as/test/clustering/
/org/jboss/as/test/clustering/ejb/
/org/jboss/as/test/clustering/ejb/EJBDirectory.class
/org/jboss/as/test/clustering/ejb/AbstractEJBDirectory.class
/org/jboss/as/test/clustering/ejb/LocalEJBDirectory.class


Linux Build 10272 outcome was FAILURE using a merge of 7aa95e9
Summary: Tests failed: 2 (2 new), passed: 3441, ignored: 192 Build time: 01:06:23

Failed tests

org.jboss.as.test.integration.ejb.stateful.passivation.ejb2.PassivationSucceedsEJB2TestCase.testPassivationMaxSize: java.rmi.NoSuchObjectException: WFLYEJB0168: Could not find EJB with id UnknownSessionID [6651545769504854527055665268676656506569495668504857696665505470]
    at org.jboss.as.ejb3.component.interceptors.EjbExceptionTransformingInterceptorFactories$1.processInvocation(EjbExceptionTransformingInterceptorFactories.java:84)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.as.ee.component.NamespaceContextInterceptor.processInvocation(NamespaceContextInterceptor.java:50)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.as.ejb3.component.interceptors.AdditionalSetupInterceptor.processInvocation(AdditionalSetupInterceptor.java:54)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.ContextClassLoaderInterceptor.processInvocation(ContextClassLoaderInterceptor.java:64)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.InterceptorContext.run(InterceptorContext.java:356)
    at org.wildfly.security.manager.WildFlySecurityManager.doChecked(WildFlySecurityManager.java:636)
    at org.jboss.invocation.AccessCheckingInterceptor.processInvocation(AccessCheckingInterceptor.java:61)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.InterceptorContext.run(InterceptorContext.java:356)
    at org.jboss.invocation.PrivilegedWithCombinerInterceptor.processInvocation(PrivilegedWithCombinerInterceptor.java:80)
    at org.jboss.invocation.InterceptorContext.proceed(InterceptorContext.java:340)
    at org.jboss.invocation.ChainedInterceptor.processInvocation(ChainedInterceptor.java:61)
    at org.jboss.as.ee.component.ViewService$View.invoke(ViewService.java:198)
    at org.jboss.as.ejb3.remote.LocalEjbReceiver.processInvocation(LocalEjbReceiver.java:266)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:184)
    at org.jboss.ejb.client.EJBObjectInterceptor.handleInvocation(EJBObjectInterceptor.java:58)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.EJBHomeInterceptor.handleInvocation(EJBHomeInterceptor.java:83)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.TransactionInterceptor.handleInvocation(TransactionInterceptor.java:42)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.as.test.integration.ejb.remote.client.api.interceptor.SimpleEJBClientInterceptor.handleInvocation(SimpleEJBClientInterceptor.java:48)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.ReceiverInterceptor.handleInvocation(ReceiverInterceptor.java:138)
    at org.jboss.ejb.client.EJBClientInvocationContext.sendRequest(EJBClientInvocationContext.java:186)
    at org.jboss.ejb.client.EJBInvocationHandler.sendRequestWithPossibleRetries(EJBInvocationHandler.java:255)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:200)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:183)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:146)
    at com.sun.proxy.$Proxy386.remove(Unknown Source)
    at org.jboss.as.test.integration.ejb.stateful.passivation.ejb2.PassivationSucceedsEJB2TestCase.testPassivationMaxSize(PassivationSucceedsEJB2TestCase.java:110)
------- Stdout: -------
 [0m04:18:21,258 INFO  [org.infinispan.eviction.impl.PassivationManagerImpl] (ServerService Thread Pool -- 21) ISPN000029: Passivating all entries to disk
 [0m [0m04:18:21,262 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 69) WFLYJPA0011: Stopping Persistence Unit (phase 2 of 2) Service 'passivation-test.jar#main'
 [0m [0m04:18:21,263 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 69) HHH000227: Running hbm2ddl schema export
 [0m [0m04:18:21,264 INFO  [org.hibernate.tool.hbm2ddl.SchemaExport] (ServerService Thread Pool -- 69) HHH000230: Schema export complete
 [0m [0m04:18:21,271 INFO  [org.jboss.as.jpa] (ServerService Thread Pool -- 69) WFLYJPA0011: Stopping Persistence Unit (phase 1 of 2) Service 'passivation-test.jar#main'
 [0m [33m04:18:21,277 WARN  [org.infinispan.factories.ComponentRegistry] (ServerService Thread Pool -- 21) ISPN000189: While stopping a cache or cache manager, one of its components failed to stop: org.infinispan.commons.CacheException: Unable to invoke method public void org.infinispan.eviction.impl.PassivationManagerImpl.passivateAll() throws org.infinispan.persistence.spi.PersistenceException on object of type PassivationManagerImpl
    at org.infinispan.commons.util.ReflectionUtil.invokeAccessibly(ReflectionUtil.java:172)
    at org.infinispan.factories.AbstractComponentRegistry$PrioritizedMethod.invoke(AbstractComponentRegistry.java:859)
    at org.infinispan.factories.AbstractComponentRegistry.internalStop(AbstractComponentRegistry.java:664)
    at org.infinispan.factories.AbstractComponentRegistry.stop(AbstractComponentRegistry.java:564)
    at org.infinispan.factories.ComponentRegistry.stop(ComponentRegistry.java:260)
    at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:869)
    at org.infinispan.cache.impl.CacheImpl.stop(CacheImpl.java:864)
    at org.infinispan.cache.impl.AbstractDelegatingCache.stop(AbstractDelegatingCache.java:331)


org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testGracefulShutdownConcurrentFailover: java.util.concurrent.ExecutionException: javax.ejb.EJBException: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from node-0, see cause for remote stack trace
    at java.util.concurrent.FutureTask.report(FutureTask.java:122)
    at java.util.concurrent.FutureTask.get(FutureTask.java:192)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testConcurrentFailover(RemoteFailoverTestCase.java:325)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testGracefulShutdownConcurrentFailover(RemoteFailoverTestCase.java:295)
Caused by: javax.ejb.EJBException: org.infinispan.remoting.RemoteException: ISPN000217: Received exception from node-0, see cause for remote stack trace
    at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler$1.run(MethodInvocationMessageHandler.java:217)
    at org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler.processMessage(MethodInvocationMessageHandler.java:263)
    at org.jboss.as.ejb3.remote.protocol.versionone.VersionOneProtocolChannelReceiver.processMessage(VersionOneProtocolChannelReceiver.java:213)
    at org.jboss.as.ejb3.remote.protocol.versiontwo.VersionTwoProtocolChannelReceiver.processMessage(VersionTwoProtocolChannelReceiver.java:76)
    at org.jboss.as.ejb3.remote.protocol.versionone.VersionOneProtocolChannelReceiver.handleMessage(VersionOneProtocolChannelReceiver.java:159)
    at org.jboss.remoting3.remote.RemoteConnectionChannel$5.run(RemoteConnectionChannel.java:456)
    at org.jboss.remoting3.EndpointImpl$TrackingExecutor$1.run(EndpointImpl.java:731)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
    at ...asynchronous invocation...(Unknown Source)
    at org.jboss.ejb.client.remoting.InvocationExceptionResponseHandler$MethodInvocationExceptionResultProducer.getResult(InvocationExceptionResponseHandler.java:96)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:276)
    at org.jboss.ejb.client.EJBObjectInterceptor.handleInvocationResult(EJBObjectInterceptor.java:64)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.EJBHomeInterceptor.handleInvocationResult(EJBHomeInterceptor.java:88)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.TransactionInterceptor.handleInvocationResult(TransactionInterceptor.java:46)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:290)
    at org.jboss.ejb.client.ReceiverInterceptor.handleInvocationResult(ReceiverInterceptor.java:142)
    at org.jboss.ejb.client.EJBClientInvocationContext.getResult(EJBClientInvocationContext.java:265)
    at org.jboss.ejb.client.EJBClientInvocationContext.awaitResponse(EJBClientInvocationContext.java:453)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:204)
    at org.jboss.ejb.client.EJBInvocationHandler.doInvoke(EJBInvocationHandler.java:183)
    at org.jboss.ejb.client.EJBInvocationHandler.invoke(EJBInvocationHandler.java:146)
    at com.sun.proxy.$Proxy29.increment(Unknown Source)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase$IncrementTask.run(RemoteFailoverTestCase.java:389)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
    at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
------- Stdout: -------
04:31:36,299 INFO  [org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase] (main) remote-failover-test.jar:
/org/
/org/jboss/
/org/jboss/as/
/org/jboss/as/test/
/org/jboss/as/test/clustering/
/org/jboss/as/test/clustering/ejb/
/org/jboss/as/test/clustering/ejb/EJBDirectory.class
/org/jboss/as/test/clustering/ejb/AbstractEJBDirectory.class
/org/jboss/as/test/clustering/ejb/LocalEJBDirectory.class


@kabir kabir merged commit c389a04 into wildfly:master Aug 27, 2016

2 of 3 checks passed

Linux Finished TeamCity Build WildFly :: Pull Request :: Linux : Tests failed: 2 (2 new), passed: 3441, ignored: 192
Details
Linux with security manager Finished TeamCity Build WildFly :: Pull Request :: Linux SM : Tests passed: 1015, ignored: 119
Details
Windows Finished TeamCity Build WildFly :: Pull Request :: Windows : Tests passed: 3426, ignored: 193
Details

@kabir kabir changed the title from [WFLY-6779] added WISE feature code to [Reverted] [WFLY-6779] added WISE feature code Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment