Improve first-run config and add 2048 demo recorder#30
Conversation
DeepSeekCode review of PR #30 (Improve first-run config and add 2048 demo recorder)Let me fetch the PR diff from the remote branch. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1a99597f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ConfigModelAction::Show => { | ||
| let summary = model_config_summary_at(&cwd)?; |
There was a problem hiding this comment.
Keep config show/list commands read-only
This new config model/provider path calls model_config_summary_at/provider_config_summary_at, which in turn call init_config_at when .dscode/config.toml is missing, so a read-only command like deepseek config provider show can create config/hook files in a clean repo. That side effect will unexpectedly dirty worktrees (including the quickstart-recommended flow) and violates the expected semantics of show/list introspection commands.
Useful? React with 👍 / 👎.
| run_session 2>&1 | redact_demo_stream | tee "$demo_out" | ||
| session_status=${PIPESTATUS[0]} |
There was a problem hiding this comment.
Propagate transcript pipeline failures
The script stores only PIPESTATUS[0] after run_session | redact_demo_stream | tee "$demo_out", so it reports success whenever run_session succeeds even if redaction or tee fails (for example, output path not writable or disk full). In those cases the command can exit 0 with a missing/partial transcript, which breaks launch-evidence automation and hides capture failures.
Useful? React with 👍 / 👎.
Summary
Verification