Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional signature and quote catches #68

Closed
wants to merge 3 commits into from

Conversation

gazugafan
Copy link

Catches signature and quotes for Windows 10 Mail.

I've probably made this too generalized, but I needed to catch signature and quotes coming from Mail for Windows 10. They look like this...

My reply here.

Sent from Mail for Windows 10

From: John Doe
Sent: Tuesday, November 13, 2018 12:30 PM
To: me@here.com
Cc: me@gmail.com
Subject: Subject Line Here

The quoted message.

Unfortunately, the existing regex's miss both the signature and the quote. The signature is missed because it lacks a "my" after "Sent from", so I just went ahead and removed the "my" requirement. The quote is missed because the "From:" line only includes a name and lacks an email address in brackets. I loosened it up to only bother checking for a line beginning with "From:".

This is probably related to Issue #66. I haven't run the unit tests, and I'm pretty sure these fixes loosen things up too much, so not exactly suggesting this be merged in as-is. Hoping someone better at regex's comes up with a more proper fix, honestly :)

Catches signature and quote for Windows 10 Mail.
@peter279k
Copy link

The Travis CI build due to failed assertions in unit tests.

Please check them and find the solution to fix assertions.

@peter279k
Copy link

@gazugafan, please check this PR if possible.

Thanks.

@gazugafan
Copy link
Author

Sorry, I don't have time to look into this. Like I was saying, I probably loosened up the regex too much. It works great for my use-case, but maybe not as a generalized fix.

@willdurand
Copy link
Owner

I think this was fixed by another patch.

@willdurand willdurand closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants