Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature bump php #32

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@DavidGoodwin
Copy link
Contributor

commented Apr 3, 2019

  • Update phpunit to avoid PHP 7.x warnings
  • Update travis to add PHP 7.x
  • Update composer to have PHP >= 5.6
@@ -258,7 +258,7 @@ public function testScanWithUserTimeout()
*/
public function testExecutableNotExecutable()
{
$executor = $this->getMock('Nmap\Util\ProcessExecutor');
$executor = $this->createMock('Nmap\Util\ProcessExecutor');

This comment has been minimized.

Copy link
@peter279k

peter279k Apr 19, 2019

If upgrading the PHP version to php-5.6+, the class instance string can use the ::class magic method approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.