Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bulk iteration. #62

Merged
merged 3 commits into from Apr 26, 2018

Conversation

Projects
None yet
2 participants
@lemire
Copy link
Collaborator

commented Apr 17, 2018

Bulk iteration appears to be much faster...

$  go test -bench=BenchmarkLemireIterateManyb
BenchmarkLemireIterateManyb-8   	     500	   3134451 ns/op
$  go test -bench=BenchmarkLemireIterateb
BenchmarkLemireIterateb-8   	     300	   5591849 ns/op

lemire added some commits Apr 17, 2018

@lemire

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2018

The checks fail as follows:

/bin/bash: gas: command not found

The failure does not appear to be related to the Go code.

@lemire

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 17, 2018

Iterating in batches over data structures can be much faster... https://lemire.me/blog/2018/04/17/iterating-in-batches-over-data-structures-can-be-much-faster/

@coveralls

This comment has been minimized.

Copy link

commented Apr 26, 2018

Coverage Status

Coverage decreased (-0.2%) to 96.685% when pulling 7f1803e on lemire:master into 1a37ad9 on willf:master.

@lemire

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 26, 2018

I removed from the tests the astscan test as it is failing for lack of a server-side binary.

@lemire lemire merged commit 8ce1146 into willf:master Apr 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 96.685%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.