fix(pypi): also provide install_extra_args to pypi.install (#1263)

Closes #1224.
williamboman · Apr 26, 2023 · 646ef07 · 646ef07
1 parent ca57774
commit 646ef07
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lua/mason-core/installer/registry/providers/pypi.lua b/lua/mason-core/installer/registry/providers/pypi.lua
@@ -52,6 +52,7 @@ function M.install(ctx, source)
         try(pypi.install(source.package, source.version, {
             extra = source.extra,
             extra_packages = source.extra_packages,
+            install_extra_args = source.pip.extra_args,
         }))
     end)
 end

diff --git a/tests/mason-core/installer/registry/providers/pypi_spec.lua b/tests/mason-core/installer/registry/providers/pypi_spec.lua
@@ -76,7 +76,11 @@ describe("pypi provider :: installing", function()
             install_extra_args = { "--proxy", "http://localghost" },
         }
         assert.spy(manager.install).was_called(1)
-        assert.spy(manager.install).was_called_with("package", "1.5.0", { extra = "lsp", extra_packages = { "extra" } })
+        assert.spy(manager.install).was_called_with(
+            "package",
+            "1.5.0",
+            { extra = "lsp", extra_packages = { "extra" }, install_extra_args = { "--proxy", "http://localghost" } }
+        )
         settings.set(settings._DEFAULT_SETTINGS)
     end)