Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define default transition and add editorconfig #112

Merged
merged 5 commits into from Jul 23, 2019

Conversation

@gabrieluizramos
Copy link
Contributor

commented Jul 23, 2019

There is a slightly difference between the sidebars and the main content (post) transitions.

As you can see at:
Screen Recording 2019-07-23 at 13 37 35

This PR creates some default transitions and applies it at the sidebars and main content containers.

Giving them a default transition like:
Screen Recording 2019-07-23 at 13 37 10

DEFAULT: defaultTransition,
COLOR: colorTransition,
BACKGROUND: bgTransition
};

This comment has been minimized.

Copy link
@willianjusten

willianjusten Jul 23, 2019

Owner

Add a newline please =)
Isn't prettier working with you?

This comment has been minimized.

Copy link
@gabrieluizramos

gabrieluizramos Jul 23, 2019

Author Contributor

Sure!
It works. Actually, I forgot to run the format 😅

I'm also adding a .editorconfig file on this PR :)


[*]
charset = utf-8
indent_style = tab

This comment has been minimized.

Copy link
@willianjusten

willianjusten Jul 23, 2019

Owner

Nooooooooo, spaces >>>> tab

This comment has been minimized.

Copy link
@willianjusten

This comment has been minimized.

Copy link
@gabrieluizramos

gabrieluizramos Jul 23, 2019

Author Contributor

🤣 done

@willianjusten willianjusten changed the title Define default transition for content and sidebars Define default transition and add editorconfig Jul 23, 2019

@willianjusten

This comment has been minimized.

Copy link
Owner

commented Jul 23, 2019

Just tested, everything looks amazing! <3
Thaaaaaanks!

@willianjusten willianjusten merged commit 6d4a76e into willianjusten:master Jul 23, 2019

1 check passed

deploy/netlify Deploy preview ready!
Details
@gabrieluizramos

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.