Migrate to Swift 5 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the generic constraint requirement for Store.unsubscribe(..) to allow any AnyStoreSubscriber conforming object to be passed in.
andrewroycarter
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Looks like the only real change is @objc decorations and public / internal?
| @@ -14,9 +14,9 @@ public protocol NavigationControllerCoordinator: Coordinator { | |||
| } | |||
|
|
|||
| public extension NavigationControllerCoordinator { | |||
| public var rootViewController: UIViewController { return navigationController } | |||
| var rootViewController: UIViewController { return navigationController } | |||
There was a problem hiding this comment.
Why the public / internal change?
There was a problem hiding this comment.
Redundant declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.