New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named notifications and ability to remove some from queue #72

Closed
willsteinmetz opened this Issue Oct 13, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@willsteinmetz
Owner

willsteinmetz commented Oct 13, 2016

@Tudumanu made note in issue #71 that there may be cases of generating two or more notifications at once and keeping only the most recent in the queue. This issue is to add the ability to name a notification upon creation and add a function to remove a notification from the queue by name.

@willsteinmetz willsteinmetz added this to the 4.1 milestone Oct 13, 2016

@willsteinmetz willsteinmetz self-assigned this Oct 13, 2016

@willsteinmetz

This comment has been minimized.

Show comment
Hide comment
@willsteinmetz

willsteinmetz Oct 16, 2016

Owner

When a name is not passed in by the user, a unique name needs to be generated. Likely will use this solution: http://stackoverflow.com/a/2117523/5870787

Owner

willsteinmetz commented Oct 16, 2016

When a name is not passed in by the user, a unique name needs to be generated. Likely will use this solution: http://stackoverflow.com/a/2117523/5870787

willsteinmetz added a commit that referenced this issue Oct 16, 2016

#72 - Named notifications and ability to remove some from queue
Adding the notification name options to the demo page.

willsteinmetz added a commit that referenced this issue Oct 16, 2016

#72 - Named notifications and ability to remove some from queue
Generating a notification name when not passed in and returning it when a notification is created or queued.

willsteinmetz added a commit that referenced this issue Oct 16, 2016

#72 - Named notifications and ability to remove some from queue
Adding the notification name to the HTML generated for the notification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment